💬 ismaelsadeeq commented on pull request "Wallet: Add `max_tx_weight` to transaction funding options (take 2)":
(https://github.com/bitcoin/bitcoin/pull/29523#issuecomment-2180079920)
thanks for your review @furszy will force push to address this comments shortly.

💬 Sjors commented on pull request "net: Replace libnatpmp with built-in PCP+NATPMP implementation":
(https://github.com/bitcoin/bitcoin/pull/30043#discussion_r1647158425)
Good point, maybe just add a comment about this. FreeBSD 13 won't be EOL for another two years, so someone else might wonder.

💬 vasild commented on pull request "util: check for errors after close and read in AutoFile":
(https://github.com/bitcoin/bitcoin/pull/29307#discussion_r1647164965)
I just found a similar code to this proposed change:

https://github.com/bitcoin/bitcoin/blob/2d21060af831fa8f8f1791b4464961d5f28a88cb/src/node/utxo_snapshot.cpp#L74-L80

After reading from a file and getting everything that is needed from it, the code checks if there is an extra data and if that read fails it reports an error.

💬 maflcko commented on pull request "Support self-hosted Cirrus workers on forks":
(https://github.com/bitcoin/bitcoin/pull/29274#discussion_r1647165078)
> I don't know how common ARM is for servers these days? I'm assuming it's mostly used by Apple, and for very low performance devices like Raspberry Pi's.

ARM is common in servers and all major cloud providers offer it. GHA does not offer it for Linux, only macOS M1, which is why I was wondering if it is possible to run ARM Linux containers on macOS M1?

> It's probably not too much hassle if there's clear instructions on how to do that on e.g. an AMD based Ubuntu machine.

It depends on
...

💬 Sjors commented on pull request "Stratum v2 Noise Protocol":
(https://github.com/bitcoin/bitcoin/pull/29346#issuecomment-2180091233)
I'm still hopeful sv1 translators won't be needed at all soon(tm). That certainly seems too complicated to implement in Bitcoin Core.

For the same reason I don't think combining JDC and Translator is a good long term solution, though in the short run it could make the SRI side of things easier to configure.

See also the conceptual discussion in https://github.com/stratum-mining/sv2-spec/discussions/85

💬 Sjors commented on pull request "Support self-hosted Cirrus workers on forks":
(https://github.com/bitcoin/bitcoin/pull/29274#discussion_r1647173189)
After `podman run` is there some VM running that I have to login to, install the Cirrus job runner? Or is there some change needed to `00_setup_env_arm.sh` to make it use this?

💬 maflcko commented on issue "ci: Move more tasks to GHA?":
(https://github.com/bitcoin/bitcoin/issues/30304#issuecomment-2180100968)
> The other jobs run fine on my Ubuntu machine(s) with not too much configuration.

Sure, but for others it may be too much hassle? See https://github.com/bitcoin-inquisition/bitcoin/pull/32#issue-1874824335

💬 maflcko commented on pull request "Support self-hosted Cirrus workers on forks":
(https://github.com/bitcoin/bitcoin/pull/29274#discussion_r1647183350)
You don't need to log in to anything, and everything should work out of the box without code modifications. I can try to test, if you provide more details about your exact system, and whether you intend to use podman-docker or docker.

💬 Sjors commented on issue "ci: Move more tasks to GHA?":
(https://github.com/bitcoin/bitcoin/issues/30304#issuecomment-2180115136)
They didn't try self-hosting _or_ paying. It doesn't seem like a good strategy to constantly flock to whichever company offers free resources. It would be nice if we can make it more flexible in an easy way.

E.g. someone maintaining a fork could upload a yaml file somewhere that specifies which jobs should be run by which cloud provider / self host, and which should be skipped.

💬 maflcko commented on pull request "util: check for errors after close and read in AutoFile":
(https://github.com/bitcoin/bitcoin/pull/29307#discussion_r1647191325)
The code you linked to is primarily checking for unexpected trailing data and only printing a warning. It is not making the program possibly unusable.

💬 fanquake commented on pull request "QA: Expect PACKAGE_NAME rather than constant "Bitcoin Core"":
(https://github.com/bitcoin/bitcoin/pull/30308#issuecomment-2180131521)
> not sure if you want to update here aswell in this PR

@luke-jr can you update this PR to include the additional changes.

💬 fanquake commented on pull request "depends: bump miniupnpc to 2.2.8":
(https://github.com/bitcoin/bitcoin/pull/30301#issuecomment-2180137005)
> Marked as draft until https://github.com/bitcoin/bitcoin/pull/30283 is merged.

Can rebase / undraft this now.

✅ fanquake closed an issue: "fuzz: wallet_bdb_parser: implicit-signed-integer-truncation wallet/migrate.cpp:554:35 "
(https://github.com/bitcoin/bitcoin/issues/30247)

🚀 fanquake merged a pull request: "refactor: Add explicit cast to expected_last_page to silence fuzz ISan"
(https://github.com/bitcoin/bitcoin/pull/30248)

💬 Sjors commented on pull request "Support self-hosted Cirrus workers on forks":
(https://github.com/bitcoin/bitcoin/pull/29274#discussion_r1647210274)
Thanks. I currently use `podman-docker` on Ubuntu 24.04. I created several `cirrus{1,2,3,4,5}` users.

For `cirrus1` I set `type: arm64`. I turned off `NO_ARM=true` for the occasion.

I installed `qemu-user-static` (`bash` and `podman-docker` were already there).

I ran your `podman run ...` incantation as the `cirrus1` user. And then started the worker:

```
RESTART_CI_DOCKER_BEFORE_RUN=1 USER_MODE=true MAKEJOBS=-j10 cirrus worker run -f ~/.cirrus.yaml
```

I then force-pushed an u
...

💬 Sjors commented on pull request "Support self-hosted Cirrus workers on forks":
(https://github.com/bitcoin/bitcoin/pull/29274#discussion_r1647216097)
The CPU is an AMD Ryzen 9 7950X.

💬 maflcko commented on issue "ci: Move more tasks to GHA?":
(https://github.com/bitcoin/bitcoin/issues/30304#issuecomment-2180151859)
Personally I think

* it is cleaner to not offer (and maintain) a bunch of config options for the CI services
* self-hosting is too much overhead for forks (especially for Windows/macOS builds)
* GHA is already required, and if they charged a price, someone would likely pay for it (if it is reasonably priced)
* Anyone really wanting to self-host can already do it today by writing their own CI provider and CI integration (the CI system itself only requires docker/podman)

Happy to close th
...

💬 maflcko commented on pull request "Support self-hosted Cirrus workers on forks":
(https://github.com/bitcoin/bitcoin/pull/29274#discussion_r1647220506)
> exec container process `/usr/bin/bash`: Exec format error

You can reproduce this outside the CI system with:

```
podman run --rm -ti "docker.io/arm64v8/debian:bookworm" uname --machine
```

You should be able to fix it by calling once:

```
podman run --rm --privileged docker.io/multiarch/qemu-user-static --reset -p yes
```

(and then double check with the previous command)

🚀 fanquake merged a pull request: "fuzz: Fix wallet_bdb_parser 32-bit unhandled fseek error"
(https://github.com/bitcoin/bitcoin/pull/30307)

💬 maflcko commented on pull request "QA: Expect PACKAGE_NAME rather than constant "Bitcoin Core"":
(https://github.com/bitcoin/bitcoin/pull/30308#issuecomment-2180168079)
previous releaseas are hardcoded to be Bitcoin Core, so need to change that

I wonder if one CI task should modify the PACKAGE_NAME to be something else, e.g. `Bitcoin Core CI-build`?