💬 maflcko commented on issue "ci: Move more tasks to GHA?":
(https://github.com/bitcoin/bitcoin/issues/30304#issuecomment-2178432910)
> Am I missing some reason for doing things this way?

See https://github.com/bitcoin/bitcoin/pull/28292#discussion_r1298058749 . This is one of the reasons why I personally don't like GHA: It is a closed, confusing, and brittle ecosystem. The only benefit is that it is free (for now).

📝 maflcko opened a pull request: "fuzz: Fix wallet_bdb_parser 32-bit unhandled fseek error"
(https://github.com/bitcoin/bitcoin/pull/30307)
`std::fseek` on 64-bit past the end of the file may work fine (the following read would fail). However, on 32-bit it may fail early.

Fix it, by ignoring the error, treating it similar to a read error.

🤔 glozow reviewed a pull request: "test: Validate oversized transactions or without inputs"
(https://github.com/bitcoin/bitcoin/pull/29862#pullrequestreview-2127984342)
utACK 969e047cfbab86e5819a2c9056e8d2dab17513a8

Last commit looks irrelevant to the added test and can be dropped.

💬 paplorinc commented on pull request "test: Validate oversized transactions or without inputs":
(https://github.com/bitcoin/bitcoin/pull/29862#issuecomment-2178484396)
> Last commit looks irrelevant to the added test and can be dropped.

Thanks for the review! The last commit is touching the existing `bad-txns-oversize` equivalent in Python - do you want me drop it?

💬 maflcko commented on pull request "fuzz: Fix wallet_bdb_parser 32-bit unhandled fseek error":
(https://github.com/bitcoin/bitcoin/pull/30307#issuecomment-2178484640)
Example:

```
$ base64 ~/Downloads/clusterfuzz-testcase-minimized-wallet_bdb_parser-5937261974716416
ICD//yAgICAAAAAAAAUxYgAAAAkAAAIAAAkgICAgICAAAAAAICAgICAgICAgICAgAAAAIP//ICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICD/ICAgICAg////////ICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAg////ICD//yAgICAgICAgICAgICAgICAgICAg////////
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg////ICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIP///yAgICAg
ICAg
...

✅ glozow closed an issue: "fuzz: timeout/oom in package_rbf"
(https://github.com/bitcoin/bitcoin/issues/30241)

🚀 glozow merged a pull request: "fuzz: have package_rbf always make small txns"
(https://github.com/bitcoin/bitcoin/pull/30300)

💬 maflcko commented on pull request "[27.x] More backports":
(https://github.com/bitcoin/bitcoin/pull/30305#issuecomment-2178487579)
CI note: If you want the Asan task, you'll have to backport it from GHA

💬 m3dwards commented on issue "ci: Move more tasks to GHA?":
(https://github.com/bitcoin/bitcoin/issues/30304#issuecomment-2178488773)

> It has a limit of 10 GB, so I am not sure if it can fit everything. https://github.com/bitcoin/bitcoin/actions/caches

@fanquake might be able to get us more?

💬 alfonsoromanz commented on pull request "test: Assumeutxo: import snapshot in a node with a divergent chain":
(https://github.com/bitcoin/bitcoin/pull/29996#discussion_r1646020872)
Fixed

💬 alfonsoromanz commented on pull request "test: Assumeutxo: import snapshot in a node with a divergent chain":
(https://github.com/bitcoin/bitcoin/pull/29996#discussion_r1646021806)
Fixed

🤔 glozow reviewed a pull request: "net_processing: make any misbehavior trigger immediate discouragement"
(https://github.com/bitcoin/bitcoin/pull/29575#pullrequestreview-2128012597)
light code review / concept ACK 6eecba475efd025eb011400af58621ad5823994e

💬 fanquake commented on pull request "ci: move ASan job to GitHub Actions from Cirrus CI":
(https://github.com/bitcoin/bitcoin/pull/30193#issuecomment-2178509616)
Backported to 27.x in #30305.

💬 fanquake commented on pull request "ci: remove unused bcc variable from workflow":
(https://github.com/bitcoin/bitcoin/pull/30299#issuecomment-2178509864)
Backported to 27.x in #30305.

💬 maflcko commented on issue "ci: Move more tasks to GHA?":
(https://github.com/bitcoin/bitcoin/issues/30304#issuecomment-2178513643)
I am not sure how increasing the cache size limit would be possible.

💬 alfonsoromanz commented on pull request "test: Assumeutxo: import snapshot in a node with a divergent chain":
(https://github.com/bitcoin/bitcoin/pull/29996#discussion_r1646036157)
Thanks. I removed the line as suggested. I wasn't sure which chainstates check might be useful to add. Something like [this](https://github.com/bitcoin/bitcoin/blob/master/test/functional/feature_assumeutxo.py#L322C7-L328C51), maybe?

💬 Sjors commented on pull request "contrib: add tool to convert compact-serialized UTXO set to SQLite database":
(https://github.com/bitcoin/bitcoin/pull/27432#issuecomment-2178536123)
Ah nice, I'll try that (tomorrow probably).

💬 alfonsoromanz commented on pull request "test: Assumeutxo: import snapshot in a node with a divergent chain":
(https://github.com/bitcoin/bitcoin/pull/29996#issuecomment-2178578099)
Pushed changes to address the latest feedback from fjahr

💬 AngusP commented on pull request "test: Add Compact Block Encoding test `ReceiveWithExtraTransactions` covering non-empty `extra_txn`":
(https://github.com/bitcoin/bitcoin/pull/30237#discussion_r1646108157)
I'm not familiar with the fuzz tests so I hope this change isn't stupid/wrong?

💬 Eunovo commented on pull request "wallet: Fix listwalletdir listing of migrated default wallets and generated backup files":
(https://github.com/bitcoin/bitcoin/pull/30265#issuecomment-2178623704)
Tested ACK https://github.com/bitcoin/bitcoin/pull/30265/commits/0ce7c6294bf58142de55372d6448416a73f4caa5
I ran the `wallet_migration` test locally and also prepared a wallets directory with a default wallet file, a backup file and a legacy wallet file for manual testing. Running `listwalletdir` on master returned the following output
```
{
"wallets": [
{
"name": "boblegacy_1718798800.legacy.bak"
},
{
"name": "boblegacy"
}
]
}
```
And `listwalletdir`
...