💬 m3dwards commented on issue "ci: Move more tasks to GHA?":
(https://github.com/bitcoin/bitcoin/issues/30304#issuecomment-2178342409)
I didn't know PR authors could re-run tasks on Cirrus.

It is nice that you can run the jobs on your own fork, I quite often now just push a random commit to my fork to trigger the CI jobs as an experiment.

Conceivably the jobs could be on both Cirrus and GHA and only run on GHA for forks. Extra maintenance burden probably not worth it though.

How are the depends artefacts cached on Cirrus? And which docker images are you referring to? The CI build one?

Happy to volunteer to move more
...

💬 maflcko commented on issue "ci: Move more tasks to GHA?":
(https://github.com/bitcoin/bitcoin/issues/30304#issuecomment-2178364258)
> How are the depends artefacts cached on Cirrus? And which docker images are you referring to? The CI build one?

Cirrus itself has a simple and easy to use `cache` instruction. However, currently, the cache is implicit, because persistent workers are used.

With images I mean the ones listed by `podman image ls`, that is:


```
REPOSITORY TAG IMAGE ID CREATED SIZE
localhost/ci_native_asan latest 582be28
...

👍 willcl-ark approved a pull request: "chainparams: Add achow101 DNS seeder"
(https://github.com/bitcoin/bitcoin/pull/30007#pullrequestreview-2127870940)
reACK 2721d64989c2b2114890586b7efd01ab4b062ca6

Retested that the seed on the new domain for each chain is returning good addresses.

💬 hebasto commented on pull request "depends: build libevent with CMake":
(https://github.com/bitcoin/bitcoin/pull/29835#issuecomment-2178380700)
Is something required to undraft this PR?

💬 fanquake commented on pull request "depends: build libevent with CMake":
(https://github.com/bitcoin/bitcoin/pull/29835#issuecomment-2178382324)
We aren't getting much from master, so this is now just a switch to CMake. Once this lands, with CMake, a (minimal) depends + Core build will be possible entirely without autotools.

💬 m3dwards commented on issue "ci: Move more tasks to GHA?":
(https://github.com/bitcoin/bitcoin/issues/30304#issuecomment-2178391045)
Could we use this to cache the images? https://docs.docker.com/build/cache/backends/gha/

We are using the GHA cache at the moment, is there a reason why this woudln't work for depends? Or is it just the effort required to split up the current CI script into different steps to take advantage of GHA cache?

💬 maflcko commented on pull request "ci: move ASan job to GitHub Actions from Cirrus CI":
(https://github.com/bitcoin/bitcoin/pull/30193#discussion_r1645950272)
https://github.com/bitcoin/bitcoin/actions/runs/9579271766/job/26411361263#step:7:12

```
Warning: Path Validation Error: Path(s) specified in the action for caching do(es) not exist, hence no cache is being saved.

💬 maflcko commented on issue "ci: Move more tasks to GHA?":
(https://github.com/bitcoin/bitcoin/issues/30304#issuecomment-2178413548)
> We are using the GHA cache at the moment, is there a reason why this woudln't work for depends?

It has a limit of 10 GB, so I am not sure if it can fit everything. https://github.com/bitcoin/bitcoin/actions/caches

💬 willcl-ark commented on issue "ci: Move more tasks to GHA?":
(https://github.com/bitcoin/bitcoin/issues/30304#issuecomment-2178426349)
I actually meant to ask this in #30193, but why do we cache using run-id in the key `${{ github.job }}-ccache-${{ github.run_id }}` ? As we only cache on master, using only `${{ github.job }}-ccache` would make more sense to me; a single rolling cache per job.

When we search for the cache to load we use a "wildcard" restore `restore-keys: ${{ github.job }}-ccache-` (with no run_id).

This would remove some "duplicates", e.g "macos-native-x86_64-ccache-" has 3 cache entries, when it only nee
...

💬 maflcko commented on issue "ci: Move more tasks to GHA?":
(https://github.com/bitcoin/bitcoin/issues/30304#issuecomment-2178432910)
> Am I missing some reason for doing things this way?

See https://github.com/bitcoin/bitcoin/pull/28292#discussion_r1298058749 . This is one of the reasons why I personally don't like GHA: It is a closed, confusing, and brittle ecosystem. The only benefit is that it is free (for now).

📝 maflcko opened a pull request: "fuzz: Fix wallet_bdb_parser 32-bit unhandled fseek error"
(https://github.com/bitcoin/bitcoin/pull/30307)
`std::fseek` on 64-bit past the end of the file may work fine (the following read would fail). However, on 32-bit it may fail early.

Fix it, by ignoring the error, treating it similar to a read error.

🤔 glozow reviewed a pull request: "test: Validate oversized transactions or without inputs"
(https://github.com/bitcoin/bitcoin/pull/29862#pullrequestreview-2127984342)
utACK 969e047cfbab86e5819a2c9056e8d2dab17513a8

Last commit looks irrelevant to the added test and can be dropped.

💬 paplorinc commented on pull request "test: Validate oversized transactions or without inputs":
(https://github.com/bitcoin/bitcoin/pull/29862#issuecomment-2178484396)
> Last commit looks irrelevant to the added test and can be dropped.

Thanks for the review! The last commit is touching the existing `bad-txns-oversize` equivalent in Python - do you want me drop it?

💬 maflcko commented on pull request "fuzz: Fix wallet_bdb_parser 32-bit unhandled fseek error":
(https://github.com/bitcoin/bitcoin/pull/30307#issuecomment-2178484640)
Example:

```
$ base64 ~/Downloads/clusterfuzz-testcase-minimized-wallet_bdb_parser-5937261974716416
ICD//yAgICAAAAAAAAUxYgAAAAkAAAIAAAkgICAgICAAAAAAICAgICAgICAgICAgAAAAIP//ICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICD/ICAgICAg////////ICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAg////ICD//yAgICAgICAgICAgICAgICAgICAg////////
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg////ICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIP///yAgICAg
ICAg
...

✅ glozow closed an issue: "fuzz: timeout/oom in package_rbf"
(https://github.com/bitcoin/bitcoin/issues/30241)

🚀 glozow merged a pull request: "fuzz: have package_rbf always make small txns"
(https://github.com/bitcoin/bitcoin/pull/30300)

💬 maflcko commented on pull request "[27.x] More backports":
(https://github.com/bitcoin/bitcoin/pull/30305#issuecomment-2178487579)
CI note: If you want the Asan task, you'll have to backport it from GHA

💬 m3dwards commented on issue "ci: Move more tasks to GHA?":
(https://github.com/bitcoin/bitcoin/issues/30304#issuecomment-2178488773)

> It has a limit of 10 GB, so I am not sure if it can fit everything. https://github.com/bitcoin/bitcoin/actions/caches

@fanquake might be able to get us more?

💬 alfonsoromanz commented on pull request "test: Assumeutxo: import snapshot in a node with a divergent chain":
(https://github.com/bitcoin/bitcoin/pull/29996#discussion_r1646020872)
Fixed

💬 alfonsoromanz commented on pull request "test: Assumeutxo: import snapshot in a node with a divergent chain":
(https://github.com/bitcoin/bitcoin/pull/29996#discussion_r1646021806)
Fixed