💬 stratospher commented on pull request "p2p: skip netgroup diversity of new connections for tor/i2p/cjdns":
(https://github.com/bitcoin/bitcoin/pull/27374#issuecomment-1491700077)
> It doesn't seem to me like it matters much which way we do this, since I believe netgroups for different networks cannot collide, so this looks fine to me.

> I think the same logic needs to be applied to the anchors in

i didn't add tor/i2p/cjdns peer addresses in `setConnected` to skip the netgroup diversity check when making both outbound and anchor connections. (now understood from the above comments why it won't work)

> As far as I can see, this logic should equally be applied to
...

💬 MarcoFalke commented on pull request "ci: use LLVM/clang-16 in native_asan job":
(https://github.com/bitcoin/bitcoin/pull/27360#issuecomment-1491715912)
test comment (ignore)

💬 fanquake commented on pull request "test: Remove python3.5 workaround":
(https://github.com/bitcoin/bitcoin/pull/27378#discussion_r1154334637)
Can drop `-rpcservertimeout=900` from feature_dbcrash given we are setting the default here?

💬 dergoegge commented on pull request "refactor: Move CNodeState members guarded by g_msgproc_mutex to Peer":
(https://github.com/bitcoin/bitcoin/pull/26140#discussion_r1154339822)
Actually this doesn't work because `mapRelay` is guraded by `cs_main`😭😭😭

💬 dergoegge commented on pull request "refactor: Move CNodeState members guarded by g_msgproc_mutex to Peer":
(https://github.com/bitcoin/bitcoin/pull/26140#discussion_r1154345076)
But... `mapRelay` is actually only accessed from the msg proc thread, so we can simply mark it as guarded by `g_msgproc_mutex` and still do this!

📝 dergoegge opened a pull request: "#26140 follow-ups"
(https://github.com/bitcoin/bitcoin/pull/27379)
Addresses left over feedback from #26140.

* https://github.com/bitcoin/bitcoin/pull/26140#discussion_r1153498543
* https://github.com/bitcoin/bitcoin/pull/26140#discussion_r1153499627

💬 fanquake commented on pull request "contrib: allow multi-sig binary verification v2":
(https://github.com/bitcoin/bitcoin/pull/27358#discussion_r1154356697)
[I mentioned in the original PR, that I think this can just be dropped](https://github.com/bitcoin/bitcoin/pull/23020#discussion_r1117049036). We know we are downloading bitcoin-core, so I'm not sure why we need to support anything other than just passing in a version number.

💬 fanquake commented on pull request "contrib: allow multi-sig binary verification v2":
(https://github.com/bitcoin/bitcoin/pull/27358#discussion_r1154358057)
From https://github.com/bitcoin/bitcoin/pull/23020#discussion_r1117050954
> Should we just add an explicit `--delete` argument to the script, rather than "append a random anything", as was proposed in https://github.com/bitcoin/bitcoin/pull/26985.

📝 hebasto opened a pull request: "Update translation source file for v25.0 string freeze"
(https://github.com/bitcoin-core/gui/pull/724)
This PR updates the `src/qt/locale/bitcoin_en.xlf` translation source file according to [Release schedule for 24.0](https://github.com/bitcoin/bitcoin/issues/26549).

Some translation-related fixes have been picked from https://github.com/bitcoin-core/gui/pull/599 and https://github.com/bitcoin-core/gui/pull/716.

Note for reviewers: it is expected to get a zero diff after running `make -C src translate` locally.

💬 hebasto commented on issue "Release schedule for 25.0":
(https://github.com/bitcoin/bitcoin/issues/26549#issuecomment-1491778338)
> ## 2023-04-01 :construction:
>
> * Translation string freeze (no more source language changes until release)

See https://github.com/bitcoin-core/gui/pull/724.

💬 hebasto commented on pull request "Update translation source file for v25.0 string freeze":
(https://github.com/bitcoin-core/gui/pull/724#issuecomment-1491779639)
cc @luke-jr @furszy @jarolrod

💬 hebasto commented on pull request "Translatability fixups":
(https://github.com/bitcoin-core/gui/pull/599#discussion_r1154364704)
2e55d10ac487c2799c4530a7bec8767f1b2303e4

It seems not passing to the translation file properly.

💬 stratospher commented on pull request "p2p: skip netgroup diversity of new connections for tor/i2p/cjdns":
(https://github.com/bitcoin/bitcoin/pull/27374#issuecomment-1491829321)
updated the PR to do option 1:
- Added an additional check inside `LimitOutboundByNetgroup()` to skip netgroup diversity checks for outbound connections belonging to pure Tor-only/I2P-only/CJDNS-only networks.
- used this function as a gatekeeper before choosing diverse netgroup addresses to make outbound connections to.

still curious to know opinions about increasing 4 bits to 5 bits in `GetGroup()`.

💬 stratospher commented on pull request "p2p: skip netgroup diversity of new connections for tor/i2p/cjdns":
(https://github.com/bitcoin/bitcoin/pull/27374#discussion_r1154395877)
thanks! done.

💬 stratospher commented on pull request "p2p: skip netgroup diversity of new connections for tor/i2p/cjdns":
(https://github.com/bitcoin/bitcoin/pull/27374#discussion_r1154396262)
thanks! done.

💬 stratospher commented on pull request "p2p: skip netgroup diversity of new connections for tor/i2p/cjdns":
(https://github.com/bitcoin/bitcoin/pull/27374#discussion_r1154401852)
we would reach here when size of `onlynets` is 1. it's possible that `m_net` doesn't belong to the network we mention in `onlynets` but that would be handled in [reachability check](https://github.com/bitcoin/bitcoin/blob/47184cfa2f62290c00f960ddf74a7c1b5d3578b0/src/net.cpp#L1855) in `ThreadOpenConnections()` and we wouldn't use that address anyways.

🚀 fanquake merged a pull request: "ci: Remove second user account"
(https://github.com/bitcoin/bitcoin/pull/27376)

⚠️ dergoegge opened an issue: "Intermittent failures in interface_usdt_mempool.py"
(https://github.com/bitcoin/bitcoin/issues/27380)
https://cirrus-ci.com/task/5779522121891840

```
[0;34m node0 2023-03-31T11:45:58.812384Z (mocktime: 2023-04-14T11:46:01Z) [http] [httpserver.cpp:257] [http_request_cb] [http] Received a POST request for / from 127.0.0.1:38238 [0m
[0;34m node0 2023-03-31T11:45:58.812543Z (mocktime: 2023-04-14T11:46:01Z) [httpworker.2] [rpc/request.cpp:179] [parse] [rpc] ThreadRPCServer method=getpeerinfo user=__cookie__ [0m
[0;36m test 2023-03-31T11:45:58.814000Z TestFramework (INFO): Hooking into mem
...

💬 dergoegge commented on issue "Intermittent failures in interface_usdt_mempool.py":
(https://github.com/bitcoin/bitcoin/issues/27380#issuecomment-1491844460)
Have seen this a couple times by now.

cc @0xB10C @virtu

💬 hebasto commented on pull request "net processing: #26140 follow-ups":
(https://github.com/bitcoin/bitcoin/pull/27379#discussion_r1154410052)
Mention this in the PR description?