✅ achow101 closed an issue: "bump: ignore WALLET_INCREMENTAL_RELAY_FEE when user specifies fee rate"
(https://github.com/bitcoin/bitcoin/issues/26973)

🚀 achow101 merged a pull request: "bumpfee: ignore WALLET_INCREMENTAL_RELAY_FEE when user specifies fee_rate"
(https://github.com/bitcoin/bitcoin/pull/27969)

💬 ryanofsky commented on issue "RFC: Assumeutxo and large forks and reorgs":
(https://github.com/bitcoin/bitcoin/issues/30288#issuecomment-2168713360)
> I think that the concept of the Active Chainstate / Active Tip is important for this this discussion

Agree it's worth mentioning. I think decisions about how chainstates are synced are mostly separate from decisions about how they are used and prioritized. But for completeness, I was assuming that if the original chainstate ever had more work than the snapshot chainstate, the snapshot chainstate would be unused and could be deleted, and the original chainstate would become the "active" chai
...

⚠️ kosuodhmwa opened an issue: "Wallet ""mywallet" gone after i shut down bitcoind in console and then restart it"
(https://github.com/bitcoin/bitcoin/issues/30290)
It will not be listed anymore, but when i try to create a new wallet with equivalent name, i will get an error message...


💬 sipa commented on issue "Wallet ""mywallet" gone after i shut down bitcoind in console with ctrl-c and then restart it":
(https://github.com/bitcoin/bitcoin/issues/30290#issuecomment-2168764805)
Presumably the wallet is not configured as autoload. You can load it manually with the `loadwallet [walletfilename]` RPC. `listwallets` only lists loaded wallets.

💬 kosuodhmwa commented on issue "Wallet ""mywallet" gone after i shut down bitcoind in console with ctrl-c and then restart it":
(https://github.com/bitcoin/bitcoin/issues/30290#issuecomment-2168774904)
thank you very much, now i've added it to the ~/.bitcoin/bitcoin.conf file:

**_wallet=mywallet_**

✅ kosuodhmwa closed an issue: "Wallet ""mywallet" gone after i shut down bitcoind in console with ctrl-c and then restart it"
(https://github.com/bitcoin/bitcoin/issues/30290)

💬 kosuodhmwa commented on issue "Wallet ""mywallet" gone after i shut down bitcoind in console with ctrl-c and then restart it":
(https://github.com/bitcoin/bitcoin/issues/30290#issuecomment-2168775092)
Closed

💬 BenWestgate commented on issue "Pruning keeps getting reenabled":
(https://github.com/bitcoin-core/gui/issues/709#issuecomment-2168847956)
Letting Bitcoin-Qt search for bitcoin.conf in `$XDG_CONFIG_HOME/Bitcoin` and reading it from your internal drive if present would resolve this issue. As is, bitcoin.conf is not read until after that choosedatadir window is dismissed.
https://github.com/bitcoin/bitcoin/issues/16733

📝 tdb3 opened a pull request: "test: write functional test results to csv"
(https://github.com/bitcoin/bitcoin/pull/30291)
Adds argument `--resultsfile` to test_runner.py.
Enables functional test results to be written to a (csv) file for processing by other applications (or for historical archiving).
Test name, status, and duration are written to the file provided with the argument.


#### Notes
- Total runtime of functional tests has seemed to have increased on my development machines over the past few months (more tests added, individual test runtime increase, etc.). Was interested in recording test runtim
...

💬 dominicusadinfinitum commented on issue "Testsuite for Bitcoin Core 27.0.0 - FAIL: qt/test/test_bitcoin-qt":
(https://github.com/bitcoin/bitcoin/issues/30020#issuecomment-2169135730)
@hebasto @maflcko @willcl-ark

Thank you for your support!
I could run the test successfully.
So, I forgot my admin password for the Raspberry Pi 5 (whoopsie).
Started from scratch again, used the v27.0 Version again, committed the extra files ds and ... until there was nothing more to commit. Did not use BDB and GUI, just the necessary packages with sqlite.

I assume I did not fully commit the extra files and now its's working.

Thanks again for supporting me on my Bitcoin journey - C
...

💬 maflcko commented on pull request "test: write functional test results to csv":
(https://github.com/bitcoin/bitcoin/pull/30291#issuecomment-2169191755)
lgtm ACK ee3b5c7fb4e81f833bb8a7db6c14b4734a2d3133

💬 dergoegge commented on pull request "Tr partial descriptors":
(https://github.com/bitcoin/bitcoin/pull/30243#issuecomment-2169240015)
Found a crash in the `mocked_descriptor_parse` fuzz target, to reproduce:

```
$ echo "dHIoJUJELHJhd2xlYWYoQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCLEE3LCUyNywlQjcsJTIzLCVCZCwlRkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQk
...

💬 maflcko commented on pull request "Several randomness improvements":
(https://github.com/bitcoin/bitcoin/pull/29625#discussion_r1640954007)
> It appeared to be necessary, IIRC.

Yes, it is required. However, adding the annotation will only silence the compiler warning.

`FastRandomContext` is not thread safe, so the lock will actually have to be taken.

Putting an `EXCLUSIVE_LOCKS_REQUIRED` only into the c++ file and leaving it out from the header file will not work, because the compiler has no way to see the annotation outside of the module. For example, it can not be seen from `init.cpp`.

💬 maflcko commented on pull request "Several randomness improvements":
(https://github.com/bitcoin/bitcoin/pull/29625#issuecomment-2169245079)
Ok, I think I found the bug: https://github.com/bitcoin/bitcoin/pull/29625/files#r1640954007

It is in your code, and not a compiler bug :sweat_smile:

💬 Eunovo commented on pull request "Tr partial descriptors":
(https://github.com/bitcoin/bitcoin/pull/30243#issuecomment-2169251574)
> Found a crash in the `mocked_descriptor_parse` fuzz target, to reproduce:
>

Thanks for this @dergoegge I'll fix it

👍 1440000bytes approved a pull request: "chainparams: Add achow101 DNS seeder"
(https://github.com/bitcoin/bitcoin/pull/30007#pullrequestreview-2120313513)
reACK https://github.com/bitcoin/bitcoin/pull/30007/commits/2721d64989c2b2114890586b7efd01ab4b062ca6

👍 rkrux approved a pull request: "test: fix `keys_to_multisig_script` (P2MS) helper for n/k > 16"
(https://github.com/bitcoin/bitcoin/pull/28312#pullrequestreview-2120422373)
reACK [5cf0a1f](https://github.com/bitcoin/bitcoin/pull/28312/commits/5cf0a1f230389ef37e0ff65de5fc98394f32f60c)

Re-ran make and all functional tests, both are successful.
Thanks @theStack for catching this.

💬 sipa commented on pull request "Several randomness improvements":
(https://github.com/bitcoin/bitcoin/pull/29625#issuecomment-2169520624)
> Ok, I think I found the bug: https://github.com/bitcoin/bitcoin/pull/29625/files#r1640954007
>
> It is in your code, and not a compiler bug :sweat_smile:

Wow, nice catch, thank you. Will fix next week.

💬 sipa commented on pull request "Several randomness improvements":
(https://github.com/bitcoin/bitcoin/pull/29625#discussion_r1641145353)
Ok, apparently these annotations are not nearly as smart as I assumed they were!