💬 vasild commented on pull request "fuzz: FuzzedSock::Recv() don't lose bytes from MSG_PEEK read":
(https://github.com/bitcoin/bitcoin/pull/30273#discussion_r1640065200)
> Did you run it with the I2P dictionary?

No. How do I do that? Do you have a Base64 of the crash unit?

💬 m3dwards commented on pull request "net: Allow -proxy=[::1] on nodes with IPV6 lo only":
(https://github.com/bitcoin/bitcoin/pull/30245#issuecomment-2168391558)
> Now, can we have the `AI_ADDRCONFIG` behavior but get it to consider loopback addresses as valid? For example, after running `getaddrinfo()` with `AI_ADDRCONFIG` run it again without `AI_ADDRCONFIG` and append any loopback addresses from the second run to the results?

I like this idea, I'll have a go at implementing it.

💬 mzumsande commented on issue "RFC: Assumeutxo and large forks and reorgs":
(https://github.com/bitcoin/bitcoin/issues/30288#issuecomment-2168444052)
> This is not what currently happens, but simplest approach might be for the original chainstate to be unaffected by the snapshot chainstate, and to continue to download and attach the same blocks it otherwise would have if no snapshot were loaded. It would just do it more slowly due to a reduced cache size and lower priority for block requests compared to the snapshot chainstate.

I think that the concept of the Active Chainstate / Active Tip is important for this this discussion. Currently,
...

💬 edilmedeiros commented on pull request "upnp: fix build with miniupnpc 2.2.8":
(https://github.com/bitcoin/bitcoin/pull/30283#issuecomment-2168446665)
ACK bf1a6eec805b81819654dff4554bda8c95069aca.

I inspected the [upstream change](https://github.com/miniupnp/miniupnp/commit/c0a50ce33e3b99ce8a96fd43049bb5b53ffac62f#diff-5a0d7cff00628c2c64a617edb347c0f283e3a75e7df910e7e8438fc6db23f610R122) and it looks this will be sufficient to fix the issue.

I complied successfully against my updated macports package, but I have no use case for it to check functionality.

@fanquake I see that you have been updating the `bitcoin` port in macports. Updat
...

💬 edilmedeiros commented on pull request "upnp: fix build with miniupnpc 2.2.8":
(https://github.com/bitcoin/bitcoin/pull/30283#issuecomment-2168454719)
Not ACKing a6df34dfa65560e4d4137c5d8d95f111af5df028, though.

I have inspected the upstream changes and it doesn't seem to do anything shady, but I'm not familiar with the full functionality of that package. Since this can potentially open a backdoor, I prefer to let more experienced people check it.

💬 achow101 commented on pull request "log: use error level for critical log messages":
(https://github.com/bitcoin/bitcoin/pull/30255#issuecomment-2168546288)
ACK fae3a1f0065064d80ab4c0375a9eaeb666c5dd55

🚀 achow101 merged a pull request: "log: use error level for critical log messages"
(https://github.com/bitcoin/bitcoin/pull/30255)

✅ achow101 closed an issue: "bump: ignore WALLET_INCREMENTAL_RELAY_FEE when user specifies fee rate"
(https://github.com/bitcoin/bitcoin/issues/26973)

🚀 achow101 merged a pull request: "bumpfee: ignore WALLET_INCREMENTAL_RELAY_FEE when user specifies fee_rate"
(https://github.com/bitcoin/bitcoin/pull/27969)

💬 ryanofsky commented on issue "RFC: Assumeutxo and large forks and reorgs":
(https://github.com/bitcoin/bitcoin/issues/30288#issuecomment-2168713360)
> I think that the concept of the Active Chainstate / Active Tip is important for this this discussion

Agree it's worth mentioning. I think decisions about how chainstates are synced are mostly separate from decisions about how they are used and prioritized. But for completeness, I was assuming that if the original chainstate ever had more work than the snapshot chainstate, the snapshot chainstate would be unused and could be deleted, and the original chainstate would become the "active" chai
...

⚠️ kosuodhmwa opened an issue: "Wallet ""mywallet" gone after i shut down bitcoind in console and then restart it"
(https://github.com/bitcoin/bitcoin/issues/30290)
It will not be listed anymore, but when i try to create a new wallet with equivalent name, i will get an error message...


💬 sipa commented on issue "Wallet ""mywallet" gone after i shut down bitcoind in console with ctrl-c and then restart it":
(https://github.com/bitcoin/bitcoin/issues/30290#issuecomment-2168764805)
Presumably the wallet is not configured as autoload. You can load it manually with the `loadwallet [walletfilename]` RPC. `listwallets` only lists loaded wallets.

💬 kosuodhmwa commented on issue "Wallet ""mywallet" gone after i shut down bitcoind in console with ctrl-c and then restart it":
(https://github.com/bitcoin/bitcoin/issues/30290#issuecomment-2168774904)
thank you very much, now i've added it to the ~/.bitcoin/bitcoin.conf file:

**_wallet=mywallet_**

✅ kosuodhmwa closed an issue: "Wallet ""mywallet" gone after i shut down bitcoind in console with ctrl-c and then restart it"
(https://github.com/bitcoin/bitcoin/issues/30290)

💬 kosuodhmwa commented on issue "Wallet ""mywallet" gone after i shut down bitcoind in console with ctrl-c and then restart it":
(https://github.com/bitcoin/bitcoin/issues/30290#issuecomment-2168775092)
Closed

💬 BenWestgate commented on issue "Pruning keeps getting reenabled":
(https://github.com/bitcoin-core/gui/issues/709#issuecomment-2168847956)
Letting Bitcoin-Qt search for bitcoin.conf in `$XDG_CONFIG_HOME/Bitcoin` and reading it from your internal drive if present would resolve this issue. As is, bitcoin.conf is not read until after that choosedatadir window is dismissed.
https://github.com/bitcoin/bitcoin/issues/16733

📝 tdb3 opened a pull request: "test: write functional test results to csv"
(https://github.com/bitcoin/bitcoin/pull/30291)
Adds argument `--resultsfile` to test_runner.py.
Enables functional test results to be written to a (csv) file for processing by other applications (or for historical archiving).
Test name, status, and duration are written to the file provided with the argument.


#### Notes
- Total runtime of functional tests has seemed to have increased on my development machines over the past few months (more tests added, individual test runtime increase, etc.). Was interested in recording test runtim
...

💬 dominicusadinfinitum commented on issue "Testsuite for Bitcoin Core 27.0.0 - FAIL: qt/test/test_bitcoin-qt":
(https://github.com/bitcoin/bitcoin/issues/30020#issuecomment-2169135730)
@hebasto @maflcko @willcl-ark

Thank you for your support!
I could run the test successfully.
So, I forgot my admin password for the Raspberry Pi 5 (whoopsie).
Started from scratch again, used the v27.0 Version again, committed the extra files ds and ... until there was nothing more to commit. Did not use BDB and GUI, just the necessary packages with sqlite.

I assume I did not fully commit the extra files and now its's working.

Thanks again for supporting me on my Bitcoin journey - C
...

💬 maflcko commented on pull request "test: write functional test results to csv":
(https://github.com/bitcoin/bitcoin/pull/30291#issuecomment-2169191755)
lgtm ACK ee3b5c7fb4e81f833bb8a7db6c14b4734a2d3133

💬 dergoegge commented on pull request "Tr partial descriptors":
(https://github.com/bitcoin/bitcoin/pull/30243#issuecomment-2169240015)
Found a crash in the `mocked_descriptor_parse` fuzz target, to reproduce:

```
$ echo "dHIoJUJELHJhd2xlYWYoQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCLEE3LCUyNywlQjcsJTIzLCVCZCwlRkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQk
...