💬 achow101 commented on pull request "Lint: Support running individual lint checks":
(https://github.com/bitcoin/bitcoin/pull/30219#issuecomment-2163920227)
ACK 0fcbfdb7ad172e518a10dd6e5be4cb6bb1158784

🚀 achow101 merged a pull request: "Lint: Support running individual lint checks"
(https://github.com/bitcoin/bitcoin/pull/30219)

💬 achow101 commented on pull request "Migrate legacy wallets that are not loaded":
(https://github.com/bitcoin-core/gui/pull/824#issuecomment-2163926995)
> > To deal with this, I've opted to just add a button to the migration dialog box that has the user enter their passphrase first, along with instructional text to use that button if their wallet was encrypted.
>
> If we're preemptively making UX changes just to avoid changing UX in the future, it seems like we shouldn't take shortcuts like this... :/

We already do this in the RPC too, for exactly the same reason.

💬 achow101 commented on issue "docs: Wrong/outdated docs for `tr(KEY)` in doc/descriptors.md":
(https://github.com/bitcoin/bitcoin/issues/30279#issuecomment-2163930686)
I thought the phrase "internal key" is unambiguous to mean that the key will need tweaking, as that is how BIP 341 defines that phrase.

It might make sense to remove descriptors.md since it's ostensibly superseded by the BIPs too.

💬 AngusP commented on pull request "test: Add Compact Block Encoding test `ReceiveWithExtraTransactions` covering non-empty `extra_txn`":
(https://github.com/bitcoin/bitcoin/pull/30237#issuecomment-2163943260)
Pushed 09b90c6 which makes the tests deterministic by using predictable 'random' numbers.

Using this to reproduce the issue @dergoegge pointed out:

```patch
diff --git a/src/blockencodings.cpp b/src/blockencodings.cpp
index 695e8d806a..64d635a97a 100644
--- a/src/blockencodings.cpp
+++ b/src/blockencodings.cpp
@@ -44,7 +44,8 @@ void CBlockHeaderAndShortTxIDs::FillShortTxIDSelector() const {

uint64_t CBlockHeaderAndShortTxIDs::GetShortID(const Wtxid& wtxid) const {
static_ass
...

💬 AngusP commented on pull request "test: switch from curl to urllib for HTTP requests":
(https://github.com/bitcoin/bitcoin/pull/29970#discussion_r1637144977)
You can `response.read(amt=<number of bytes>)` so it could be chunked to avoid loading the whole thing in to memory. That *could* also be used to add back some coarse progress indicator

💬 AngusP commented on pull request "test: switch from curl to urllib for HTTP requests":
(https://github.com/bitcoin/bitcoin/pull/29970#discussion_r1637147093)
With curl that makes sense, though here the `urlopen` will raise a `HTTPError` on a 404 for both a `GET` and `HEAD` request, so the earlier HEAD does seem superfluous?

⚠️ 6037701556160635 opened an issue: "yoones65857@gmail.com"
(https://github.com/bitcoin/bitcoin/issues/30280)
### Is there an existing issue for this?

- [X] I have searched the existing issues

### Current behaviour

yoones65857@gmail.com

### Expected behaviour

سید یونس سرابی

### Steps to reproduce

6219861961488110

### Relevant log output

سید یونس سرابی

### How did you obtain Bitcoin Core

Compiled from source

### What version of Bitcoin Core are you using?

EQApj7FThO0mCP703BxOkb272FvDGQJIV9IlQZieKVW-_bKf

### Operating system and version

6219861961488110

### Machine specifications

Yoones
...

💬 6037701556160635 commented on issue "yoones65857@gmail.com":
(https://github.com/bitcoin/bitcoin/issues/30280#issuecomment-2163972406)
سید یونس سرابی

💬 6037701556160635 commented on issue "yoones65857@gmail.com":
(https://github.com/bitcoin/bitcoin/issues/30280#issuecomment-2163972703)
Yoones

✅ willcl-ark closed an issue: "yoones65857@gmail.com"
(https://github.com/bitcoin/bitcoin/issues/30280)

💬 6037701556160635 commented on issue "yoones65857@gmail.com":
(https://github.com/bitcoin/bitcoin/issues/30280#issuecomment-2163973745)
yoones65857@gmail.com

💬 Hokulans commented on issue "Add bitcoind and bitcoin-cli to macOS release":
(https://github.com/bitcoin/bitcoin/issues/30262#issuecomment-2163995130)
Going to the police
Sent from my iPhone

On Jun 11, 2024, at 10:37 PM, Eoin McQuinn ***@***.***> wrote:



But bitcoin core won't function without a copy of the blockchain, which is 550GiB in size

—
Reply to this email directly, view it on GitHub<https://github.com/bitcoin/bitcoin/issues/30262#issuecomment-2162431253>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BJALMKMP5UFWC5C47PW4OX3ZHACEXAVCNFSM6AAAAABJCRFPR6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRSGQZTCM
...

👍 tdb3 approved a pull request: "netbase: extend CreateSock() to support creating arbitrary sockets"
(https://github.com/bitcoin/bitcoin/pull/30202#pullrequestreview-2114480092)
re-ACK 5f549c35d9a75c7019fe8a96963b988df5498eed

💬 tdb3 commented on pull request "test: cover more errors for `signrawtransactionwithkey` RPC":
(https://github.com/bitcoin/bitcoin/pull/30278#discussion_r1637369302)
nit: An invalid private key and an invalid transaction could be tested separately rather than in the same function. Was there a rationale for combining them?

👍 tdb3 approved a pull request: "test: cover more errors for `signrawtransactionwithkey` RPC"
(https://github.com/bitcoin/bitcoin/pull/30278#pullrequestreview-2114521185)
ACK e2779ce98b39e14cada08a654928e798436f5a46

Ran `rpc_signrawtransactionwithkey` locally (passed). Intentionally caused test failure by 1) using privkey `cUeKHd5orzT3mz8P9pxyREHfsWtVfgsfDjiZZBcjUBAaGk1BTj7N' and independently by 2) removing the trailing `00` from the tx. Test failed as expected each time.

💬 RichardGantz commented on issue "importaddress failed, Only legacy wallets are supported by this command.":
(https://github.com/bitcoin/bitcoin/issues/29772#issuecomment-2164672729)
Dear sipa,

thank you so much for your quick and crystal clear answer.
The EPS started up successfully after I created the legacy wallet.

Please allow me to add for newbees like me that
1. I had to stop bitcoin-core and start it once with the additional parameter `-deprecatedrpc=create_bdb`.
2. After that started up I was able to create the legacy wallet with the following command in the console window:
```createwallet "LegacyWallet" false false "" false false```.

Shutdown of bitc
...

💬 maflcko commented on pull request "test: cover more errors for `signrawtransactionwithkey` RPC":
(https://github.com/bitcoin/bitcoin/pull/30278#issuecomment-2164734573)
ACK e2779ce98b39e14cada08a654928e798436f5a46

💬 maflcko commented on pull request "test: switch from curl to urllib for HTTP requests":
(https://github.com/bitcoin/bitcoin/pull/29970#discussion_r1637705656)
Right, but at some point I wonder if it is worth it to try to re-implement `curl` in Python. I am not sure, but is curl not bundled in `git`, which is already a dependency of this project? Of all open source software projects `curl` is currently unlikely to go unmaintained, so the motivation still seems weak.

💬 maflcko commented on pull request "Several randomness improvements":
(https://github.com/bitcoin/bitcoin/pull/29625#issuecomment-2164863762)
I am still looking into the clang error. I couldn't find an issue with your code, but minimizing/reducing the clang bug will take some time, because it appears non-deterministic.

In the meantime, if you want, you can try a wild shot to work around. For example, temporarily pin to clang-16:

```diff
diff --git a/ci/test/00_setup_env_native_asan.sh b/ci/test/00_setup_env_native_asan.sh
index 668e9ecc8a..d5180189d7 100755
--- a/ci/test/00_setup_env_native_asan.sh
+++ b/ci/test/00_setup_env
...