💬 mzumsande commented on pull request "p2p: For assumeutxo, download snapshot chain before background chain":
(https://github.com/bitcoin/bitcoin/pull/29519#issuecomment-2163327804)
> I think it would be nice to clean the code up more and clarify what is trying to do, instead of merging this change as it is.

I will look into improving this (see thread above) in the next days, so hold off merging please.

💬 maflcko commented on pull request "ci: move ASan job to GitHub Actions from Cirrus CI":
(https://github.com/bitcoin/bitcoin/pull/30193#issuecomment-2163333060)
review ACK 9eea51d9058ad638861aa4b94c1c6e71caeb8765

lgtm

👋 m3dwards's pull request is ready for review: "ci: move ASan job to GitHub Actions from Cirrus CI"
(https://github.com/bitcoin/bitcoin/pull/30193)

👍 marcofleon approved a pull request: "Lint: Support running individual lint checks"
(https://github.com/bitcoin/bitcoin/pull/30219#pullrequestreview-2113458095)
Tested ACK 0fcbfdb7ad172e518a10dd6e5be4cb6bb1158784. Ran `cargo run` with various of the individual tests and with bad input. Also ran it with no arguments. Everything works as expected and help message looks good.

📝 fanquake opened a pull request: "doc: archive release notes for v27.1"
(https://github.com/bitcoin/bitcoin/pull/30276)

💬 fanquake commented on pull request "Update minisketch subtree to eb37a9b8e79f9e49d73b96a49bf97a96d9eb676c":
(https://github.com/bitcoin/bitcoin/pull/30270#issuecomment-2163459777)
Guix Build (aarch64):
```bash
043f66f1a8d58b8dcba45fe88bc1fd0e8cd2222d05a678e3f14bcd52c905533e guix-build-89464ad59cf1/output/aarch64-linux-gnu/SHA256SUMS.part
11f73219fdfe67f878aaf9552d30076267e6925cfac82cf1dfd276b4bc416a38 guix-build-89464ad59cf1/output/aarch64-linux-gnu/bitcoin-89464ad59cf1-aarch64-linux-gnu-debug.tar.gz
ac903add0b8fe9fa3eb578e2270a64c6f7ed1ec054069647a40c564d5b6d0c3c guix-build-89464ad59cf1/output/aarch64-linux-gnu/bitcoin-89464ad59cf1-aarch64-linux-gnu.tar.gz
c9ae08
...

💬 kristapsk commented on pull request "Lint: Support running individual lint checks":
(https://github.com/bitcoin/bitcoin/pull/30219#issuecomment-2163462318)
Concept ACK

💬 kristapsk commented on pull request "ci: move ASan job to GitHub Actions from Cirrus CI":
(https://github.com/bitcoin/bitcoin/pull/30193#issuecomment-2163464919)
Concept ACK

💬 pinheadmz commented on issue "Add bitcoind and bitcoin-cli to macOS release":
(https://github.com/bitcoin/bitcoin/issues/30262#issuecomment-2163493017)
@achow101 binaries like bitcoind can be signed, even detached signs: https://github.com/bitcoin/bitcoin/issues/29749#issuecomment-2096273770

🚀 fanquake merged a pull request: "fuzz: add I2P harness"
(https://github.com/bitcoin/bitcoin/pull/30230)

✅ fanquake closed an issue: "fuzz: Re-introduce i2p target"
(https://github.com/bitcoin/bitcoin/issues/28803)

👍 dergoegge approved a pull request: "fuzz: Use std::span in FuzzBufferType"
(https://github.com/bitcoin/bitcoin/pull/30229#pullrequestreview-2113616582)
utACK faa41e29d5b90e62179d651f4010272dae685621

💬 murchandamus commented on pull request "Testnet4 including PoW difficulty adjustment fix":
(https://github.com/bitcoin/bitcoin/pull/29775#issuecomment-2163533907)
> Why do you think this issue has never happened on Testnet3? Someone can run up the difficulty there today like you describe and leave on the last block of a difficulty adjustment period, the chain would stall the same as with the code here.

Do blocks mined with the exception count towards the total work according to difficulty-1 or the actual difficulty? If it’s the latter, in testnet3 you could just invalidate the last block in the previous difficulty period with a difficulty-1 block. If i
...

🚀 fanquake merged a pull request: "fuzz: Use std::span in FuzzBufferType"
(https://github.com/bitcoin/bitcoin/pull/30229)

📝 sr-gi opened a pull request: "[DO NOT MERGE] Erlay: bandwidth-efficient transaction relay protocol (Full implementation)"
(https://github.com/bitcoin/bitcoin/pull/30277)
Erlay Project Tracking: https://github.com/bitcoin/bitcoin/issues/30249

---

This is a full implementation of Erlay. Its purpose is to check the integrity and correctness of the implementation against changes/additions that may originate from the review process and/or rebases on top of newer functionality.

This is not to be merged. Functionality will be spread across multiple smaller PRs to ease the review process.

📝 sr-gi converted_to_draft a pull request: "[DO NOT MERGE] Erlay: bandwidth-efficient transaction relay protocol (Full implementation)"
(https://github.com/bitcoin/bitcoin/pull/30277)
Erlay Project Tracking: https://github.com/bitcoin/bitcoin/issues/30249

---

This is a full implementation of Erlay. Its purpose is to check the integrity and correctness of the implementation against changes/additions that may originate from the review process and/or rebases on top of newer functionality.

This is not to be merged. Functionality will be spread across multiple smaller PRs to ease the review process.

💬 m3dwards commented on issue "RPC wont bind without an IP address on a non-localhost interface":
(https://github.com/bitcoin/bitcoin/issues/13155#issuecomment-2163548438)
I believe this is the same issue as in https://github.com/bitcoin/bitcoin/pull/30245 but in libevent.

If you pass `::1` to `getaddrinfo` when configured with `AI_ADDRCONFIG` it will check that there is a non loopback IPV6 interface configured. This was to prevent IPV6 DNS lookups on IPV4 only machines which could be slow.

Please see https://github.com/bitcoin/bitcoin/pull/30245 for a more full write up and some references.

As I understand it, there are efforts to replace libevent so rat
...

💬 theuni commented on issue "Won't compile with miniupnpc 2.2.8":
(https://github.com/bitcoin/bitcoin/issues/30266#issuecomment-2163549076)
Looks like we need to update for https://github.com/miniupnp/miniupnp/commit/c0a50ce33e3b99ce8a96fd43049bb5b53ffac62f I'll have a look at this tomorrow.

💬 m3dwards commented on pull request "ci: parse TEST_RUNNER_EXTRA into an array":
(https://github.com/bitcoin/bitcoin/pull/30244#issuecomment-2163577539)
Updated `test_runner.py` so that:

`--exclude "rpc_bind.py --IPV6` will only exclude that variant.
`--exclude rpc_bind.py` will exclude all variants

Green test run with `TEST_RUNNER_EXTRA: --exclude "rpc_bind.py --ipv6, feature_proxy.py"`: https://github.com/m3dwards/bitcoin/actions/runs/9485948819/job/26139127116. Note that `rpc_bind.py --ipv4` and `rpc_bind.py --nonloopback` were both run but `rpc_bind.py --ipv6` and `feature_proxy.py` did not run.

Spaces between test names now also
...

👋 m3dwards's pull request is ready for review: "ci: parse TEST_RUNNER_EXTRA into an array"
(https://github.com/bitcoin/bitcoin/pull/30244)