💬 instagibbs commented on pull request "Cluster size 2 package rbf":
(https://github.com/bitcoin/bitcoin/pull/28984#discussion_r1636499798)
Added delving link but for Future Work I'm wondering longer term where cluster mempool design stuff should live.

💬 instagibbs commented on pull request "Cluster size 2 package rbf":
(https://github.com/bitcoin/bitcoin/pull/28984#discussion_r1636499902)
squashed and lightly re-ordered

💬 marcofleon commented on pull request "i2p: fix and improve logs":
(https://github.com/bitcoin/bitcoin/pull/29833#discussion_r1636502596)
Should this not be `*m_interrupt`?

👍 theuni approved a pull request: "Update minisketch subtree to eb37a9b8e79f9e49d73b96a49bf97a96d9eb676c"
(https://github.com/bitcoin/bitcoin/pull/30270#pullrequestreview-2113093414)
utACK 89464ad59cf11f68315ea3104236989e5b429d15

💬 instagibbs commented on pull request "Cluster size 2 package rbf":
(https://github.com/bitcoin/bitcoin/pull/28984#issuecomment-2163071996)
Added a release note

📝 maflcko opened a pull request: "doc: Mention EOL policy in release notes template"
(https://github.com/bitcoin/bitcoin/pull/30271)
Currently the release notes template does not link to the EOL policy. Not sure if anyone still isn't aware of it, but I guess it can't hurt to link to it from the release notes.

💬 ryanofsky commented on pull request "p2p: For assumeutxo, download snapshot chain before background chain":
(https://github.com/bitcoin/bitcoin/pull/29519#discussion_r1636522532)
re: https://github.com/bitcoin/bitcoin/pull/29519#discussion_r1635456871

Good points. My suggested change was premised on the false assumption that the node would be able to seamlessly reorg to the most-work chain. But that's not true because of missing undo data.

Your philosophical point is interesting. I believe that:

- Loading snapshots should not affect how nodes come to consensus, it should only affect what order they download blocks, and help them compute the latest UTXO sets soon
...

📝 glozow opened a pull request: "doc: use TRUC instead of v3 and add release note"
(https://github.com/bitcoin/bitcoin/pull/30272)
Draft because this will conflict with #28984. Will mark green after that is merged.

Adds a release note for TRUC policy which will be live in v28.0.

Also, for clarity, replaces mentions of "v3" with "TRUC" in most places. I changed error strings from "v3-violation" to "TRUC-violation" but left v3 in the debug strings because I think it might be clearer for somebody who is debugging. Similarly, I left some variables unchanged because I think they're more descriptive this way, e.g. `tx_v3_fr
...

📝 vasild opened a pull request: "fuzz: FuzzedSock::Recv() don't lose bytes from MSG_PEEK read"
(https://github.com/bitcoin/bitcoin/pull/30273)
Problem:

If `FuzzedSock::Recv(N, MSG_PEEK)` is called then `N` bytes would be
retrieved from the fuzz provider, saved in `m_peek_data` and returned
to the caller (ok).

If after this `FuzzedSock::Recv(M, 0)` is called where `M < N`
then the first `M` b
...

💬 vasild commented on pull request "fuzz: Make FuzzedSock fuzz friendlier":
(https://github.com/bitcoin/bitcoin/pull/30211#discussion_r1636524185)
> ... will lose the trailing `N - M` bytes from the peek.

Fixed in https://github.com/bitcoin/bitcoin/pull/30273

💬 glozow commented on pull request "policy: bump TX_MAX_STANDARD_VERSION to 3":
(https://github.com/bitcoin/bitcoin/pull/29496#discussion_r1636524772)
done in #30272

💬 maflcko commented on pull request "doc: Mention EOL policy in release notes template":
(https://github.com/bitcoin/bitcoin/pull/30271#issuecomment-2163091600)
Feel free to close if this feels too redundant, or if someone from the security team wanted to create a similar pull. (I am not on the security team)

💬 glozow commented on pull request "policy: bump TX_MAX_STANDARD_VERSION to 3":
(https://github.com/bitcoin/bitcoin/pull/29496#discussion_r1636524914)
done in #30272

💬 vasild commented on pull request "fuzz: Make FuzzedSock fuzz friendlier":
(https://github.com/bitcoin/bitcoin/pull/30211#discussion_r1636524913)
Removed the optional in https://github.com/bitcoin/bitcoin/pull/30273.

👍 vasild approved a pull request: "fuzz: add I2P harness"
(https://github.com/bitcoin/bitcoin/pull/30230#pullrequestreview-2113132000)
ACK 193c748e44f8647a056121fc9cbb9c2efbcbfc49

💬 vasild commented on pull request "fuzz: add I2P harness":
(https://github.com/bitcoin/bitcoin/pull/30230#discussion_r1636531569)
> I think it's an acceptable tradeoff ...

Ok.

> ... advancing time would be a more accurate simulation. Maybe we leave this as a potential follow up ...

Right, further changes in `FuzzedSock` itself are kind of out of scope for this PR which resurrects the previously deleted test.

Thanks!

💬 sipa commented on pull request "Update minisketch subtree to eb37a9b8e79f9e49d73b96a49bf97a96d9eb676c":
(https://github.com/bitcoin/bitcoin/pull/30270#issuecomment-2163112473)
utACK 89464ad59cf11f68315ea3104236989e5b429d15

✅ maflcko closed a pull request: "doc: Mention EOL policy in release notes template"
(https://github.com/bitcoin/bitcoin/pull/30271)

💬 maflcko commented on pull request "doc: Mention EOL policy in release notes template":
(https://github.com/bitcoin/bitcoin/pull/30271#issuecomment-2163134086)
Closing for now as up-for-grabs.

⚠️ okabri opened an issue: "Btc"
(https://github.com/bitcoin/bitcoin/issues/30274)