🤔 glozow reviewed a pull request: "Cluster size 2 package rbf"
(https://github.com/bitcoin/bitcoin/pull/28984#pullrequestreview-2110845000)
ACK dd364f9a813221956ec0b19f45db231b148491c2. non-blocking nits that can go in a followup. Also needs a release note.

💬 glozow commented on pull request "Cluster size 2 package rbf":
(https://github.com/bitcoin/bitcoin/pull/28984#discussion_r1635164607)
Very different uses of "conflicts" here

```suggestion
// package to spend. If there are no conflicts within the package, no transaction can spend a coin
// needed by another transaction in the package. We also need to make sure that no package
// tx replaces (or replaces the ancestor of) the parent of another package tx. As long as we
// check these two things, we don't need to track the coins spent.
// If a package tx conflicts with a mempool tx,
...

💬 glozow commented on pull request "Cluster size 2 package rbf":
(https://github.com/bitcoin/bitcoin/pull/28984#discussion_r1635166974)
dd364f9a813221956ec0b19f45db231b148491c2:
I suppose we should more thoroughly define what "cluster" means somewhere

💬 glozow commented on pull request "Cluster size 2 package rbf":
(https://github.com/bitcoin/bitcoin/pull/28984#discussion_r1635171418)
I got f25c15383ff051effd0add25352fe0f0e2224d0c and 5bb449cf91907f613dc4d7e1114be3befaf7b2ff mixed up - they could be squashed.

💬 glozow commented on pull request "Cluster size 2 package rbf":
(https://github.com/bitcoin/bitcoin/pull/28984#discussion_r1635115027)
nit: 5bb449cf91907f613dc4d7e1114be3befaf7b2ff commit message should be test util instead of fuzz, since this is used in unit tests too

💬 glozow commented on pull request "Cluster size 2 package rbf":
(https://github.com/bitcoin/bitcoin/pull/28984#discussion_r1635168196)
Also somewhat unclear... perhaps needs a link to the delving post or something

🤔 glozow reviewed a pull request: "util: add missing VecDeque include"
(https://github.com/bitcoin/bitcoin/pull/30268#pullrequestreview-2112647862)
ACK f51da34ec1a806d321a468691fa66082eef10ad9

💬 emc99 commented on issue "Add bitcoind and bitcoin-cli to macOS release":
(https://github.com/bitcoin/bitcoin/issues/30262#issuecomment-2162743274)
@Sjors is this what you are doing, running a pruned node?

💬 pinheadmz commented on issue "Add bitcoind and bitcoin-cli to macOS release":
(https://github.com/bitcoin/bitcoin/issues/30262#issuecomment-2162750500)
Related #29749 signing the cli tools will likely require updates to the macOS signing tools we use for releases

💬 sipa commented on issue "Add bitcoind and bitcoin-cli to macOS release":
(https://github.com/bitcoin/bitcoin/issues/30262#issuecomment-2162754801)
@emc99 This issue is about the discussion of packaging of the `bitcoin-cli` client with the macOS release. If you have questions about usage of Bitcoin Core, there are other venues like https://bitcoin.stackexchange.com.

🤔 sipa reviewed a pull request: "util: add missing VecDeque include"
(https://github.com/bitcoin/bitcoin/pull/30268#pullrequestreview-2112742043)
utACK f51da34ec1a806d321a468691fa66082eef10ad9

💬 sipa commented on pull request "Several randomness improvements":
(https://github.com/bitcoin/bitcoin/pull/29625#issuecomment-2162765346)
Now actually rebased, after merge of #30160.

💬 fanquake commented on pull request "guix: build with glibc 2.31":
(https://github.com/bitcoin/bitcoin/pull/29987#issuecomment-2162818859)
Guix Build (aarch64):
```bash
aa0ac90d4abc930dee2327985fafdbee9c40c8eeea5738383e798f076db36766 guix-build-b5fc6d46a385/output/aarch64-linux-gnu/SHA256SUMS.part
c25dec340e71ba13b238cc743cb86cb6ee564b05f47a1d3df2240f90b8cdf1cd guix-build-b5fc6d46a385/output/aarch64-linux-gnu/bitcoin-b5fc6d46a385-aarch64-linux-gnu-debug.tar.gz
b7e9627b89d06e2646fcc5430f2eb08ab920039cfa9d4ce14917830bc48ba129 guix-build-b5fc6d46a385/output/aarch64-linux-gnu/bitcoin-b5fc6d46a385-aarch64-linux-gnu.tar.gz
3afe6f
...

🚀 glozow merged a pull request: "util: add missing VecDeque include"
(https://github.com/bitcoin/bitcoin/pull/30268)

🚀 glozow merged a pull request: "[26.x] backports and final changes for 26.2rc1"
(https://github.com/bitcoin/bitcoin/pull/30260)

💬 fanquake commented on pull request "fuzz: Use std::span in FuzzBufferType":
(https://github.com/bitcoin/bitcoin/pull/30229#issuecomment-2162892651)
I think this is ok to do, but you'll need adjust the bitset code instroduced in #30160:
```bash
test/fuzz/bitset.cpp:284:23: error: no matching function for call to 'ReadByte'
unsigned typdat = ReadByte(buffer) % 8;
^~~~~~~~
test/fuzz/bitset.cpp:16:9: note: candidate function not viable: no known conversion from 'FuzzBufferType' (aka 'span<const unsigned char>') to 'Span<const uint8_t> &' (aka 'Span<const unsigned char> &') for 1st argument
uint8_t ReadByte(Span<c
...

💬 RichardGantz commented on issue "importaddress failed, Only legacy wallets are supported by this command.":
(https://github.com/bitcoin/bitcoin/issues/29772#issuecomment-2162910393)
I have a bitcoincore v27.0.0 running on a "Raspberry Pi OS with desktop, Release date: March 15th 2024.System: 64-bit,Kernel version: 6.6, Debian version: 12 (bookworm)" over the tor network, which is fully synchronized.

I installed a "Electrum Personal Server v0.2.4, but it does not start because of this same JsonRpcError ("code = -4; message = "Only legacy wallets are supported by this command").
Up to this point I tried several zpubs and addresses, but they were all native segwit P2WPKH.
...

💬 marcofleon commented on pull request "fuzz: add I2P harness":
(https://github.com/bitcoin/bitcoin/pull/30230#discussion_r1636394068)
I think it's an acceptable tradeoff, as using mock time makes the test more determinstic. I don't think timeouts are too critical a part of the I2P code, and this harness as is reaches almost all of the code paths in `i2p`.

But I see what you're saying in that advancing time would be a more accurate simulation. Maybe we leave this as a potential follow up on `FuzzedSock`?

💬 sipa commented on issue "importaddress failed, Only legacy wallets are supported by this command.":
(https://github.com/bitcoin/bitcoin/issues/29772#issuecomment-2162927360)
The terminology is confusing, but "legacy wallets" and "legacy addresses" have nothing to do with one another:
* legacy wallets are wallet.dat files using the BDB format, and are opposed to sqlite-based wallet files ("descriptor wallets"). Legacy wallet support is being deprecated.
* legacy addresses are P2PKH and P2SH addresses, and are opposed to more modern address types like P2WPKH and P2TR.

What you've done is created a legacy address in a descriptor wallet (which is supported). The is
...

💬 emc99 commented on issue "Add bitcoind and bitcoin-cli to macOS release":
(https://github.com/bitcoin/bitcoin/issues/30262#issuecomment-2162937611)
@sipa I don't see how my questions are off-topic. Why can't we have a free and open discussion of the issues on here? Isn't that what github is for?