💬 fanquake commented on pull request "build: Bump clang minimum supported version to 16":
(https://github.com/bitcoin/bitcoin/pull/30263#issuecomment-2162593232)
Should this be dropped:
https://github.com/bitcoin/bitcoin/blob/5ee6b76c69d51158c13f6ad9ea1b264372e58d4d/src/test/fuzz/fuzz.cpp#L75

💬 josibake commented on pull request "refactor, wallet: get serialized size of `CRecipient`s directly":
(https://github.com/bitcoin/bitcoin/pull/30050#issuecomment-2162616719)
Rebased to fix merge conflict and update commit message to better explain the motivation for using the visitor patter, per @S3RK 's feedback

💬 willcl-ark commented on issue "Add bitcoind and bitcoin-cli to macOS release":
(https://github.com/bitcoin/bitcoin/issues/30262#issuecomment-2162640621)
@emc99 you can run your node with `--prune=1024` which will prune old blocks and undo data from disk, where possible. This will mean that Bitcoin Core will take only 1024MB + UTXO set size (~12.5GB today) = ~13.5GB according to my pruned node.

```bash
will@ubuntu in ~/replay : 🐍 took 6s
₿ /home/will/bitcoin-builds/bitcoin-27.1rc1/bin/bitcoin-cli gettxoutsetinfo
{
"height": 847611,
"bestblock": "000000000000000000028f622110a7bcbb76ccf9090aa802927e9468840c30a5",
"txouts": 185213812
...

💬 stickies-v commented on pull request "Encapsulate warnings in generalized node::Warnings and remove globals":
(https://github.com/bitcoin/bitcoin/pull/30058#discussion_r1636218564)
Addressed in latest force push.

💬 stickies-v commented on pull request "Encapsulate warnings in generalized node::Warnings and remove globals":
(https://github.com/bitcoin/bitcoin/pull/30058#issuecomment-2162672165)
Force pushed to:
- address merged conflict from #28830
- address @ryanofsky's [comment](https://github.com/bitcoin/bitcoin/pull/30058#discussion_r1624697758): inlined `DoWarning()` in commit "introduce and use the generalized node::Warnings interface" instead of in later commit "refactor: remove warnings globals" to avoid overhauling it twice.

💬 stickies-v commented on pull request "C++20 std::views::reverse":
(https://github.com/bitcoin/bitcoin/pull/28687#issuecomment-2162681582)
Force pushed to address merge conflict from #28830 and rebase on top of #30263

🤔 glozow reviewed a pull request: "Cluster size 2 package rbf"
(https://github.com/bitcoin/bitcoin/pull/28984#pullrequestreview-2110845000)
ACK dd364f9a813221956ec0b19f45db231b148491c2. non-blocking nits that can go in a followup. Also needs a release note.

💬 glozow commented on pull request "Cluster size 2 package rbf":
(https://github.com/bitcoin/bitcoin/pull/28984#discussion_r1635164607)
Very different uses of "conflicts" here

```suggestion
// package to spend. If there are no conflicts within the package, no transaction can spend a coin
// needed by another transaction in the package. We also need to make sure that no package
// tx replaces (or replaces the ancestor of) the parent of another package tx. As long as we
// check these two things, we don't need to track the coins spent.
// If a package tx conflicts with a mempool tx,
...

💬 glozow commented on pull request "Cluster size 2 package rbf":
(https://github.com/bitcoin/bitcoin/pull/28984#discussion_r1635166974)
dd364f9a813221956ec0b19f45db231b148491c2:
I suppose we should more thoroughly define what "cluster" means somewhere

💬 glozow commented on pull request "Cluster size 2 package rbf":
(https://github.com/bitcoin/bitcoin/pull/28984#discussion_r1635171418)
I got f25c15383ff051effd0add25352fe0f0e2224d0c and 5bb449cf91907f613dc4d7e1114be3befaf7b2ff mixed up - they could be squashed.

💬 glozow commented on pull request "Cluster size 2 package rbf":
(https://github.com/bitcoin/bitcoin/pull/28984#discussion_r1635115027)
nit: 5bb449cf91907f613dc4d7e1114be3befaf7b2ff commit message should be test util instead of fuzz, since this is used in unit tests too

💬 glozow commented on pull request "Cluster size 2 package rbf":
(https://github.com/bitcoin/bitcoin/pull/28984#discussion_r1635168196)
Also somewhat unclear... perhaps needs a link to the delving post or something

🤔 glozow reviewed a pull request: "util: add missing VecDeque include"
(https://github.com/bitcoin/bitcoin/pull/30268#pullrequestreview-2112647862)
ACK f51da34ec1a806d321a468691fa66082eef10ad9

💬 emc99 commented on issue "Add bitcoind and bitcoin-cli to macOS release":
(https://github.com/bitcoin/bitcoin/issues/30262#issuecomment-2162743274)
@Sjors is this what you are doing, running a pruned node?

💬 pinheadmz commented on issue "Add bitcoind and bitcoin-cli to macOS release":
(https://github.com/bitcoin/bitcoin/issues/30262#issuecomment-2162750500)
Related #29749 signing the cli tools will likely require updates to the macOS signing tools we use for releases

💬 sipa commented on issue "Add bitcoind and bitcoin-cli to macOS release":
(https://github.com/bitcoin/bitcoin/issues/30262#issuecomment-2162754801)
@emc99 This issue is about the discussion of packaging of the `bitcoin-cli` client with the macOS release. If you have questions about usage of Bitcoin Core, there are other venues like https://bitcoin.stackexchange.com.

🤔 sipa reviewed a pull request: "util: add missing VecDeque include"
(https://github.com/bitcoin/bitcoin/pull/30268#pullrequestreview-2112742043)
utACK f51da34ec1a806d321a468691fa66082eef10ad9

💬 sipa commented on pull request "Several randomness improvements":
(https://github.com/bitcoin/bitcoin/pull/29625#issuecomment-2162765346)
Now actually rebased, after merge of #30160.

💬 fanquake commented on pull request "guix: build with glibc 2.31":
(https://github.com/bitcoin/bitcoin/pull/29987#issuecomment-2162818859)
Guix Build (aarch64):
```bash
aa0ac90d4abc930dee2327985fafdbee9c40c8eeea5738383e798f076db36766 guix-build-b5fc6d46a385/output/aarch64-linux-gnu/SHA256SUMS.part
c25dec340e71ba13b238cc743cb86cb6ee564b05f47a1d3df2240f90b8cdf1cd guix-build-b5fc6d46a385/output/aarch64-linux-gnu/bitcoin-b5fc6d46a385-aarch64-linux-gnu-debug.tar.gz
b7e9627b89d06e2646fcc5430f2eb08ab920039cfa9d4ce14917830bc48ba129 guix-build-b5fc6d46a385/output/aarch64-linux-gnu/bitcoin-b5fc6d46a385-aarch64-linux-gnu.tar.gz
3afe6f
...

🚀 glozow merged a pull request: "util: add missing VecDeque include"
(https://github.com/bitcoin/bitcoin/pull/30268)