💬 willcl-ark commented on issue "Improve description of the `filename` parameter of `loadwallet` RPC":
(https://github.com/bitcoin/bitcoin/issues/30269#issuecomment-2161360992)
@MukulKolpe absolutely. We don't generally assign issues in this project. Anyone is free to open a PR fixing any issue.

As @murchandamus advised in OP, please take care to:

> ... read [CONTRIBUTING.md](https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md?rgh-link-date=2024-06-11T17%3A09%3A29Z) before opening your pull request.

If you have any questions about the issue at hand here, or generally opening a Pull Request in this repo, feel free to ask away in here :)

💬 achow101 commented on pull request "[refactor] Check CTxMemPool options in ctor":
(https://github.com/bitcoin/bitcoin/pull/28830#issuecomment-2161427580)
ACK 09ef322acc0a88a9e119f74923399598984c68f6

💬 murchandamus commented on issue "Improve description of the `filename` parameter of `loadwallet` RPC":
(https://github.com/bitcoin/bitcoin/issues/30269#issuecomment-2161452991)
Sure! For context, the following Bitcoin Stack Exchange topic was what inspired me to open the issue: https://bitcoin.stackexchange.com/q/123331/5406

🚀 achow101 merged a pull request: "[refactor] Check CTxMemPool options in ctor"
(https://github.com/bitcoin/bitcoin/pull/28830)

💬 Manuela123q commented on pull request "kernel: Run sanity checks on context construction":
(https://github.com/bitcoin/bitcoin/pull/28228#discussion_r1635384865)
Hhfft

💬 achow101 commented on pull request "cli: Detect port errors in rpcconnect and rpcport":
(https://github.com/bitcoin/bitcoin/pull/29521#issuecomment-2161477616)
ACK 24bc46c83b39149f4845a575a82337eb46d91bdb

🚀 achow101 merged a pull request: "cli: Detect port errors in rpcconnect and rpcport"
(https://github.com/bitcoin/bitcoin/pull/29521)

💬 achow101 commented on pull request "validation: improve performance of CheckBlockIndex":
(https://github.com/bitcoin/bitcoin/pull/28339#issuecomment-2161560686)
ACK 5bc2077e8f592442b089affdf0b5795fbc053bb8

💬 mzumsande commented on pull request "p2p: For assumeutxo, download snapshot chain before background chain":
(https://github.com/bitcoin/bitcoin/pull/29519#discussion_r1635456871)
> This means if the snapshot is not on the best chain, the node may be unable to sync to a better chain.

I've thought about this for a while, and I'm not sure if that problem is really being fixed by your suggestion for the following (slightly philosophical) reasons:
- Accepting a snapshot means that we've created a new chainstate with its Active Tip being set to that block.
- That is a commitment, we can't just reorg away from it to another chain that doesn't contain the snapshot block, ev
...

🚀 achow101 merged a pull request: "validation: improve performance of CheckBlockIndex"
(https://github.com/bitcoin/bitcoin/pull/28339)

💬 murchandamus commented on pull request "wallet, rpc: add anti-fee-sniping to `send` and `sendall`":
(https://github.com/bitcoin/bitcoin/pull/28944#issuecomment-2161576108)
> > ```diff
> > --- a/test/functional/wallet_import_rescan.py
> > +++ b/test/functional/wallet_import_rescan.py
> > @@ -293,6 +293,7 @@ class ImportRescanTest(BitcoinTestFramework):
> > add_to_wallet=False,
> > inputs=[unspent_txid_map[variant.initial_txid]],
> > outputs=[{ADDRESS_BCRT1_UNSPENDABLE : variant.initial_amount}],
> > + locktime=0,
> > subtract_fee_from_outputs=[0]
> > )
> >
...

👍 brunoerg approved a pull request: "fuzz: add I2P harness"
(https://github.com/bitcoin/bitcoin/pull/30230#pullrequestreview-2111463661)
ACK 193c748e44f8647a056121fc9cbb9c2efbcbfc49

💬 achow101 commented on pull request "util: add BitSet":
(https://github.com/bitcoin/bitcoin/pull/30160#issuecomment-2161613165)
ACK 47f705b33fc1381d96c99038e2110e6fe2b2f883

🚀 achow101 merged a pull request: "util: add BitSet"
(https://github.com/bitcoin/bitcoin/pull/30160)

💬 Eunovo commented on pull request "Tr partial descriptors":
(https://github.com/bitcoin/bitcoin/pull/30243#issuecomment-2161639208)
@ajtowns Thanks for the review. I added some examples to `wallet_miniscript.py` and updated `descriptors.md`

💬 sipa commented on pull request "Several randomness improvements":
(https://github.com/bitcoin/bitcoin/pull/29625#issuecomment-2161757848)
Rebased.

💬 sipa commented on pull request "feefrac: 128-bit multiply support in MSVC":
(https://github.com/bitcoin/bitcoin/pull/29758#issuecomment-2161872276)
@hebasto Thanks. I was assuming this would be an obvious improvement, but if it isn't, it'll need some more investigation into what this is all compiled to. That's not something I'm interested in doing for a half-supported architecture.

✅ sipa closed a pull request: "feefrac: 128-bit multiply support in MSVC"
(https://github.com/bitcoin/bitcoin/pull/29758)

💬 rocholojavinar commented on issue "Change estimate_mode default to "ECONOMICAL" in these RPC calls":
(https://github.com/bitcoin/bitcoin/issues/30009#issuecomment-2161991913)

💬 alfonsoromanz commented on pull request "test: Assumeutxo: import snapshot in a node with a divergent chain":
(https://github.com/bitcoin/bitcoin/pull/29996#discussion_r1635899433)
I just pushed my recent changes for this PR. This is the approach I decided to move forward with:

1. **Scenario Choice**: Between these two scenarios mentioned by @fjahr: "Particularly 'but has less work' could mean A) less work than the tip of the chain that includes the snapshot or B) less work than the snapshot block itself," I chose B) for this PR: less work than the snapshot block itself. I am happy to add tests for the other scenario in a separate PR.
2. **Added Fix**: I incorporated t
...