🚀 glozow merged a pull request: "test: doc: fix units in tx-size standardness test (s/vbytes/weight units)"
(https://github.com/bitcoin/bitcoin/pull/30254)

💬 stickies-v commented on pull request "log: use error level for critical log messages":
(https://github.com/bitcoin/bitcoin/pull/30255#issuecomment-2160485375)
re-ACK fae3a1f0065064d80ab4c0375a9eaeb666c5dd55, I'm ~0 on the latest force push as `user_error` was already logged at the right level through `GetNotifications().fatalError(user_error);` so I'd be in favour of deduplicating/cleaning up this logging logic but can be done in follow-up.

💬 Sjors commented on pull request "depends: remove `FORCE_USE_SYSTEM_CLANG`":
(https://github.com/bitcoin/bitcoin/pull/30201#issuecomment-2160498553)
tACK 7cbfd7a7ce45ac68d6041f42f468862f5c193d8c

I made a Guix build, as well as a regular cross-compile on Ubuntu 24.04 for Intel macOS, and lightly tested them.

Guix hashes for darwin:

```
048fa3f381098477b8bea25701547f37a6680b33afb9c61ba88cb4a895aae81d guix-build-7cbfd7a7ce45/output/arm64-apple-darwin/SHA256SUMS.part
d540c4c73b98bef810c85b0b10a6e1a004655fb0c8a4709b8f655c6924afef8b guix-build-7cbfd7a7ce45/output/arm64-apple-darwin/bitcoin-7cbfd7a7ce45-arm64-apple-darwin-unsigned.tar.
...

💬 Eunovo commented on pull request "Tr partial descriptors":
(https://github.com/bitcoin/bitcoin/pull/30243#issuecomment-2160555599)
> Seems okay to me. Presumably should update doc/descriptors.md though, and might also be nice to have some functional tests demonstrating it works end-to-end? (Add some examples to `DESCS` in wallet_miniscript.py maybe?

@ajtowns Will do!

👍 stickies-v approved a pull request: "[27.1] Finalize"
(https://github.com/bitcoin/bitcoin/pull/30222#pullrequestreview-2110202794)
ACK d756a384d2bebe85f2ce0d192e4d31bbbbe750a1

I checked that:

- backports are clean and look correct
- manpages are identical to mine
- release notes are correct

💬 Eunovo commented on pull request "Tr partial descriptors":
(https://github.com/bitcoin/bitcoin/pull/30243#discussion_r1634722562)
> Having an `optional` when in one branch you ignore the value and in the other you assume it always has a value doesn't make a lot of sense to me.
>
> Would it make sense to drop `leaf_version` from `TRNodeInfo` and store the leaf version as the first byte of the script? Alternatively, could just drop the optional and default it to 0.

@ajtowns I prefer to drop the optional and default leaf_version to `0`

🚀 glozow merged a pull request: "test: MiniWallet: respect passed feerate for padded txs (using `target_weight`)"
(https://github.com/bitcoin/bitcoin/pull/30162)

💬 glozow commented on pull request "locks: introduce mutex for tx download, flush rejection filters on UpdatedBlockTip":
(https://github.com/bitcoin/bitcoin/pull/30111#issuecomment-2160590090)
Rebased

💬 Prabhat1308 commented on pull request "p2p: Fill reconciliation sets (Erlay) attempt 2":
(https://github.com/bitcoin/bitcoin/pull/30116#discussion_r1634738029)
Since this function is to be called once per peer , we should add a check if there exists a state for this peer .

💬 Prabhat1308 commented on pull request "p2p: Fill reconciliation sets (Erlay) attempt 2":
(https://github.com/bitcoin/bitcoin/pull/30116#discussion_r1634736227)
What is the intention behind moving salt calculation out of PreRegisterPeer ? Now if PreRegisterPeer is not executed due to lock being held we are doing meaningless computation .

👍 willcl-ark approved a pull request: "[27.1] Finalize"
(https://github.com/bitcoin/bitcoin/pull/30222#pullrequestreview-2110287163)
ACK d756a384d2bebe85f2ce0d192e4d31bbbbe750a1

Version updates and manpages LGTM.

Also ran a scripted backport check to verify no unwarranted changes:

<details>
<summary>output</summary>

```diff
₿ bitcoin-diff-backports --base-branch="upstream/27.x"
1c1
< commit ffbc173ca1ed6b93de8bf3f88b8aed0743f4916c
---
> commit f2e05cd2a9bdc42fa45d284a5162f1f670d07ab6
7a8,10
>
> Github-Pull: #30217
> Rebased-From: ffbc173ca1ed6b93de8bf3f88b8aed0743f4916c
10c13
< index 7f0389b30d
...

💬 fanquake commented on pull request "depends: remove `FORCE_USE_SYSTEM_CLANG`":
(https://github.com/bitcoin/bitcoin/pull/30201#issuecomment-2160706291)
Guix Build (aarch64):
```bash
f8487a885a04a4b3c273b2d1ba3ef5e100026f16b03c08e866dbf4cd468d0802 guix-build-7cbfd7a7ce45/output/aarch64-linux-gnu/SHA256SUMS.part
b3da7604bc7302213d2864bddbccc54ede6374711377b89b2d17a989d2e9e64d guix-build-7cbfd7a7ce45/output/aarch64-linux-gnu/bitcoin-7cbfd7a7ce45-aarch64-linux-gnu-debug.tar.gz
d2340b2c084faf01a0db8ea0c077ba9f8c51ef23b680396d88001b33d126788b guix-build-7cbfd7a7ce45/output/aarch64-linux-gnu/bitcoin-7cbfd7a7ce45-aarch64-linux-gnu.tar.gz
a79f46
...

🚀 fanquake merged a pull request: "test: Remove redundant verack check"
(https://github.com/bitcoin/bitcoin/pull/30252)

💬 ismaelsadeeq commented on pull request "Cluster size 2 package rbf":
(https://github.com/bitcoin/bitcoin/pull/28984#discussion_r1634857819)
In d3d653dce34ad1f3235869b8a54f9572e89e5b68 [policy] package rbf

Update places where it is claimed that package RBF is disabled?


```diff
diff --git a/src/validation.cpp b/src/validation.cpp
index 8372fcadca1..d18fc1c0f2c 100644
--- a/src/validation.cpp
+++ b/src/validation.cpp
@@ -602,8 +602,8 @@ public:
/**
* Submission of a subpackage.
* If subpackage size == 1, calls AcceptSingleTransaction() with adjusted ATMPArgs to avoid
- * package policy restrictio
...

💬 ismaelsadeeq commented on pull request "Cluster size 2 package rbf":
(https://github.com/bitcoin/bitcoin/pull/28984#discussion_r1634859550)
> It hits in the fuzzing package_eval fuzzing target.

I was able to reproduce this locally.

🚀 fanquake merged a pull request: "[27.1] Finalize"
(https://github.com/bitcoin/bitcoin/pull/30222)

💬 ismaelsadeeq commented on pull request "Cluster size 2 package rbf":
(https://github.com/bitcoin/bitcoin/pull/28984#discussion_r1634885258)
nit:
```suggestion
// 1 parent paying 199sat, 1 child paying 1300sat.
```

💬 ryanofsky commented on pull request "Introduce Mining interface":
(https://github.com/bitcoin/bitcoin/pull/30200#issuecomment-2160764070)
> > Additionally the template provider needs to wait, to see if there's a new tip, with g_best_block_cv.wait_until. How would I go about moving that into this interface?

Maybe the simplest way to do it would be to have a waitTipChanged() method that just blocks waiting for a new tip, and would be interrupted when the node shuts down or the mining interface is destroyed. If needed, the waiting interface could have more features and accept a timeout or return an object with wait() and cancel()
...

👍 fanquake approved a pull request: "[26.x] backports and final changes for 26.2rc1"
(https://github.com/bitcoin/bitcoin/pull/30260#pullrequestreview-2110469350)
ACK 7ca424f8e651707effe1380aaf72d9ad0e97aa18

👍 theuni approved a pull request: "depends: remove `FORCE_USE_SYSTEM_CLANG`"
(https://github.com/bitcoin/bitcoin/pull/30201#pullrequestreview-2110480884)
Tested on Ubuntu 22.04 with downloaded llvm 18 binaries in PATH.

ACK 7cbfd7a7ce45ac68d6041f42f468862f5c193d8c