💬 sipa commented on pull request "util: add BitSet":
(https://github.com/bitcoin/bitcoin/pull/30160#discussion_r1631490667)
Done.

💬 katesalazar commented on pull request "wallet: Improve error log color in the console":
(https://github.com/bitcoin-core/gui/pull/823#issuecomment-2155231832)
~

✅ murchandamus closed a pull request: "Avoid changeless input sets when SFFO is active"
(https://github.com/bitcoin/bitcoin/pull/28985)

💬 murchandamus commented on pull request "Avoid changeless input sets when SFFO is active":
(https://github.com/bitcoin/bitcoin/pull/28985#issuecomment-2155232793)
Closed in favor of #29532 and #28366

💬 theuni commented on pull request "Enable clang-tidy checks for self-assignment":
(https://github.com/bitcoin/bitcoin/pull/30234#issuecomment-2155239303)
Added a commit to work around in leveldb.

@fanquake Would you be ok with carrying this in our subtree? I'm not sure of a better solution.

💬 stickies-v commented on pull request "indexes: Don't wipe indexes again when continuing a prior reindex":
(https://github.com/bitcoin/bitcoin/pull/30132#discussion_r1631503948)
I actually don't understand why we also need to check for `!do_reindex_chainstate` here, when `CChain::vChain` is populated by the blockindex building process, so my intuition tells me `chain_active_height` should only be affected by `-reindex` (but lldb tells me otherwise, so it does indeed seem necessary).

💬 TheCharlatan commented on pull request "indexes: Don't wipe indexes again when continuing a prior reindex":
(https://github.com/bitcoin/bitcoin/pull/30132#issuecomment-2155258493)
Thanks for the review @stickies-v,

Updated f68cba29b3be0dec7877022b18a193a3b78c1099 -> f68cba29b3be0dec7877022b18a193a3b78c1099 ([preserveIndexOnRestart_5](https://github.com/TheCharlatan/bitcoin/tree/preserveIndexOnRestart_5) -> [preserveIndexOnRestart_6](https://github.com/TheCharlatan/bitcoin/tree/preserveIndexOnRestart_6), [compare](https://github.com/TheCharlatan/bitcoin/compare/preserveIndexOnRestart_5..preserveIndexOnRestart_6))

* Addressed @stickies-v's [comment](https://github.com
...

👍 stickies-v approved a pull request: "indexes: Don't wipe indexes again when continuing a prior reindex"
(https://github.com/bitcoin/bitcoin/pull/30132#pullrequestreview-2105086082)
ACK f68cba29b3be0dec7877022b18a193a3b78c1099

👋 Eunovo's pull request is ready for review: "Tr partial descriptors"
(https://github.com/bitcoin/bitcoin/pull/30243)

📝 sr-gi converted_to_draft a pull request: "p2p: Fill reconciliation sets (Erlay) attempt 2"
(https://github.com/bitcoin/bitcoin/pull/30116)
This is a re-attempt of https://github.com/bitcoin/bitcoin/pull/28765

The main differences from it are:
- Most outstanding comments have been addressed (or responded to on the original PR)
- The description of how a node is picked in `IsFanoutTarget` has been updated to reflect what the algorithm is doing (not how it is doing it)
- The way `hash_key` is seeded in `IsFanoutTarget` has changed (from `m_k0` to `wtxid.ToUint256()`). This is to prevent using `m_k0` for something it is not inten
...

💬 sr-gi commented on pull request "p2p: Fill reconciliation sets (Erlay) attempt 2":
(https://github.com/bitcoin/bitcoin/pull/30116#issuecomment-2155312276)
I added two more commits, moving the fanout/reconciling logic to `RelayTransaction` instead of send message, plus dealing with ancestors in mempool, instead of descendants (which seemed to be the wrong approach).

I'm moving this to draft for now until I clean it a bit, plus get some feedback on the approach

👋 instagibbs's pull request is ready for review: "Ephemeral Anchors, take 2"
(https://github.com/bitcoin/bitcoin/pull/30239)

⚠️ sr-gi opened an issue: "Erlay Project Tracking"
(https://github.com/bitcoin/bitcoin/issues/30249)
This issue will be edited frequently to reflect the current status of the project.

**What should I review now?**
👇 👇 👇 👇 👇 👇 👇
#30116
☝️ ☝️ ☝️ ☝️ ☝️ ☝️ ☝️

- [x] Minisketch in Bitcoin Core
- [x] Main feature: #23114
- [x] #23670
- [x] #23496
- [x] #26272
- [x] Subtree updates: #24262, #25502, #26373
- [ ] Peer-to-peer
Full implementation: #21515
- [x] Main feature: #23443
- [x] Follow-up: #26359
- [x] #27797
- [ ] Main feature: #2
...

💬 sr-gi commented on issue "Erlay Project Tracking":
(https://github.com/bitcoin/bitcoin/issues/28646#issuecomment-2155333400)
@fanquake I just opened #30249, since I'm also going to push a full implementation draft to GI

✅ fanquake closed an issue: "Erlay Project Tracking"
(https://github.com/bitcoin/bitcoin/issues/28646)

💬 sipa commented on pull request "Low-level cluster linearization code":
(https://github.com/bitcoin/bitcoin/pull/30126#discussion_r1631584746)
I've renamed it to `SetType` everywhere. While it's expected to be instantiated with `BitSet`, that's not a necessity, and I expect that for certain temporarily-very-large clusters in TxGraph we'll need some algorithms instantiated by another type (something using an `std::set` or a sorted vector, for example).

💬 ryanofsky commented on pull request "indexes: Don't wipe indexes again when continuing a prior reindex":
(https://github.com/bitcoin/bitcoin/pull/30132#discussion_r1631616878)
> (but lldb tells me otherwise, so it does indeed seem necessary).

This happens because the initial chain tip is set based on the best block in the chainstate database, so if the database is being wiped, the tip is not set and the chain height is 0:

https://github.com/bitcoin/bitcoin/blob/6e4d18f37f42894fe9a0d7948c1da3f061fc6b60/src/node/chainstate.cpp#L136-L138

💬 sipsorcery commented on pull request "ci: Native Windows CI job cleanup":
(https://github.com/bitcoin/bitcoin/pull/30242#issuecomment-2155565053)
ACK 0d3ef83433805d3f367130fd5bd227a8ed5a7ccd.

👍 cbergqvist approved a pull request: "json-rpc 2.0 followups: docs, tests, cli"
(https://github.com/bitcoin/bitcoin/pull/30238#pullrequestreview-2105405928)
ACK 1f6ab1215bbb1f8a5f1743c3c413b95ad08090df

## Tests

### 1.a

PR version `bitcoin-cli` (19676e8feb6cbef4b2ebb284a85667124f038b20) <-> v27.1rc1 `bitcoind` (fccd32efe6e2950b2c74fdec2ade54040ca32a2c)

Inspected `getblock` traffic using Wireshark and observed how a `jsonrpc="2.0"` request was responded to with an object containing `version=1` but `hash` and `confirmations` were at the same level as it's referring to the *block version*, not the JSONRPC version.

New `bitcoin-cli` was a
...

💬 m3dwards commented on pull request "ci: parse TEST_RUNNER_EXTRA into an array":
(https://github.com/bitcoin/bitcoin/pull/30244#issuecomment-2155591127)
> Does such an example work on Windows in Command Prompt and PowerShell?

I can confirm that `TEST_RUNNER_EXTRA='--exclude "rpc_bind.py --ipv6,feature_proxy.py"'` works with cmd as defined in `.github/workflows/ci.yml`. Not tested Powershell but I don't believe we use this with Powershell.

[Windows CI run using that value]( https://github.com/m3dwards/bitcoin/actions/runs/9419238354/job/25948555814)