💬 sipa commented on pull request "util: add BitSet":
(https://github.com/bitcoin/bitcoin/pull/30160#discussion_r1631489851)
Done.

💬 sipa commented on pull request "util: add BitSet":
(https://github.com/bitcoin/bitcoin/pull/30160#discussion_r1631490140)
Added coverage for the `swap` function in the fuzz test.

💬 sipa commented on pull request "util: add BitSet":
(https://github.com/bitcoin/bitcoin/pull/30160#discussion_r1631490229)
Done.

💬 sipa commented on pull request "util: add BitSet":
(https://github.com/bitcoin/bitcoin/pull/30160#discussion_r1631490300)
Done.

💬 sipa commented on pull request "util: add BitSet":
(https://github.com/bitcoin/bitcoin/pull/30160#discussion_r1631490491)
Same reasoning as [here](https://github.com/bitcoin/bitcoin/pull/30160#discussion_r1631480159)

💬 sipa commented on pull request "util: add BitSet":
(https://github.com/bitcoin/bitcoin/pull/30160#discussion_r1631490602)
Done.

💬 sipa commented on pull request "util: add BitSet":
(https://github.com/bitcoin/bitcoin/pull/30160#discussion_r1631490667)
Done.

💬 katesalazar commented on pull request "wallet: Improve error log color in the console":
(https://github.com/bitcoin-core/gui/pull/823#issuecomment-2155231832)
~

✅ murchandamus closed a pull request: "Avoid changeless input sets when SFFO is active"
(https://github.com/bitcoin/bitcoin/pull/28985)

💬 murchandamus commented on pull request "Avoid changeless input sets when SFFO is active":
(https://github.com/bitcoin/bitcoin/pull/28985#issuecomment-2155232793)
Closed in favor of #29532 and #28366

💬 theuni commented on pull request "Enable clang-tidy checks for self-assignment":
(https://github.com/bitcoin/bitcoin/pull/30234#issuecomment-2155239303)
Added a commit to work around in leveldb.

@fanquake Would you be ok with carrying this in our subtree? I'm not sure of a better solution.

💬 stickies-v commented on pull request "indexes: Don't wipe indexes again when continuing a prior reindex":
(https://github.com/bitcoin/bitcoin/pull/30132#discussion_r1631503948)
I actually don't understand why we also need to check for `!do_reindex_chainstate` here, when `CChain::vChain` is populated by the blockindex building process, so my intuition tells me `chain_active_height` should only be affected by `-reindex` (but lldb tells me otherwise, so it does indeed seem necessary).

💬 TheCharlatan commented on pull request "indexes: Don't wipe indexes again when continuing a prior reindex":
(https://github.com/bitcoin/bitcoin/pull/30132#issuecomment-2155258493)
Thanks for the review @stickies-v,

Updated f68cba29b3be0dec7877022b18a193a3b78c1099 -> f68cba29b3be0dec7877022b18a193a3b78c1099 ([preserveIndexOnRestart_5](https://github.com/TheCharlatan/bitcoin/tree/preserveIndexOnRestart_5) -> [preserveIndexOnRestart_6](https://github.com/TheCharlatan/bitcoin/tree/preserveIndexOnRestart_6), [compare](https://github.com/TheCharlatan/bitcoin/compare/preserveIndexOnRestart_5..preserveIndexOnRestart_6))

* Addressed @stickies-v's [comment](https://github.com
...

👍 stickies-v approved a pull request: "indexes: Don't wipe indexes again when continuing a prior reindex"
(https://github.com/bitcoin/bitcoin/pull/30132#pullrequestreview-2105086082)
ACK f68cba29b3be0dec7877022b18a193a3b78c1099

👋 Eunovo's pull request is ready for review: "Tr partial descriptors"
(https://github.com/bitcoin/bitcoin/pull/30243)

📝 sr-gi converted_to_draft a pull request: "p2p: Fill reconciliation sets (Erlay) attempt 2"
(https://github.com/bitcoin/bitcoin/pull/30116)
This is a re-attempt of https://github.com/bitcoin/bitcoin/pull/28765

The main differences from it are:
- Most outstanding comments have been addressed (or responded to on the original PR)
- The description of how a node is picked in `IsFanoutTarget` has been updated to reflect what the algorithm is doing (not how it is doing it)
- The way `hash_key` is seeded in `IsFanoutTarget` has changed (from `m_k0` to `wtxid.ToUint256()`). This is to prevent using `m_k0` for something it is not inten
...

💬 sr-gi commented on pull request "p2p: Fill reconciliation sets (Erlay) attempt 2":
(https://github.com/bitcoin/bitcoin/pull/30116#issuecomment-2155312276)
I added two more commits, moving the fanout/reconciling logic to `RelayTransaction` instead of send message, plus dealing with ancestors in mempool, instead of descendants (which seemed to be the wrong approach).

I'm moving this to draft for now until I clean it a bit, plus get some feedback on the approach

👋 instagibbs's pull request is ready for review: "Ephemeral Anchors, take 2"
(https://github.com/bitcoin/bitcoin/pull/30239)

⚠️ sr-gi opened an issue: "Erlay Project Tracking"
(https://github.com/bitcoin/bitcoin/issues/30249)
This issue will be edited frequently to reflect the current status of the project.

**What should I review now?**
👇 👇 👇 👇 👇 👇 👇
#30116
☝️ ☝️ ☝️ ☝️ ☝️ ☝️ ☝️

- [x] Minisketch in Bitcoin Core
- [x] Main feature: #23114
- [x] #23670
- [x] #23496
- [x] #26272
- [x] Subtree updates: #24262, #25502, #26373
- [ ] Peer-to-peer
Full implementation: #21515
- [x] Main feature: #23443
- [x] Follow-up: #26359
- [x] #27797
- [ ] Main feature: #2
...

💬 sr-gi commented on issue "Erlay Project Tracking":
(https://github.com/bitcoin/bitcoin/issues/28646#issuecomment-2155333400)
@fanquake I just opened #30249, since I'm also going to push a full implementation draft to GI