💬 Sjors commented on pull request "Introduce Mining interface":
(https://github.com/bitcoin/bitcoin/pull/30200#issuecomment-2154948888)
You can see the interface in action in https://github.com/bitcoin/bitcoin/pull/29432/commits/1618c3dd86d65cf00f5f3c2c30c1db2b0e9dd9ca

👋 Sjors's pull request is ready for review: "Introduce Mining interface"
(https://github.com/bitcoin/bitcoin/pull/30200)

⚠️ maflcko opened an issue: "fuzz: wallet_bdb_parser: implicit-signed-integer-truncation wallet/migrate.cpp:554:35 "
(https://github.com/bitcoin/bitcoin/issues/30247)
Full error:

```
wallet/migrate.cpp:554:35: runtime error: implicit conversion from type 'int64_t' (aka 'long') of value -1 (64-bit, signed) to type 'uint32_t' (aka 'unsigned int') changed the value to 4294967295 (32-bit, unsigned)
```

The code:

```cpp
uint32_t expected_last_page = (size / page_size) - 1;
```

This may lead to a fuzz runtime error when `(size / page_size)` is `0`. I don't think this can lead to issues for real users, because it can only happen with corrupt files an
...

💬 Sjors commented on pull request "Stratum v2 Template Provider (take 3)":
(https://github.com/bitcoin/bitcoin/pull/29432#issuecomment-2154958567)
Updated to use the interface proposed in #30200. This also fixes a small bug: `-blockmintxfee` and `-blockmaxweight` are no longer ignored. When the latter argument is unset, by default blocks have a `4000` byte safety margin, just like with `getblocktemplate`.

💬 maflcko commented on issue "fuzz: wallet_bdb_parser: implicit-signed-integer-truncation wallet/migrate.cpp:554:35 ":
(https://github.com/bitcoin/bitcoin/issues/30247#issuecomment-2154959411)
Found by @murchandamus in https://github.com/bitcoin-core/qa-assets/pull/186#issuecomment-2154348655

```
Run wallet_bdb_parser with args ['/ci_container_base/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/test/fuzz/fuzz', '-runs=1', PosixPath('/ci_container_base/ci/scratch/qa-assets/fuzz_seed_corpus/wallet_bdb_parser')]INFO: Running with entropic power schedule (0xFF, 100).
INFO: Seed: 1090373666
INFO: Loaded 1 modules (584206 inline 8-bit counters): 584206 [0x55fc8b5c2ec8, 0x55fc8b651
...

💬 fanquake commented on pull request "json-rpc 2.0 followups: docs, tests, cli":
(https://github.com/bitcoin/bitcoin/pull/30238#discussion_r1631315946)
No objections from me.

🤔 glozow reviewed a pull request: "test: MiniWallet: respect passed feerate for padded txs (using `target_weight`)"
(https://github.com/bitcoin/bitcoin/pull/30162#pullrequestreview-2104768021)
light review ACK 39d135e79f3f0c40dfd8fad2c53723d533cd19b4

Would be nice to have this work for `create_self_transfer_multi` as well

💬 theStack commented on pull request "test: switch from curl to urllib for HTTP requests":
(https://github.com/bitcoin/bitcoin/pull/29970#issuecomment-2154998767)
One drawback of this change is that a user doesn't see download progress per file any more (relevant if e.g. servers are slow or the connection is bad for any other reason; for me this currently takes several minutes per file :/) and hence is left in the dark whether there is still activity, so Concept ~0.

💬 pinheadmz commented on pull request "json-rpc 2.0 followups: docs, tests, cli":
(https://github.com/bitcoin/bitcoin/pull/30238#discussion_r1631335859)
okie doke, added

🤔 glozow reviewed a pull request: "test: expand LimitOrphan and EraseForPeer coverage"
(https://github.com/bitcoin/bitcoin/pull/30082#pullrequestreview-2104789432)
almost ack 6831f3972ee5d660ce0bff9bb573745338417544, thanks for taking suggestions

💬 glozow commented on pull request "test: expand LimitOrphan and EraseForPeer coverage":
(https://github.com/bitcoin/bitcoin/pull/30082#discussion_r1631339561)
`EraseOrphansFor` doesn't exist

💬 Sjors commented on pull request "Introduce Mining interface":
(https://github.com/bitcoin/bitcoin/pull/30200#issuecomment-2155027685)
The `generateblock` block RPC relies on not passing the mempool to `BlockAssembler`, in order to allow manual transaction selection. So I added `bool use_mempool = true` to `createNewBlock`.

💬 instagibbs commented on pull request "test: expand LimitOrphan and EraseForPeer coverage":
(https://github.com/bitcoin/bitcoin/pull/30082#discussion_r1631356425)
:sweat: fixed

💬 Earnestly commented on issue "Witness scripts being abused to bypass datacarriersize limit (CVE-2023-50428)":
(https://github.com/bitcoin/bitcoin/issues/29187#issuecomment-2155041327)
> since they were disabled by satoshi.

Hmm.

💬 m3dwards commented on pull request "ci: parse TEST_RUNNER_EXTRA into an array":
(https://github.com/bitcoin/bitcoin/pull/30244#discussion_r1631366827)
The comment? I'm not sure

💬 m3dwards commented on pull request "ci: parse TEST_RUNNER_EXTRA into an array":
(https://github.com/bitcoin/bitcoin/pull/30244#issuecomment-2155048864)
Force pushed but only changed the commit description as it was a bad example with an extra space

💬 maflcko commented on pull request "ci: parse TEST_RUNNER_EXTRA into an array":
(https://github.com/bitcoin/bitcoin/pull/30244#issuecomment-2155053946)
reACK 3d976000afccac4e89931496f23cfe8593daeb75

💬 maflcko commented on pull request "ci: parse TEST_RUNNER_EXTRA into an array":
(https://github.com/bitcoin/bitcoin/pull/30244#discussion_r1631373966)
You can test by removing it and pushing, then observing the colour of the `lint` task after 3 minutes.

💬 glozow commented on pull request "consensus: Store transaction nVersion as uint32_t":
(https://github.com/bitcoin/bitcoin/pull/29325#issuecomment-2155066959)
concept ACK + lgtm 659663af32

Seems like this is a remaining mention of `CTransaction::nVersion`?
https://github.com/bitcoin/bitcoin/blob/659663af32f02c570e334e8f375fd5f5737258d7/src/compressor.h#L57-L60

Also noting that #29496 unfortunately conflicts and I would advocate for merging that first... but I'm happy to re-review

📝 maflcko opened a pull request: "refactor: Add explicit cast to expected_last_page to silence fuzz ISan"
(https://github.com/bitcoin/bitcoin/pull/30248)
Fixes #30247

I don't think this implicit cast can lead to any bugs, so make it explicit to silence the fuzz integer sanitizer.

Can be tested with:

```
FUZZ=wallet_bdb_parser UBSAN_OPTIONS="suppressions=$(pwd)/test/sanitizer_suppressions/ubsan:print_stacktrace=1:halt_on_error=1:report_error_type=1" ./src/test/fuzz/fuzz /tmp/1376869be72eebcc87fe737020add634b1a29533
```

After downloading the raw fuzz input from https://github.com/bitcoin-core/qa-assets/blob/24c507b3ea6263e6b121fb8dced
...