💬 hebasto commented on pull request "p2p: Avoid multiple getheaders messages in flight to the same peer":
(https://github.com/bitcoin/bitcoin/pull/25454#issuecomment-1490109063)
> `msgMaker` is now unused in ProcessHeadersMessage.

Same for `PeerManagerImpl::HandleFewUnconnectingHeaders()` and `PeerManagerImpl::ConsiderEviction()`.
See https://github.com/bitcoin/bitcoin/pull/27368.

💬 hebasto commented on pull request "guix: use python-minimal (3.9)":
(https://github.com/bitcoin/bitcoin/pull/27361#issuecomment-1490111066)
Guix builds:
```
53aa12b7fe92d92eaf81a51a8f5d534f92a2f18f0218f29fdf3221d817a53c04 guix-build-d0e571ebb187/output/aarch64-linux-gnu/SHA256SUMS.part
01467530b06b90114561e86968710250e3648fe4aba5c228781ccf9ac72394c2 guix-build-d0e571ebb187/output/aarch64-linux-gnu/bitcoin-d0e571ebb187-aarch64-linux-gnu-debug.tar.gz
fdf6dfc901e371b4e11a7f69eb2ff9b36a3ac393255862bad1dcd45b54186dca guix-build-d0e571ebb187/output/aarch64-linux-gnu/bitcoin-d0e571ebb187-aarch64-linux-gnu.tar.gz
6345b0f6b6156d84b24
...

👍 hebasto approved a pull request: "guix: use python-minimal (3.9)"
(https://github.com/bitcoin/bitcoin/pull/27361)
ACK d0e571ebb187d7c4c2821f1334cb2dd4222dd8ce

👍 TheCharlatan approved a pull request: "refactor: Drop no longer used `CNetMsgMaker` instances"
(https://github.com/bitcoin/bitcoin/pull/27368)
ACK ea7ec7808745805c0a18513d7da271dedb2de3f1

💬 vasild commented on pull request "addrman: treat Tor/I2P/CJDNS as a single group":
(https://github.com/bitcoin/bitcoin/pull/22563#issuecomment-1490127136)
Yes. But I think I should not give up on treating Tor sources as one source because this is what it is in reality. And then, addrman should be able to accommodate 10s of thousands of addresses from one source (if the source is Tor, I2P or CJDNS) and still not allow a single malicious entity to flood it.

💬 glozow commented on pull request "refactor: Move CNodeState members guarded by g_msgproc_mutex to Peer":
(https://github.com/bitcoin/bitcoin/pull/26140#discussion_r1153118703)
Question: what is the reason to put `m_recently_announced_invs` in `Peer` as opposed to `TxRelay` within `Peer`?

⚠️ vasild opened an issue: "Fix net grouping of non-IP networks"
(https://github.com/bitcoin/bitcoin/issues/27369)
### Is there an existing issue for this?

- [X] I have searched the existing issues

### Current behaviour

`NetGroupManager::GetGroup()` was designed with IP networks in mind, where for example `10.20.30.40` and `10.20.30.45` are "close" and likely to belong to the same entity, while `100.20.30.40` is "distant" from them. This does not apply however for Tor, I2P and CJDNS where the address is "random" bytes. Actually, Tor, I2P and CJDNS addresses that have common prefix are _harder_ to obtain t
...

💬 vasild commented on pull request "p2p: Improve diversification of new connections":
(https://github.com/bitcoin/bitcoin/pull/27264#issuecomment-1490154556)
How? I opened https://github.com/bitcoin/bitcoin/issues/27369 to discuss ideas on how to approach this.

💬 glozow commented on pull request "Implement Mini version of BlockAssembler to calculate mining scores":
(https://github.com/bitcoin/bitcoin/pull/27021#discussion_r1153139259)
https://cirrus-ci.com/task/4526522288046080
seems like the tidy job wants you to add this:
```suggestion
std::vector<uint256> txids_needed;
txids_needed.reserve(m_requested_outpoints_by_txid.size());
```

💬 stratospher commented on issue "Fix net grouping of non-IP networks":
(https://github.com/bitcoin/bitcoin/issues/27369#issuecomment-1490173773)
https://github.com/bitcoin/bitcoin/pull/27264#issuecomment-1490154556 - workaround it by not inserting tor/i2p/cjdns address in `setConnected` for now? so `GetGroup` wouldn't be called on these networks.

💬 Sjors commented on pull request "refactor: remove unused param from legacy pubkey interface":
(https://github.com/bitcoin/bitcoin/pull/27274#discussion_r1153151060)
Oh you're right, I missed the last push.

In the majority of cases we don't use a space after `=*/`, but that's not worth touching the PR for imo.

💬 Sjors commented on pull request "refactor: Drop no longer used `CNetMsgMaker` instances":
(https://github.com/bitcoin/bitcoin/pull/27368#issuecomment-1490183368)
ACK ea7ec7808745805c0a18513d7da271dedb2de3f1

👍 Sjors approved a pull request: "refactor: remove unused param from legacy pubkey interface"
(https://github.com/bitcoin/bitcoin/pull/27274)
ACK 1869310f3cfa4ab26b5090d8a4002eefdc84870e

⚠️ osas90 opened an issue: "Import in Bitcoin Core or a different software? What are the steps to reproduce?"
(https://github.com/bitcoin/bitcoin/issues/27370)
I got a private key in bitcoin on my blockchain.com for one of my receiving addresses. When I went to import it, it imported another address but i already used it as receiving addresses now funds now available...

_Originally posted by @MarcoFalke in https://github.com/bitcoin/bitcoin/issues/17846#issuecomment-570241898_

✅ fanquake closed an issue: "Import in Bitcoin Core or a different software? What are the steps to reproduce?"
(https://github.com/bitcoin/bitcoin/issues/27370)

:lock: fanquake locked an issue: "Import in Bitcoin Core or a different software? What are the steps to reproduce?"
(https://github.com/bitcoin/bitcoin/issues/27370)

💬 ismaelsadeeq commented on pull request "test: refactor: dedup mempool_package_limits.py subtests via decorator":
(https://github.com/bitcoin/bitcoin/pull/27350#issuecomment-1490199581)
ACK e669833943bda13b2840a174dc8e45194187fc8e

💬 Sjors commented on pull request "build: produce a .zip for macOS distribution":
(https://github.com/bitcoin/bitcoin/pull/27099#issuecomment-1490210669)
This is definitely nicer. When you doubleclick on the zip file it magically reveals the orange icon:

<img width="612" alt="Scherm­afbeelding 2023-03-30 om 14 15 54" src="https://user-images.githubusercontent.com/10217/228833150-647e3460-c174-43d0-b026-c9dbffb10b64.png">

<img width="845" alt="Scherm­afbeelding 2023-03-30 om 14 16 10" src="https://user-images.githubusercontent.com/10217/228833181-c82d0639-91a3-476f-a309-e9732577a657.png">

The only thing we need to remind the user of, is t
...

💬 Sjors commented on pull request "build: produce a .zip for macOS distribution":
(https://github.com/bitcoin/bitcoin/pull/27099#issuecomment-1490218629)
I'd like to test the Guix build too. @achow101 can you sign it? Or is there a way to self-sign it?

💬 Sjors commented on pull request "build: produce a .zip for macOS distribution":
(https://github.com/bitcoin/bitcoin/pull/27099#discussion_r1153198925)
💿