💬 achow101 commented on pull request "Fix waste calculation in SelectionResult":
(https://github.com/bitcoin/bitcoin/pull/28366#issuecomment-2148511020)
ACK bd34dd85e7b8b4cc26d2173d84bbeda2e9c27624

💬 maflcko commented on pull request "ci: add markdown link check job":
(https://github.com/bitcoin/bitcoin/pull/30034#issuecomment-2148511205)
> @maflcko do you think this hits the correct files? I think `check-ignore` will nicely include dirty files etc.

Ah sorry. I guess I was using the wrong words. With "dirty" I meant folders/files that should be ignored, but are not according to the gitignore. Maybe "untracked" is a better word, which is also used by `git status`. For example, a python venv or a generated untracked markdown file should not be included in the check.

💬 achow101 commented on pull request "wallet, rpc: document and update `sendall` behavior around unconfirmed inputs":
(https://github.com/bitcoin/bitcoin/pull/28979#issuecomment-2148514889)
ACK 71aae72e1fc998b2629d68a7301d85dc1b65641e

👍 tdb3 approved a pull request: "test: Set mocktime in p2p_disconnect_ban.py to avoid intermittent test failure"
(https://github.com/bitcoin/bitcoin/pull/30174#pullrequestreview-2097498940)
ACK for 4444de152f01368e603f2b089679a86eae02e34a

🚀 achow101 merged a pull request: "Fix waste calculation in SelectionResult"
(https://github.com/bitcoin/bitcoin/pull/28366)

🚀 achow101 merged a pull request: "wallet, rpc: document and update `sendall` behavior around unconfirmed inputs"
(https://github.com/bitcoin/bitcoin/pull/28979)

💬 achow101 commented on pull request "doc: update mention of generating bitcoin.conf":
(https://github.com/bitcoin/bitcoin/pull/30154#issuecomment-2148550641)
ACK 9013e2b97e8f50d2be63ce740c42d0b0e0b9b7f2

✅ achow101 closed an issue: "Improve the bitcoin.conf instructions in init.md doc"
(https://github.com/bitcoin/bitcoin/issues/30153)

🚀 achow101 merged a pull request: "doc: update mention of generating bitcoin.conf"
(https://github.com/bitcoin/bitcoin/pull/30154)

💬 achow101 commented on pull request "test: Assumeutxo: snapshots with less work should not be loaded":
(https://github.com/bitcoin/bitcoin/pull/29428#issuecomment-2148554999)
ACK df6dc2aaaeffc664006b86ee8c8797dc484ec40e

🚀 achow101 merged a pull request: "test: Assumeutxo: snapshots with less work should not be loaded"
(https://github.com/bitcoin/bitcoin/pull/29428)

💬 achow101 commented on pull request "consensus: Store transaction nVersion as uint32_t":
(https://github.com/bitcoin/bitcoin/pull/29325#issuecomment-2148562853)
@maflcko @vostrnad @shaavan @naumenkogs reACKs would be appreciated

💬 achow101 commented on pull request "wallet: Migrate legacy wallets to descriptor wallets without requiring BDB":
(https://github.com/bitcoin/bitcoin/pull/26596#discussion_r1626748082)
Good point, I think the original intention was to be able to handle the legacy-sqlite case, but that's moot since we require BDB_RO later. I've changed this to check for just look for BDB files, and also added your test.

💬 achow101 commented on pull request "wallet: Automatically repair corrupted metadata with doubled derivation path":
(https://github.com/bitcoin/bitcoin/pull/29124#discussion_r1626757956)
Done

💬 achow101 commented on pull request "wallet: Automatically repair corrupted metadata with doubled derivation path":
(https://github.com/bitcoin/bitcoin/pull/29124#discussion_r1626758407)
I've made `m_batch` public so that we can just pass the `WalletBatch` but still use the underlying batch object. However I'm not sure if that's something we want to do in the long term.

💬 achow101 commented on pull request "wallet: Automatically repair corrupted metadata with doubled derivation path":
(https://github.com/bitcoin/bitcoin/pull/29124#discussion_r1626758476)
Done

💬 achow101 commented on pull request "kernel: Streamline util library":
(https://github.com/bitcoin/bitcoin/pull/29015#issuecomment-2148598856)
CI failure suggests there's a silent merge conflict.

💬 achow101 commented on pull request "rpc: Remove index-based Arg accessor":
(https://github.com/bitcoin/bitcoin/pull/29997#issuecomment-2148603063)
ACK fa3169b0732d7eb4b9166e7ecc6b7cfb669a9b54

🚀 achow101 merged a pull request: "rpc: Remove index-based Arg accessor"
(https://github.com/bitcoin/bitcoin/pull/29997)

💬 achow101 commented on pull request "refactor: Model the bech32 charlimit as an Enum":
(https://github.com/bitcoin/bitcoin/pull/30047#issuecomment-2148617880)
ACK 7f3f6c6dc80247e6dfb0d406dc53bc8198f029fd