💬 maflcko commented on pull request "test: Set mocktime in p2p_disconnect_ban.py to avoid intermittent test failure":
(https://github.com/bitcoin/bitcoin/pull/30174#issuecomment-2148366625)
> nit: If another push happens, these look like typos:

Thanks, fixed.

> Did you run into this specific failure scenario, or simply being proactive?

It happened once with valgrind, which sometimes takes some time to load. You can test with:

```diff
diff --git a/test/functional/p2p_disconnect_ban.py b/test/functional/p2p_disconnect_ban.py
index 72a42a658e..aa4ae7ea27 100755
--- a/test/functional/p2p_disconnect_ban.py
+++ b/test/functional/p2p_disconnect_ban.py
@@ -103,6 +103,7 @@
...

💬 sipa commented on pull request "util: add VecDeque":
(https://github.com/bitcoin/bitcoin/pull/30161#discussion_r1626579091)
Done.

💬 sipa commented on pull request "util: add VecDeque":
(https://github.com/bitcoin/bitcoin/pull/30161#discussion_r1626579194)
Done.

💬 sipa commented on pull request "util: add VecDeque":
(https://github.com/bitcoin/bitcoin/pull/30161#discussion_r1626579310)
Done.

💬 sipa commented on pull request "util: add VecDeque":
(https://github.com/bitcoin/bitcoin/pull/30161#discussion_r1626580105)
I didn't take this suggestion. The current should be invoking `compare_fn` whenever an element is destructed or destructively overwritten; that's not necessarily number `idx` though.

💬 sipa commented on pull request "util: add VecDeque":
(https://github.com/bitcoin/bitcoin/pull/30161#discussion_r1626580268)
Done.

💬 sipa commented on pull request "util: add VecDeque":
(https://github.com/bitcoin/bitcoin/pull/30161#discussion_r1626580385)
Done.

💬 sipa commented on pull request "util: add VecDeque":
(https://github.com/bitcoin/bitcoin/pull/30161#discussion_r1626581320)
Added an `Assume` to reflect this.

✅ laanwj closed a pull request: "depends: Remove Qt build-time dependencies"
(https://github.com/bitcoin/bitcoin/pull/29923)

💬 achow101 commented on pull request "wallet: Ensure best block matches wallet scan state":
(https://github.com/bitcoin/bitcoin/pull/30221#issuecomment-2148413538)
> You might not want to write to the wallet database each time a block is connected if the block doesn't contain any relevant transactions

I think you would since not writing it would result in possibly rescanning that block at the next loading which takes a little bit of time, regardless of whether any relevant transactions are in the block.

> especially during reindexing.

Perhaps an easy solution to this is to just write the best block every 1000 blocks (or some other interval) when w
...

💬 sipa commented on pull request "util: add VecDeque":
(https://github.com/bitcoin/bitcoin/pull/30161#issuecomment-2148476988)
Added a few missing `compare_fn` calls, and also added branches to the fuzz test to exercise `pop_front()` and `pop_back()`, which were apparently missing.

💬 willcl-ark commented on pull request "ci: add markdown link check job":
(https://github.com/bitcoin/bitcoin/pull/30034#issuecomment-2148477466)
> Not sure if globbing is the right fix. Conceptually, no folder or file should be scanned that is not tracked in git.
>
> Though, I wonder if there is an easy way to ask git to print all files/folders that are "dirty", ignoring the gitignore. An alternative may be to teach mlc to read understand the gitignore files. However, that will also be incomplete, because devs may add random other folders themselves.
>
> So for now the only solution would be to call `mlc` in a loop over `git ls-fil
...

💬 achow101 commented on pull request "chainparams: Add achow101 DNS seeder":
(https://github.com/bitcoin/bitcoin/pull/30007#issuecomment-2148506279)
Anything left to do here?

***

> Are you sure you want to put this on a common domain with other things?

I don't think this will be an issue.

💬 achow101 commented on pull request "Fix waste calculation in SelectionResult":
(https://github.com/bitcoin/bitcoin/pull/28366#issuecomment-2148511020)
ACK bd34dd85e7b8b4cc26d2173d84bbeda2e9c27624

💬 maflcko commented on pull request "ci: add markdown link check job":
(https://github.com/bitcoin/bitcoin/pull/30034#issuecomment-2148511205)
> @maflcko do you think this hits the correct files? I think `check-ignore` will nicely include dirty files etc.

Ah sorry. I guess I was using the wrong words. With "dirty" I meant folders/files that should be ignored, but are not according to the gitignore. Maybe "untracked" is a better word, which is also used by `git status`. For example, a python venv or a generated untracked markdown file should not be included in the check.

💬 achow101 commented on pull request "wallet, rpc: document and update `sendall` behavior around unconfirmed inputs":
(https://github.com/bitcoin/bitcoin/pull/28979#issuecomment-2148514889)
ACK 71aae72e1fc998b2629d68a7301d85dc1b65641e

👍 tdb3 approved a pull request: "test: Set mocktime in p2p_disconnect_ban.py to avoid intermittent test failure"
(https://github.com/bitcoin/bitcoin/pull/30174#pullrequestreview-2097498940)
ACK for 4444de152f01368e603f2b089679a86eae02e34a

🚀 achow101 merged a pull request: "Fix waste calculation in SelectionResult"
(https://github.com/bitcoin/bitcoin/pull/28366)

🚀 achow101 merged a pull request: "wallet, rpc: document and update `sendall` behavior around unconfirmed inputs"
(https://github.com/bitcoin/bitcoin/pull/28979)

💬 achow101 commented on pull request "doc: update mention of generating bitcoin.conf":
(https://github.com/bitcoin/bitcoin/pull/30154#issuecomment-2148550641)
ACK 9013e2b97e8f50d2be63ce740c42d0b0e0b9b7f2