💬 stickies-v commented on pull request "indexes: Don't wipe indexes again when continuing a prior reindex":
(https://github.com/bitcoin/bitcoin/pull/30132#issuecomment-2147379245)
> The following change built on top of this PR could provide a simpler alternative: [9c643e7](https://github.com/bitcoin/bitcoin/commit/9c643e7ddd82523b84f65b614d3e6c1f640b23c7).

I like this suggestion. I think the naming is more clear in terms of the actual effect each variable has. I also think not having two `reindex` options is an improvement, the flow is more clear to me now.

I don't think `wipe_block_tree_db` (and a couple of other blockman options) should ultimately be a `Chainstate
...

👍 marcofleon approved a pull request: "fuzz: Make FuzzedSock fuzz friendlier"
(https://github.com/bitcoin/bitcoin/pull/30211#pullrequestreview-2096248644)
Tested ACK a7fceda68bb62fe3d9060fcf52e33b2f64a2acf9
In `i2p` the private key needs to be at least 387 bytes. When this key is generated (using FuzzedSock) the bytes were being broken up such that the length of the saved key was always less than 387. Having `Recv` return the length of a byte vector, instead of a single byte, when `MSG_PEEK` is enabled fixes this and allows the fuzzer to continue through the I2P target (https://github.com/bitcoin/bitcoin/issues/28803).

👍 brunoerg approved a pull request: "fuzz: Make FuzzedSock fuzz friendlier"
(https://github.com/bitcoin/bitcoin/pull/30211#pullrequestreview-2096272288)
utACK 22d0f1a27ef7733b51b3c2138a8d01713df8f248

💬 apulsifer commented on issue "LevelDB read failure: Corruption: block checksum mismatch":
(https://github.com/bitcoin/bitcoin/issues/30159#issuecomment-2147462839)
Update: After running continuously since 05-23 (no reboots or restarting bitcoind), one of the servers failed this morning. So it seems the data corruption bug occurs even when bitcoind is running continuously, although at a much lower rate.

Started bitcoind.service.
2024-05-23T11:23:40Z Bitcoin Core version v25.2.0 (release build)
2024-05-23T11:23:40Z InitParameterInteraction: parameter interaction: -blocksonly=1 -> setting -whitelistrelay=0
2024-05-23T11:23:40Z Using the 'arm_shani(1way,
...

💬 maflcko commented on pull request "Lint: Support running individual lint checks":
(https://github.com/bitcoin/bitcoin/pull/30219#issuecomment-2147517803)
ACK 0fcbfdb7ad172e518a10dd6e5be4cb6bb1158784

📝 Eudaimonios opened a pull request: "Create Implement Zero-Collar Options on Lightning Network for Stablec…"
(https://github.com/bitcoin/bitcoin/pull/30223)
…oin Value Stabilization and Volatility Reduction

Implement Zero-Collar Options on Lightning Network for Stablecoin Value Stabilization and Volatility Reduction

This pull request introduces a new feature that allows for the creation of zero-collar options on the Lightning Network to stabilize the value of stablecoins. The key components of this implementation are:

Zero-Collar Options: The ability to create options that are not dependent on the underlying asset's price, which can be used
...

💬 Eudaimonios commented on pull request "Create Implement Zero-Collar Options on Lightning Network for Stablec…":
(https://github.com/bitcoin/bitcoin/pull/30223#issuecomment-2147533551)
promising suggestion

✅ willcl-ark closed a pull request: "Create Implement Zero-Collar Options on Lightning Network for Stablec…"
(https://github.com/bitcoin/bitcoin/pull/30223)

💬 willcl-ark commented on pull request "Create Implement Zero-Collar Options on Lightning Network for Stablec…":
(https://github.com/bitcoin/bitcoin/pull/30223#issuecomment-2147540470)
I'm going to close for now as there's nothing to review here for now.

General bitcoin questions and/or support requests are best directed to the [Bitcoin StackExchange](https://bitcoin.stackexchange.com/) or the #bitcoin IRC channel on the [Libera Chat](https://libera.chat/) network.

For proposed protocol changes you can post to the bitcoin-dev [mailing list](https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-dev) or [Delving Bitcoin](https://delvingbitcoin.org/).

For general b
...

📝 fanquake locked a pull request: "Create Implement Zero-Collar Options on Lightning Network for Stablec…"
(https://github.com/bitcoin/bitcoin/pull/30223)
…oin Value Stabilization and Volatility Reduction

Implement Zero-Collar Options on Lightning Network for Stablecoin Value Stabilization and Volatility Reduction

This pull request introduces a new feature that allows for the creation of zero-collar options on the Lightning Network to stabilize the value of stablecoins. The key components of this implementation are:

Zero-Collar Options: The ability to create options that are not dependent on the underlying asset's price, which can be used
...

💬 hebasto commented on pull request "[DO NOT MERGE] cmake: Migrate CI scripts to CMake-based build system -- WIP":
(https://github.com/bitcoin/bitcoin/pull/29790#issuecomment-2147592508)
Rebased. Same as https://github.com/hebasto/bitcoin/pull/220.

🚀 fanquake merged a pull request: "fuzz: Make FuzzedSock fuzz friendlier"
(https://github.com/bitcoin/bitcoin/pull/30211)

💬 hebasto commented on pull request "ci: add markdown link check job":
(https://github.com/bitcoin/bitcoin/pull/30034#issuecomment-2147687209)
After conducting Guix builds, `lint_markdown` starts complaining about docs in `guix-build-*` subdirectories.

💬 willcl-ark commented on pull request "ci: add markdown link check job":
(https://github.com/bitcoin/bitcoin/pull/30034#issuecomment-2147694937)
> After conducting Guix builds, `lint_markdown` starts complaining about docs in `guix-build-*` subdirectories.

Oh I didn't consider this directory! I think it should be possible to add `/guix-build-*` to the [ignored files](https://github.com/bitcoin/bitcoin/blob/d39f15a8a5b06d68070a3434a81c6840d4f87715/test/lint/test_runner/src/main.rs#L298).

💬 hebasto commented on pull request "[27.x] rc2 or final":
(https://github.com/bitcoin/bitcoin/pull/30222#issuecomment-2147698924)
> Backports:
>
> * [build: Fix building `fuzz` binary on on SunOS / illumos #30216](https://github.com/bitcoin/bitcoin/pull/30216)
>
> * [depends: Update Boost download link #30217](https://github.com/bitcoin/bitcoin/pull/30217)
>
>
> I don't think either of these changes warrants an `rc2` cycle.

Agree.

💬 hebasto commented on pull request "ci: add markdown link check job":
(https://github.com/bitcoin/bitcoin/pull/30034#issuecomment-2147702543)
> > After conducting Guix builds, `lint_markdown` starts complaining about docs in `guix-build-*` subdirectories.
>
> Oh I didn't consider this directory! I think it should be possible to add `/guix-build-*` to the [ignored files](https://github.com/bitcoin/bitcoin/blob/d39f15a8a5b06d68070a3434a81c6840d4f87715/test/lint/test_runner/src/main.rs#L298).

This was what I tried before writing my comment :)

It doesn't work, unfortunately.

💬 willcl-ark commented on pull request "ci: add markdown link check job":
(https://github.com/bitcoin/bitcoin/pull/30034#issuecomment-2147704039)
Ah, that is unfortunate. I will try and find another option...

💬 ryanofsky commented on pull request "indexes: Don't wipe indexes again when continuing a prior reindex":
(https://github.com/bitcoin/bitcoin/pull/30132#issuecomment-2147710137)
> Removing the blockman option looks like a nice improvement, but I am not sure yet about the renaming. Going from `do_reindex` to `wipe_block_tree_db` back to `m_reindexing` seems a bit convoluted.

That's a good point. One possible way to address it could be to rename `m_reindexing` as well like 38cc045b6966dda009332695ed55c86bd5a9fea3. If we move away from having multiple variables called "reindex" and instead name variables individually based on what they do, I think it would be an improve
...

💬 instagibbs commented on pull request "util: add BitSet":
(https://github.com/bitcoin/bitcoin/pull/30160#discussion_r1626157391)
I like the comment in the VecDeque PR better if you'd care to just copy it here: https://github.com/bitcoin/bitcoin/pull/30161/commits/ecb278bb19c53b007380e262fa86d809255eeb49#diff-1f28310f089eac74210ecbc0db2083279282ade962dc464bd31448480dc5563dR59

💬 hebasto commented on pull request "util: add BitSet":
(https://github.com/bitcoin/bitcoin/pull/30160#issuecomment-2147744433)
Concept ACK.