💬 laanwj commented on pull request "netbase: extend CreateSock() to support creating arbitrary sockets":
(https://github.com/bitcoin/bitcoin/pull/30202#discussion_r1624295221)
Returning `sa_family_t` is slightly more self-documenting, imo, would prefer to keep it as-is.
But yes it's simply a type-def'd integer type not a real enum, i suppose because it's "open", as in, new OS headers could potentially define their own address family without having to update a central list.

💬 chrisguida commented on pull request "validation: sync chainstate to disk after syncing to tip":
(https://github.com/bitcoin/bitcoin/pull/15218#discussion_r1624301456)
Yep, that's great!!

💬 m3dwards commented on pull request "ci: move ASAN job to GitHub Actions from Cirrus CI":
(https://github.com/bitcoin/bitcoin/pull/30193#issuecomment-2145020810)
@maflcko @hebasto @fanquake do we want to just extract the USDT part of the job into Github Actions?

💬 maflcko commented on pull request "ci: move ASAN job to GitHub Actions from Cirrus CI":
(https://github.com/bitcoin/bitcoin/pull/30193#issuecomment-2145039565)
Not sure. It seems more work and overhead to maintain two tasks, instead of one, no?

💬 maflcko commented on pull request "ci: move ASAN job to GitHub Actions from Cirrus CI":
(https://github.com/bitcoin/bitcoin/pull/30193#issuecomment-2145060525)
Well, if you really wanted to do it, you could move it into the "test each commit" task, and make that one run every time, to keep the number of tasks the same.

💬 andrewtoth commented on pull request "Don't empty dbcache on prune flushes: >30% faster IBD":
(https://github.com/bitcoin/bitcoin/pull/28280#issuecomment-2145109407)
> `BatchWrite` already iterates the entire cache anyways

@achow101 I think this is what you might not be clear about. `BatchWrite` iterates the entire cache, but this patch does not. After this patch `BatchWrite` only iterates flagged entries, which is a much smaller subset of the cache.

I tried moving everything in the loop in `Sync` into `BatchWrite`, along with `cachedCoinsUsage` so it can be decremented as we delete spent coins from the child cache, and it looks like it will take many
...

💬 ismaelsadeeq commented on pull request "Fee Estimation: Ignore all transactions that are CPFP'd":
(https://github.com/bitcoin/bitcoin/pull/30079#discussion_r1624421369)
Added the comment, thanks.

💬 ismaelsadeeq commented on pull request "Fee Estimation: Ignore all transactions that are CPFP'd":
(https://github.com/bitcoin/bitcoin/pull/30079#discussion_r1624421583)
Fixed

🚀 fanquake merged a pull request: "fuzz: add more coverage for `ScriptPubKeyMan`"
(https://github.com/bitcoin/bitcoin/pull/30134)

💬 ismaelsadeeq commented on pull request "Fee Estimation: Ignore all transactions that are CPFP'd":
(https://github.com/bitcoin/bitcoin/pull/30079#issuecomment-2145153918)
> > > Do we have charts anywhere tracking % of transactions that are in a cluster size of 1?
> >
> >
> > I will analyze the percentage of cluster size 1 transactions mined in previous blocks.
>
> I tracked recent 1000 blocks from block `842457` to `843457`
>
> ~61% of transactions in the last 1000 blocks were confirmed in a cluster size > 1. ~38% of transactions in the last 1000 blocks were confirmed in a cluster size 1
>
> Transactions: 3974143 Cluster size 1 transactions: 1516505
...

💬 hebasto commented on issue "Guix builds are affected by external environment":
(https://github.com/bitcoin/bitcoin/issues/29754#issuecomment-2145155832)
> Can you confirm this is still an issue / provide a new reproducer / confirm if it's only happening on Ubuntu 23.10.

I can confirm the issue on Ubuntu 23.10, but not [able](https://bugs.launchpad.net/apparmor/+bug/2046844) to test on Ubuntu 24.04 using the system's `guix` package.

💬 TheCharlatan commented on issue "clang-format returns error":
(https://github.com/bitcoin/bitcoin/issues/29214#issuecomment-2145163638)
Might be good to note that since #29251 it is also possible to manually specify a clang format binary with the `-binary` option. It should be trivial to install a newer clang format on ubuntu, so I think this can be closed?

👍 instagibbs approved a pull request: "policy: bump TX_MAX_STANDARD_VERSION to 3"
(https://github.com/bitcoin/bitcoin/pull/29496#pullrequestreview-2093899899)
utACK 30a01134cdec37e7467fcd6eee8b0ae3890a131c

🤔 furszy reviewed a pull request: "wallet: optimize migration process, batch db transactions"
(https://github.com/bitcoin/bitcoin/pull/28574#pullrequestreview-2093904324)
Rebased due a hidden conflict with #26606.

✅ maflcko closed an issue: "make cov fails with lcov-2"
(https://github.com/bitcoin/bitcoin/issues/28468)

🚀 fanquake merged a pull request: "doc: JSON-RPC request Content-Type is application/json"
(https://github.com/bitcoin/bitcoin/pull/30215)

💬 hebasto commented on issue "Guix builds are affected by external environment":
(https://github.com/bitcoin/bitcoin/issues/29754#issuecomment-2145283596)
> I can't repro this on Ubuntu 24.04:

I can reproduce the issue on a fresh Ubuntu 24.04 installation with the default `guix` package installed and `apparmor` package uninstalled.

Using the master branch @ 80bdd4b6beb878c95478b5623c9f9ff0b948ad57 and the following commit on top of it:
```diff
commit 371a379235211504f81d10e55953f0de4b91a442 (HEAD -> 240603-test-29754.0)
Author: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>
Date: Mon Jun 3 14:40:05 2024 +0100

depe
...

💬 fanquake commented on issue "Guix builds are affected by external environment":
(https://github.com/bitcoin/bitcoin/issues/29754#issuecomment-2145287807)
Seems like this need more information then, for us to be able to do anything.

💬 maflcko commented on issue "Guix builds are affected by external environment":
(https://github.com/bitcoin/bitcoin/issues/29754#issuecomment-2145298857)
Do the shasums for the 22 LTS result differ from the 24 LTS result?

✅ mzumsande closed an issue: "clang-format returns error"
(https://github.com/bitcoin/bitcoin/issues/29214)