💬 pinheadmz commented on pull request "Support JSON-RPC 2.0 when requested by client":
(https://github.com/bitcoin/bitcoin/pull/27101#discussion_r1622621496)
Getting there...

💬 fanquake commented on pull request "build: use `-no_exported_symbols` on macOS":
(https://github.com/bitcoin/bitcoin/pull/29072#issuecomment-2142599331)
@theuni do you have any thoughts here?

💬 sr-gi commented on pull request "p2p: Fill reconciliation sets (Erlay) attempt 2":
(https://github.com/bitcoin/bitcoin/pull/30116#issuecomment-2142608188)
I've slightly extended the approach adding 3 commits to deal with short id collisions, which were not taken into account. Some of this may be squashable, I've added them separately for now so they are easy to diff/review.

This would be missing an additional commit/amend to deal with https://github.com/bitcoin/bitcoin/pull/28765#discussion_r1401014445, which I overlooked when addressing the outstanding comments

💬 Sjors commented on issue "Make Transport independent of CNetMessage and CSerializedNetMsg":
(https://github.com/bitcoin/bitcoin/issues/30209#issuecomment-2142631320)
Perhaps a third approach is to shoehorn `Sv2MsgType` into `CNetMessage`. I haven't tried that yet. In terms of elegance it's probably no worse than option (1) above.

💬 apulsifer commented on issue "LevelDB read failure: Corruption: block checksum mismatch":
(https://github.com/bitcoin/bitcoin/issues/30159#issuecomment-2142645727)
Update: Since leaving these servers alone for a week and not rebooting them or restarting bitcoind, they have stayed perfectly in sync without issues. So it looks like the problem is triggered by starting and stopping bitcoind (which I can live with, if I do have to restart a server and I get data corruption, I'll image the data from another server).

💬 sipa commented on issue "Make Transport independent of CNetMessage and CSerializedNetMsg":
(https://github.com/bitcoin/bitcoin/issues/30209#issuecomment-2142648687)
@Sjors I guess that works! It could just ignore the command name, and always decode that to ""?

💬 luke-jr commented on pull request "Policy: Report reason inputs are non standard":
(https://github.com/bitcoin/bitcoin/pull/29060#discussion_r1622750027)
Seems like it'd be nicer to just pass `state` into the function rather than creating a new one and copying it.

💬 Sjors commented on issue "Make Transport independent of CNetMessage and CSerializedNetMsg":
(https://github.com/bitcoin/bitcoin/issues/30209#issuecomment-2142747413)
By "command" you mean "m_type"?

```cpp
class CNetMessage
{
public:
DataStream m_recv; //!< received message data
std::chrono::microseconds m_time{0}; //!< time of message receipt
uint32_t m_message_size{0}; //!< size of the payload
uint32_t m_raw_message_size{0}; //!< used wire size of the message (including header/checksum)
std::string m_type;

...
};
```

`Sv2Transport` could set `m_type` to the empty string. The Template
...

👍 ismaelsadeeq approved a pull request: "Fix waste calculation in SelectionResult"
(https://github.com/bitcoin/bitcoin/pull/28366#pullrequestreview-2091447335)
Code Review ACK bd34dd85e7b8b4cc26d2173d84bbeda2e9c27624

💬 ismaelsadeeq commented on pull request "Policy: Report reason inputs are non standard":
(https://github.com/bitcoin/bitcoin/pull/29060#discussion_r1622827428)
> Seems like it'd be nicer to just pass state into the function

I am taking this review comment as a non-blocking (nit) suggestion based on the tone.

I will update this when there are blocking comments that indicate a need to retouch the diffs.

Also, I would like to know whether this PR is conceptually acknowledged, @luke-jr.
Thanks for your review.

💬 Sjors commented on pull request "net: have GetReceivedMessage() return bytes":
(https://github.com/bitcoin/bitcoin/pull/30213#issuecomment-2142814268)
As discussed in https://github.com/bitcoin/bitcoin/issues/30209#issuecomment-2142747413 I'm going to try a different approach first.

✅ Sjors closed a pull request: "net: have GetReceivedMessage() return bytes"
(https://github.com/bitcoin/bitcoin/pull/30213)

💬 boring877 commented on pull request "Testnet4 including PoW difficulty adjustment fix":
(https://github.com/bitcoin/bitcoin/pull/29775#issuecomment-2142821401)
Testnet 3 will always be the only testnet. its the market who make the rules !

💬 Self-Hosting-Group commented on pull request "net: Replace libnatpmp with built-in PCP+NATPMP implementation":
(https://github.com/bitcoin/bitcoin/pull/30043#issuecomment-2142841652)
Maybe too late or has been looked at. A PCP/NAT-PMP library https://github.com/libpcp/pcp

💬 maflcko commented on pull request "ci: move ASAN job to GitHub Actions from Cirrus CI":
(https://github.com/bitcoin/bitcoin/pull/30193#issuecomment-2142855246)
Please remove the Cirrus task in the same commit, to make review easier.

👋 mzumsande's pull request is ready for review: "p2p: When close to the tip, download blocks in parallel from additional peers to prevent stalling"
(https://github.com/bitcoin/bitcoin/pull/29664)

💬 mzumsande commented on pull request "p2p: When close to the tip, download blocks in parallel from additional peers to prevent stalling":
(https://github.com/bitcoin/bitcoin/pull/29664#issuecomment-2142874157)
Cleaned up a bit, rebased and marked as ready for review!

🤔 murchandamus reviewed a pull request: "fuzz: add more coverage for `ScriptPubKeyMan`"
(https://github.com/bitcoin/bitcoin/pull/30134#pullrequestreview-2091652125)
Tested ACK e3249f21111f1dd4beb66f10af933c34a36c30ac

I also fuzzed a bit: I ran a recent commit of the `master` branch and this PR’s e3249f21111f1dd4beb66f10af933c34a36c30ac against `qa-assets:HEAD` and then again after fuzzing about 12 CPU hours on top of `qa-assets:HEAD`.

| seeds | `qa-assets` | `qa-assets` + fuzzing |
| --- | ------------- | ------------- |
| `master` | cov: 16525 ft: 96185 | cov: 16874 ft: 104431 |
| #30134: e3249f21111f1dd4beb66f10af933c34a36c30ac | cov: 17095 ft:
...

💬 fjahr commented on pull request "Testnet4 including PoW difficulty adjustment fix":
(https://github.com/bitcoin/bitcoin/pull/29775#issuecomment-2143004073)
> If we were in a situation where Testnet has no ASICs mining it and someone points a millionth of the mainnet hashpower at Testnet (today about 650 TH/s), they could easily mine 10 difficulty periods in minutes and put the first block of the next difficulty period well out of the range of non-ASICs.

The hashpower on Testnet3 seems to have been fluctuating around ~500 TH/s over the past 2 years: https://mempool.space/testnet/graphs/mining/hashrate-difficulty If that data is correct, I am not
...

💬 sipa commented on pull request "Several randomness improvements":
(https://github.com/bitcoin/bitcoin/pull/29625#discussion_r1622999723)
@maflcko Thanks, problem seems fixed indeed!