💬 hebasto commented on pull request "depends: qt 5.15.14 and fix macOS build with Clang 18":
(https://github.com/bitcoin/bitcoin/pull/30198#issuecomment-2141709227)
My Guix builds:
```
x86_64
1efa3e0205032d6cfe5517ce36ab63379afa22268dcbb0b92150719baa030682 guix-build-0a3631fc352e/output/aarch64-linux-gnu/SHA256SUMS.part
e3db302484148c00cab7150e3451d2c95dae14062cb4165c8e5a28d71d77e630 guix-build-0a3631fc352e/output/aarch64-linux-gnu/bitcoin-0a3631fc352e-aarch64-linux-gnu-debug.tar.gz
f9792f8db8635bb19f6a2d7c73f1b0780e5776734c12912c5e7172f357f7fa1f guix-build-0a3631fc352e/output/aarch64-linux-gnu/bitcoin-0a3631fc352e-aarch64-linux-gnu.tar.gz
708374dc
...

💬 Sjors commented on pull request "Silent payment index (for light wallets and consistency check)":
(https://github.com/bitcoin/bitcoin/pull/28241#discussion_r1622190959)
Thanks, trying again...

✅ fanquake closed an issue: "build: `CPPFLAGS` usage in OSS-Fuzz"
(https://github.com/bitcoin/bitcoin/issues/29385)

💬 fanquake commented on issue "Failed assertion during shutdown":
(https://github.com/bitcoin/bitcoin/issues/23186#issuecomment-2141775367)
Is this still an issue? If yes. How is it reproduced? If it's GUI/qt only, then move it to the GUI repo?

✅ hebasto closed an issue: "Failed assertion during shutdown"
(https://github.com/bitcoin/bitcoin/issues/23186)

💬 hebasto commented on issue "Failed assertion during shutdown":
(https://github.com/bitcoin/bitcoin/issues/23186#issuecomment-2141781239)
Closing for now. Will reopen after being able to reproduce.

💬 fanquake commented on issue "test: SegFault in `ismine_tests` on SunOS / illumos":
(https://github.com/bitcoin/bitcoin/issues/29908#issuecomment-2141781410)
Are you planning on providing the requested information here, so this can be investigated further?

💬 hebasto commented on issue "test: SegFault in `ismine_tests` on SunOS / illumos":
(https://github.com/bitcoin/bitcoin/issues/29908#issuecomment-2141785791)
> Are you planning on providing the requested information here, so this can be investigated further?

Sure. Thanks for reminding :)

💬 fanquake commented on issue "build: Unaligned libsecp256k1 flags in debug builds":
(https://github.com/bitcoin/bitcoin/issues/30055#issuecomment-2141805492)
What's the status of this? Can you explain the use-case where this is an issue for you, or the other motivation?

💬 hebasto commented on pull request "contrib: Renew Windows code signing certificate":
(https://github.com/bitcoin/bitcoin/pull/30149#issuecomment-2141814209)
> Backported to 27.x in #30092.

Windows 11 shows the correct data in the "Digital Signatures Details" for the [`bitcoin-27.1rc1-win64-setup.exe`](https://bitcoincore.org/bin/bitcoin-core-27.1/test.rc1/bitcoin-27.1rc1-win64-setup.exe):


💬 maflcko commented on pull request "fuzz: bound some miniscript operations to avoid fuzz timeouts":
(https://github.com/bitcoin/bitcoin/pull/30197#discussion_r1622309134)
This isn't available yet. You'll have to use a reverse iterator manually for now.

💬 willcl-ark commented on issue "noban permission probably shouldn't give additional permissions implcitly":
(https://github.com/bitcoin/bitcoin/issues/19886#issuecomment-2141885344)
After re-thinking on this issue, in my opinion it's **correct** to send the requested block (if it exists) to a `NoBan` peer here.

The `NoBan` permission is designed to augment the Peer with:

```
// Can't be banned/disconnected/discouraged for misbehavior
```

... which I would expect to include the "misbehaviour" of requesting blocks past the `NODE_NETWORK_LIMITED` threshold.

- Changing this to the `Download` permission would have minimal practical impact, as `NoBan` [implies `Down
...

✅ hebasto closed an issue: "build: Unaligned libsecp256k1 flags in debug builds"
(https://github.com/bitcoin/bitcoin/issues/30055)

💬 willcl-ark commented on issue "contrib: makeseeds.py improvements":
(https://github.com/bitcoin/bitcoin/issues/17020#issuecomment-2141896732)
> [ ] Bring back onion functionality past TorV3 switch
> [ ] We need a source of non-hardcoded V3 peers, currently the only ones are hardcoded and the seeder hasn't been updated to crawl v3 nodes yet (see crawler: Collect Tor v3 and I2P addresses? sipa/bitcoin-seeder#92)

I think these two can be checked off post-https://github.com/bitcoin/bitcoin/pull/30008 ?

👍 hebasto approved a pull request: "depends: qt 5.15.14 and fix macOS build with Clang 18"
(https://github.com/bitcoin/bitcoin/pull/30198#pullrequestreview-2090665641)
ACK 0a3631fc352eda849290db940844e5ef723436df, a new patch indeed fixes cross-compiling on Ubuntu 24.04 with `FORCE_USE_SYSTEM_CLANG=1`.

💬 maflcko commented on pull request "Several randomness improvements":
(https://github.com/bitcoin/bitcoin/pull/29625#discussion_r1622387886)
Clearing the cache helped, so likely it was a corrupt compilation unit, cached by ccache, which also explains why a re-run didn't help.

💬 maflcko commented on pull request "depends: consolidate dependency docs":
(https://github.com/bitcoin/bitcoin/pull/30204#issuecomment-2142122297)
ACK a27e1ceb9f9c9239af9b0a151c84a57573ea646a

💬 sr-gi commented on pull request "init: fixes file descriptor accounting":
(https://github.com/bitcoin/bitcoin/pull/30065#discussion_r1622428800)
I agree with the "making it more confusing". Given this is an edge case, I'll remove the outbound count and we can account for it if someone has a better way of doing so, or if someone opens an issue about it.

📝 dergoegge opened a pull request: "fuzz: Make FuzzedSock fuzz friendlier"
(https://github.com/bitcoin/bitcoin/pull/30211)
`FuzzedSock` has a few issues that block a fuzzer from making progress. See commit messages for details.

💬 Sjors commented on pull request "Silent payment index (for light wallets and consistency check)":
(https://github.com/bitcoin/bitcoin/pull/28241#discussion_r1622453453)
Matches!