🤔 theuni reviewed a pull request: "depends: remove `FORCE_USE_SYSTEM_CLANG`"
(https://github.com/bitcoin/bitcoin/pull/30201#pullrequestreview-2088776148)
Concept ACK
(https://github.com/bitcoin/bitcoin/pull/30201#pullrequestreview-2088776148)
Concept ACK
💬 fanquake commented on pull request "depends: remove `FORCE_USE_SYSTEM_CLANG`":
(https://github.com/bitcoin/bitcoin/pull/30201#discussion_r1621045177)
Yea. Depending on when this lands, we could update this to recommend LLVM 18, as that's likely what is going to be used in the CI, if we just `apt install clang` on Ubuntu `24.04`. At a minimum, given we use `-fixup_chains`, we require at least LLVM 16 or later.
(https://github.com/bitcoin/bitcoin/pull/30201#discussion_r1621045177)
Yea. Depending on when this lands, we could update this to recommend LLVM 18, as that's likely what is going to be used in the CI, if we just `apt install clang` on Ubuntu `24.04`. At a minimum, given we use `-fixup_chains`, we require at least LLVM 16 or later.
💬 maflcko commented on pull request "depends: consolidate dependency docs":
(https://github.com/bitcoin/bitcoin/pull/30204#discussion_r1621052228)
Might as well put in `build-essential` when this includes Bitcoin Core dependencies such as `bsdmainutils`?
Ref: https://github.com/bitcoin/bitcoin/blob/master/doc/build-unix.md#dependency-build-instructions
(https://github.com/bitcoin/bitcoin/pull/30204#discussion_r1621052228)
Might as well put in `build-essential` when this includes Bitcoin Core dependencies such as `bsdmainutils`?
Ref: https://github.com/bitcoin/bitcoin/blob/master/doc/build-unix.md#dependency-build-instructions
💬 fanquake commented on pull request "depends: consolidate dependency docs":
(https://github.com/bitcoin/bitcoin/pull/30204#discussion_r1621057895)
Right, we could, but https://packages.ubuntu.com/mantic/build-essential is basically gcc, g++ and make. Should we then remove make from this list too, and g++ from the macOS list?
I think I'd actually rather remove `bsdmainutils`, as I really wanted the dependencies listed here to just be what is required to actually build depends, rather than everything needed for Bitcoin Core.
(https://github.com/bitcoin/bitcoin/pull/30204#discussion_r1621057895)
Right, we could, but https://packages.ubuntu.com/mantic/build-essential is basically gcc, g++ and make. Should we then remove make from this list too, and g++ from the macOS list?
I think I'd actually rather remove `bsdmainutils`, as I really wanted the dependencies listed here to just be what is required to actually build depends, rather than everything needed for Bitcoin Core.
💬 Sjors commented on pull request "test: add mocked Sock that can read/write custom data and/or CNetMessages":
(https://github.com/bitcoin/bitcoin/pull/30205#issuecomment-2140176994)
This seems very useful. I'll try to use it for the (currently very brittle) `Sv2Transport` tests in #29432, and review it along the way.
(https://github.com/bitcoin/bitcoin/pull/30205#issuecomment-2140176994)
This seems very useful. I'll try to use it for the (currently very brittle) `Sv2Transport` tests in #29432, and review it along the way.
💬 fanquake commented on pull request "depends: consolidate dependency docs":
(https://github.com/bitcoin/bitcoin/pull/30204#discussion_r1621059049)
Happy to also update build-unix at the same time, to add anything that is missing.
(https://github.com/bitcoin/bitcoin/pull/30204#discussion_r1621059049)
Happy to also update build-unix at the same time, to add anything that is missing.
💬 Sjors commented on pull request "net: Replace libnatpmp with built-in PCP+NATPMP implementation":
(https://github.com/bitcoin/bitcoin/pull/30043#discussion_r1621060075)
I got a bit confused about these two new PR's, but I guess they are orthogonal.
(https://github.com/bitcoin/bitcoin/pull/30043#discussion_r1621060075)
I got a bit confused about these two new PR's, but I guess they are orthogonal.
💬 maflcko commented on pull request "depends: consolidate dependency docs":
(https://github.com/bitcoin/bitcoin/pull/30204#discussion_r1621061352)
I agree (see my previous ACK), but probably it doesn't matter much. Should be fine to merge either.
(https://github.com/bitcoin/bitcoin/pull/30204#discussion_r1621061352)
I agree (see my previous ACK), but probably it doesn't matter much. Should be fine to merge either.
💬 laanwj commented on issue "VM disk for OS (Debian 12.x) gets smaller and smaller - NOT the same disk i used for .bitdoin data directory which is mounted on another disk":
(https://github.com/bitcoin/bitcoin/issues/30191#issuecomment-2140183410)
> maybe it saves tons of logs in /var/ log ??
Bitcoin core itself doesn't write anything to `/var` or anywhere but the data directory. Of course, it may be that some other process is doing that. You'd want to figure out what files use the disk space. i don't know what's a good tool for that in windows but in Linux you'd typically use `du -h`.
(https://github.com/bitcoin/bitcoin/issues/30191#issuecomment-2140183410)
> maybe it saves tons of logs in /var/ log ??
Bitcoin core itself doesn't write anything to `/var` or anywhere but the data directory. Of course, it may be that some other process is doing that. You'd want to figure out what files use the disk space. i don't know what's a good tool for that in windows but in Linux you'd typically use `du -h`.
💬 Sjors commented on pull request "Introduce Miner interface":
(https://github.com/bitcoin/bitcoin/pull/30200#issuecomment-2140187315)
Let me know if I should expand the interface to cover more of `rpc/mining.cpp` or stick to this for now.
(https://github.com/bitcoin/bitcoin/pull/30200#issuecomment-2140187315)
Let me know if I should expand the interface to cover more of `rpc/mining.cpp` or stick to this for now.
💬 maflcko commented on issue "VM disk for OS (Debian 12.x) gets smaller and smaller - NOT the same disk i used for .bitdoin data directory which is mounted on another disk":
(https://github.com/bitcoin/bitcoin/issues/30191#issuecomment-2140191219)
On Windows you can just right click and the Properties dialogue should spit out the folder size, IIRC? (Haven't used it in a decade). But yeah, without more details, there is nothing that can be done here.
(https://github.com/bitcoin/bitcoin/issues/30191#issuecomment-2140191219)
On Windows you can just right click and the Properties dialogue should spit out the folder size, IIRC? (Haven't used it in a decade). But yeah, without more details, there is nothing that can be done here.
💬 Sjors commented on pull request "Introduce Miner interface":
(https://github.com/bitcoin/bitcoin/pull/30200#discussion_r1621066944)
f04cf9f75054573c204245f7bb1e6813cce1fed8: I guess I should change the `BlockAssembler` constructor
(https://github.com/bitcoin/bitcoin/pull/30200#discussion_r1621066944)
f04cf9f75054573c204245f7bb1e6813cce1fed8: I guess I should change the `BlockAssembler` constructor
💬 Sjors commented on pull request "Introduce Miner interface":
(https://github.com/bitcoin/bitcoin/pull/30200#discussion_r1621067334)
f04cf9f75054573c204245f7bb1e6813cce1fed8: I guess I should change the `BlockAssembler` constructor
(https://github.com/bitcoin/bitcoin/pull/30200#discussion_r1621067334)
f04cf9f75054573c204245f7bb1e6813cce1fed8: I guess I should change the `BlockAssembler` constructor
💬 maflcko commented on pull request "depends: remove `FORCE_USE_SYSTEM_CLANG`":
(https://github.com/bitcoin/bitcoin/pull/30201#discussion_r1621067469)
Probably best to move everything (CI + guix) at the same time, in the same pull?
(https://github.com/bitcoin/bitcoin/pull/30201#discussion_r1621067469)
Probably best to move everything (CI + guix) at the same time, in the same pull?
💬 fanquake commented on pull request "depends: remove `FORCE_USE_SYSTEM_CLANG`":
(https://github.com/bitcoin/bitcoin/pull/30201#discussion_r1621068763)
Yea. If/when it does change, everything will continue to change in lockstep.
(https://github.com/bitcoin/bitcoin/pull/30201#discussion_r1621068763)
Yea. If/when it does change, everything will continue to change in lockstep.
💬 Sjors commented on pull request "Introduce Miner interface":
(https://github.com/bitcoin/bitcoin/pull/30200#discussion_r1621071328)
@ryanofsky I'm not sure what the design philophy is behind `Ensure` and `EnsureAny`. The other methods here return more low level objects.
Perhaps related to what you said here:
> > I think of "Context" as being a passive container for state instead of an object you would call methods on. The top level interfaces like `interfaces::Chain` `interface::Node` `interfaces::Wallet` are actually stateless themselves, and only point to state stored in other places. (The idea is to let interface in
...
(https://github.com/bitcoin/bitcoin/pull/30200#discussion_r1621071328)
@ryanofsky I'm not sure what the design philophy is behind `Ensure` and `EnsureAny`. The other methods here return more low level objects.
Perhaps related to what you said here:
> > I think of "Context" as being a passive container for state instead of an object you would call methods on. The top level interfaces like `interfaces::Chain` `interface::Node` `interfaces::Wallet` are actually stateless themselves, and only point to state stored in other places. (The idea is to let interface in
...
💬 theuni commented on pull request "depends: consolidate dependency docs":
(https://github.com/bitcoin/bitcoin/pull/30204#discussion_r1621091245)
> I think I'd actually rather remove bsdmainutils, as I really wanted the dependencies listed here to just be what is required to actually build depends, rather than everything needed for Bitcoin Core.
Works for me.
(https://github.com/bitcoin/bitcoin/pull/30204#discussion_r1621091245)
> I think I'd actually rather remove bsdmainutils, as I really wanted the dependencies listed here to just be what is required to actually build depends, rather than everything needed for Bitcoin Core.
Works for me.
💬 kosuodhmwa commented on issue "VM disk for OS (Debian 12.x) gets smaller and smaller - NOT the same disk i used for .bitdoin data directory which is mounted on another disk":
(https://github.com/bitcoin/bitcoin/issues/30191#issuecomment-2140266954)
bitcoind is not (directly) on Windows 10 (pro, x64) - the screenshot just shows the drives used by my bitcoind Debian 12.5 virtual machine.
since i added "txindex=1", the drive B:\ where ~/.bitcoind linux mount point saves its data increase NOT, while I:\ drive (where the debian 12.5 os is, the rest, excluding ~/.bitcoind) space decreased rapidly... ca. from 40gb left to 3.7gb left
My implication: bitcoind does not only save its data in ~/.bitcoin directory ("data directory" where the blo
...
(https://github.com/bitcoin/bitcoin/issues/30191#issuecomment-2140266954)
bitcoind is not (directly) on Windows 10 (pro, x64) - the screenshot just shows the drives used by my bitcoind Debian 12.5 virtual machine.
since i added "txindex=1", the drive B:\ where ~/.bitcoind linux mount point saves its data increase NOT, while I:\ drive (where the debian 12.5 os is, the rest, excluding ~/.bitcoind) space decreased rapidly... ca. from 40gb left to 3.7gb left
My implication: bitcoind does not only save its data in ~/.bitcoin directory ("data directory" where the blo
...
👍 theuni approved a pull request: "build: remove `--enable-lcov-branch-coverage`"
(https://github.com/bitcoin/bitcoin/pull/30192#pullrequestreview-2088862324)
utACK cbd4640ede92a1a5d7b7c1367eb7c00a9f476c62
(https://github.com/bitcoin/bitcoin/pull/30192#pullrequestreview-2088862324)
utACK cbd4640ede92a1a5d7b7c1367eb7c00a9f476c62
💬 sipa commented on issue "VM disk for OS (Debian 12.x) gets smaller and smaller - NOT the same disk i used for .bitdoin data directory which is mounted on another disk":
(https://github.com/bitcoin/bitcoin/issues/30191#issuecomment-2140277517)
Well you can look at it, presumably? How much data is in the `~/.bitcoin` directory? If it's empty, perhaps there is a configuration error and some other directory is used as datadir?
(https://github.com/bitcoin/bitcoin/issues/30191#issuecomment-2140277517)
Well you can look at it, presumably? How much data is in the `~/.bitcoin` directory? If it's empty, perhaps there is a configuration error and some other directory is used as datadir?