📝 fanquake opened a pull request: "depends: qt 5.15.14 and fix macOS build with Clang 18"
(https://github.com/bitcoin/bitcoin/pull/30198)
Also adds a patch to Qts internal libpng, to fix compilation using Clang 18, when targetting macOS. I'd like to get this patched, so we can continue working on removing `FORCE_USE_SYSTEM_CLANG`; otherwise builds will be broken using the default Clang (`18`) on the current Ubuntu LTS (`24.04`).

With this PR, anyone using Ubuntu 24.04 should be able to `apt install clang`, and then cross-compile for macOS using:
```bash
# clang --version
Ubuntu clang version 18.1.3 (1)
make -C depends HOST=
...

💬 fanquake commented on pull request "releases: use LLVM 18 for macOS":
(https://github.com/bitcoin/bitcoin/pull/30022#discussion_r1620506823)
First step in #30198.

👍 TheCharlatan approved a pull request: "fuzz: a target for the block index database"
(https://github.com/bitcoin/bitcoin/pull/28209#pullrequestreview-2088000201)
Re-ACK 86b38529d5014612c3e7bb59fdc4dad3bff2aa64

👍 TheCharlatan approved a pull request: "fuzz: a new target for the coins database"
(https://github.com/bitcoin/bitcoin/pull/28216#pullrequestreview-2088008295)
ACK e79784e517653cd8d29670861528f7adbf4c976a

💬 cdecker commented on issue "DNS seed "seed.bitcoinstats.com" doesn't support filtering while the comments says it does":
(https://github.com/bitcoin/bitcoin/issues/29911#issuecomment-2139357417)
So just to add a bit of context here, I was using my own implementation of the seeder in order to add a bit of diversity. However that scanner has been flaky for quite some time and I am having trouble to find the time to fix up the scanner. I am planning to get back to this, however I cannot give a timeline, so if this is a real issue, please feel free to remove the seed from the code, and I'll re-add it once it has been fixed up :+1:

🚀 fanquake merged a pull request: "ci: add markdown link check job"
(https://github.com/bitcoin/bitcoin/pull/30034)

💬 fanquake commented on pull request "doc, rpc: Release notes and follow-ups for #29612":
(https://github.com/bitcoin/bitcoin/pull/30167#issuecomment-2139364588)
@theStack or @TheCharlatan want to have a look over the followup?

💬 vasild commented on pull request "net: Replace libnatpmp with built-in PCP+NATPMP implementation":
(https://github.com/bitcoin/bitcoin/pull/30043#discussion_r1620553530)
Done in the topmost commit in https://github.com/vasild/bitcoin/commits/extend_CreateSock/.
Separate PR or include in this PR?

🤔 rkrux reviewed a pull request: "test: improve BDB parser (handle internal/overflow pages, support all page sizes)"
(https://github.com/bitcoin/bitcoin/pull/30125#pullrequestreview-2087749494)
Incomplete review and untested yet, left couple comments off the top of my head atm.
Will do another round thoroughly in the next few days.

💬 rkrux commented on pull request "test: improve BDB parser (handle internal/overflow pages, support all page sizes)":
(https://github.com/bitcoin/bitcoin/pull/30125#discussion_r1620352306)
WDYT about creating a constant tuple for these values? They seem pretty generic enough.

💬 rkrux commented on pull request "test: improve BDB parser (handle internal/overflow pages, support all page sizes)":
(https://github.com/bitcoin/bitcoin/pull/30125#discussion_r1620344538)
There's a separate effort from @maflcko regarding removing the usage of `struct.pack` from all places in test. Though here it's `struct.unpack` but I guess the reasoning for the removal of `struct.pack` is still applicable.
https://github.com/bitcoin/bitcoin/pull/29401

📝 hebasto opened a pull request: "clang-tidy: Add `bugprone-move-forwarding-reference` check"
(https://github.com/bitcoin/bitcoin/pull/30199)
This PR adds [`bugprone-move-forwarding-reference`](https://clang.llvm.org/extra/clang-tidy/checks/bugprone/move-forwarding-reference.html) to the clang-tidy checks.

💬 fanquake commented on pull request "depends: qt 5.15.14 and fix macOS build with Clang 18":
(https://github.com/bitcoin/bitcoin/pull/30198#issuecomment-2139456069)
Guix Build (aarch64):
```bash
1efa3e0205032d6cfe5517ce36ab63379afa22268dcbb0b92150719baa030682 guix-build-0a3631fc352e/output/aarch64-linux-gnu/SHA256SUMS.part
e3db302484148c00cab7150e3451d2c95dae14062cb4165c8e5a28d71d77e630 guix-build-0a3631fc352e/output/aarch64-linux-gnu/bitcoin-0a3631fc352e-aarch64-linux-gnu-debug.tar.gz
f9792f8db8635bb19f6a2d7c73f1b0780e5776734c12912c5e7172f357f7fa1f guix-build-0a3631fc352e/output/aarch64-linux-gnu/bitcoin-0a3631fc352e-aarch64-linux-gnu.tar.gz
708374
...

📝 Sjors opened a pull request: "Introduce Miner interface"
(https://github.com/bitcoin/bitcoin/pull/30200)
Introduce a `Miner` interface for the `getblocktemplate` RPC to use now, and for Stratum v2 to use later.

Suggested here: https://github.com/bitcoin/bitcoin/pull/29346#issuecomment-2108528652

💬 Sjors commented on pull request "Introduce Miner interface":
(https://github.com/bitcoin/bitcoin/pull/30200#issuecomment-2139459750)
The commit is all the boilerplate plus a single method `isTestChain()` that's used by the `getblocktemplate` RPC.

💬 Sjors commented on pull request "Stratum v2 Noise Protocol":
(https://github.com/bitcoin/bitcoin/pull/29346#issuecomment-2139460402)
@ryanofsky let's continue the interface design in #30200.

💬 Sjors commented on pull request "net: Replace libnatpmp with built-in PCP+NATPMP implementation":
(https://github.com/bitcoin/bitcoin/pull/30043#discussion_r1620636660)
This PR is already quite large, so let's make a fresh one that this can rebase on if needed.

💬 Sjors commented on pull request "net: Replace libnatpmp with built-in PCP+NATPMP implementation":
(https://github.com/bitcoin/bitcoin/pull/30043#issuecomment-2139467569)
With a bridged network it indeed works.

Also, as suggested by @vasild, doing `kldload /boot/kernel/netlink.ko` makes things work on FreeBSD 13.2.

💬 sipa commented on pull request "net_processing: make any misbehavior trigger immediate discouragement":
(https://github.com/bitcoin/bitcoin/pull/29575#discussion_r1620639863)
Done.

💬 sipa commented on pull request "net_processing: make any misbehavior trigger immediate discouragement":
(https://github.com/bitcoin/bitcoin/pull/29575#discussion_r1620640074)
Done.