💬 0xB10C commented on pull request "ci: move ASAN job to GitHub Actions from Cirrus CI":
(https://github.com/bitcoin/bitcoin/pull/30193#issuecomment-2139206624)
Concept ACK! Thanks for working on this!

💬 darosior commented on issue "fuzz: Fix timeouts":
(https://github.com/bitcoin/bitcoin/issues/28812#issuecomment-2139268235)
> [clusterfuzz-testcase-mocked_descriptor_parse-5224675118481408.bin.not.txt](https://github.com/bitcoin/bitcoin/files/13877884/clusterfuzz-testcase-mocked_descriptor_parse-5224675118481408.bin.not.txt)
> [clusterfuzz-testcase-minimized-descriptor_parse-5888623437217792.bin.txt](https://github.com/bitcoin/bitcoin/files/15238132/clusterfuzz-testcase-minimized-descriptor_parse-5888623437217792.bin.txt)

For those there is probably something to be done by someone more experienced at C++ than i a
...

💬 maflcko commented on issue "fuzz: Fix timeouts":
(https://github.com/bitcoin/bitcoin/issues/28812#issuecomment-2139287173)
> I think we'll have to limit the size of the input, unfortunately.

Yes, as long as all possible real-world scenarios are covered, this is fine as well.

💬 Numbers0689 commented on issue "test: replace bare asserts with assertion helpers (assert_equal() etc.)":
(https://github.com/bitcoin/bitcoin/issues/23119#issuecomment-2139291697)
is the issue still relevant? can i work on it?

💬 maflcko commented on pull request "fuzz: increase `txorphan` harness stability":
(https://github.com/bitcoin/bitcoin/pull/30186#issuecomment-2139292306)
utACK 8defc182a31d828ad0f53ebf7e3be9e9cfc42d09

💬 maflcko commented on pull request "fuzz: increase `txorphan` harness stability":
(https://github.com/bitcoin/bitcoin/pull/30186#issuecomment-2139293546)
cc @glozow This conflicts with some of your pulls, so maybe you can have a look here? (https://github.com/bitcoin/bitcoin/pull/30186#issuecomment-2135744973)

✅ fanquake closed a pull request: "releases: use LLVM 18 for macOS"
(https://github.com/bitcoin/bitcoin/pull/30022)

💬 maflcko commented on pull request "Several randomness improvements":
(https://github.com/bitcoin/bitcoin/pull/29625#discussion_r1620494947)
```
node1 stderr bitcoind: random.h:218: uint64_t RandomMixin<FastRandomContext>::randbits(int) [T = FastRandomContext]: Assertion `bits >= bitbuf_size' failed.
```

I guess this is a compiler bug. I'll try to take a look here.

📝 darosior opened a pull request: "fuzz: bound some miniscript operations to avoid fuzz timeouts"
(https://github.com/bitcoin/bitcoin/pull/30197)
Some of the logic in the miniscript module is quadratic. It only becomes an issue for very large uninteresting descriptors (like a `thresh` with 130k sub-fragments or a fragment with more than 60k nested `j:` wrappers).

This PR fixes the two types of fuzz timeouts reported by Marco in https://github.com/bitcoin/bitcoin/issues/28812 by trying to pinpoint the problematic descriptors through a simple analysis of the string, without limiting the size of the string itself. This is the same approac
...

📝 fanquake opened a pull request: "depends: qt 5.15.14 and fix macOS build with Clang 18"
(https://github.com/bitcoin/bitcoin/pull/30198)
Also adds a patch to Qts internal libpng, to fix compilation using Clang 18, when targetting macOS. I'd like to get this patched, so we can continue working on removing `FORCE_USE_SYSTEM_CLANG`; otherwise builds will be broken using the default Clang (`18`) on the current Ubuntu LTS (`24.04`).

With this PR, anyone using Ubuntu 24.04 should be able to `apt install clang`, and then cross-compile for macOS using:
```bash
# clang --version
Ubuntu clang version 18.1.3 (1)
make -C depends HOST=
...

💬 fanquake commented on pull request "releases: use LLVM 18 for macOS":
(https://github.com/bitcoin/bitcoin/pull/30022#discussion_r1620506823)
First step in #30198.

👍 TheCharlatan approved a pull request: "fuzz: a target for the block index database"
(https://github.com/bitcoin/bitcoin/pull/28209#pullrequestreview-2088000201)
Re-ACK 86b38529d5014612c3e7bb59fdc4dad3bff2aa64

👍 TheCharlatan approved a pull request: "fuzz: a new target for the coins database"
(https://github.com/bitcoin/bitcoin/pull/28216#pullrequestreview-2088008295)
ACK e79784e517653cd8d29670861528f7adbf4c976a

💬 cdecker commented on issue "DNS seed "seed.bitcoinstats.com" doesn't support filtering while the comments says it does":
(https://github.com/bitcoin/bitcoin/issues/29911#issuecomment-2139357417)
So just to add a bit of context here, I was using my own implementation of the seeder in order to add a bit of diversity. However that scanner has been flaky for quite some time and I am having trouble to find the time to fix up the scanner. I am planning to get back to this, however I cannot give a timeline, so if this is a real issue, please feel free to remove the seed from the code, and I'll re-add it once it has been fixed up :+1:

🚀 fanquake merged a pull request: "ci: add markdown link check job"
(https://github.com/bitcoin/bitcoin/pull/30034)

💬 fanquake commented on pull request "doc, rpc: Release notes and follow-ups for #29612":
(https://github.com/bitcoin/bitcoin/pull/30167#issuecomment-2139364588)
@theStack or @TheCharlatan want to have a look over the followup?

💬 vasild commented on pull request "net: Replace libnatpmp with built-in PCP+NATPMP implementation":
(https://github.com/bitcoin/bitcoin/pull/30043#discussion_r1620553530)
Done in the topmost commit in https://github.com/vasild/bitcoin/commits/extend_CreateSock/.
Separate PR or include in this PR?

🤔 rkrux reviewed a pull request: "test: improve BDB parser (handle internal/overflow pages, support all page sizes)"
(https://github.com/bitcoin/bitcoin/pull/30125#pullrequestreview-2087749494)
Incomplete review and untested yet, left couple comments off the top of my head atm.
Will do another round thoroughly in the next few days.

💬 rkrux commented on pull request "test: improve BDB parser (handle internal/overflow pages, support all page sizes)":
(https://github.com/bitcoin/bitcoin/pull/30125#discussion_r1620352306)
WDYT about creating a constant tuple for these values? They seem pretty generic enough.

💬 rkrux commented on pull request "test: improve BDB parser (handle internal/overflow pages, support all page sizes)":
(https://github.com/bitcoin/bitcoin/pull/30125#discussion_r1620344538)
There's a separate effort from @maflcko regarding removing the usage of `struct.pack` from all places in test. Though here it's `struct.unpack` but I guess the reasoning for the removal of `struct.pack` is still applicable.
https://github.com/bitcoin/bitcoin/pull/29401