💬 ajtowns commented on pull request "contrib: add tool to convert compact-serialized UTXO set to SQLite database":
(https://github.com/bitcoin/bitcoin/pull/27432#issuecomment-2136522127)
utACK 0a89179d62a5b2c5ebc20b806122bb50fc199cba -- no deep review, but being able to mess around with the utxo set as an sqlite dump is handy, and adding a script to contrib seems low risk.

As at height 844861, the raw dump is ~12GB and the sqlite version is ~25GB, so having a bunch of free space is helpful if you want to try it out.

💬 maflcko commented on pull request "fuzz: increase `txorphan` harness stability":
(https://github.com/bitcoin/bitcoin/pull/30186#issuecomment-2136633794)
> and it didn't work on Mac.

You'll have to install and use gnu-sed on macos, or use Linux. If you don't want to test locally and want to know the syntax without testing, you can look at previous examples via `git log --grep='sed -i'`.

Though, I am not sure if a three line diff is worth a scripted diff, so an alternative would be to just squash everything down into a single commit.

💬 maflcko commented on pull request "fuzz: increase `txorphan` harness stability":
(https://github.com/bitcoin/bitcoin/pull/30186#discussion_r1618285437)
In any case, you are changing the code to leave the variable uninitialized. This is undefined behavior.

You can test this with valgrind, or msan.

🤔 glozow reviewed a pull request: "[25.x] windeploy: Renew certificate"
(https://github.com/bitcoin/bitcoin/pull/30184#pullrequestreview-2084528082)
ACK 7a4eff2c98eb41e304cfb03372bce401909bf3d0

💬 willcl-ark commented on pull request "[27.x] Backports and rc1":
(https://github.com/bitcoin/bitcoin/pull/30092#issuecomment-2136772471)
reACK 22701a43464ab27ea83c8b49e2732ee647909a10

on range-diff https://github.com/bitcoin/bitcoin/compare/f30e23e4b35b52728ebaa1a63ec9a6feac51ebb4..22701a43464ab27ea83c8b49e2732ee647909a10

👍 hebasto approved a pull request: "[27.x] Backports and rc1"
(https://github.com/bitcoin/bitcoin/pull/30092#pullrequestreview-2084595651)
re-ACK 22701a43464ab27ea83c8b49e2732ee647909a10.

💬 willcl-ark commented on pull request "Update manpage descriptions":
(https://github.com/bitcoin/bitcoin/pull/29686#discussion_r1618399698)
Re-worded in 4aff4ea92c96f4f66e0159329ad8d01d4cf7bce7

👍 TheCharlatan approved a pull request: "Encapsulate warnings in generalized node::Warnings and remove globals"
(https://github.com/bitcoin/bitcoin/pull/30058#pullrequestreview-2084610211)
Re-ACK 468cf536eb6473b0fbc1d0f9763c8d6caedeb849

📝 Sajjon opened a pull request: "Fix typos in 36 files | Almost only documentation"
(https://github.com/bitcoin/bitcoin/pull/30188)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

💬 Sajjon commented on pull request "Fix typos in 36 files | Almost only documentation":
(https://github.com/bitcoin/bitcoin/pull/30188#discussion_r1618407491)
`rg "ROWS_AVALIABLE_FOR_LIST"` shows empty, so all relevant references have been renamed.

💬 Sajjon commented on pull request "Fix typos in 36 files | Almost only documentation":
(https://github.com/bitcoin/bitcoin/pull/30188#discussion_r1618408697)
The config *is* named `FORMULA_TRANSPARENT` so this is purely a typo correction, no logic effect.

💬 Sajjon commented on pull request "Fix typos in 36 files | Almost only documentation":
(https://github.com/bitcoin/bitcoin/pull/30188#discussion_r1618409723)
Seems to only be a debug print, so should be ok?

🚀 fanquake merged a pull request: "[25.x] windeploy: Renew certificate"
(https://github.com/bitcoin/bitcoin/pull/30184)

💬 Sajjon commented on pull request "Fix typos in 36 files | Almost only documentation":
(https://github.com/bitcoin/bitcoin/pull/30188#discussion_r1618411643)
This is just a test, so should be OK to correct typo in the written contents to file test file?

💬 fanquake commented on pull request "Fix typos in 36 files | Almost only documentation":
(https://github.com/bitcoin/bitcoin/pull/30188#issuecomment-2136799942)
Thanks, however most of these are in upstream code (subtrees, macros, Doxygen config), or code we aren't going to change (like the release notes). You'll need to remove all of those changes, and then also write a proper commit message.

💬 Sajjon commented on pull request "Fix typos in 36 files | Almost only documentation":
(https://github.com/bitcoin/bitcoin/pull/30188#issuecomment-2136803187)
> Thanks, however most of these are in upstream code (subtrees, macros, Doxygen config), or code we aren't going to change (like the release notes). You'll need to remove all of those changes, and then also write a proper commit message.

👍 thx! Will give it another go later tonight. Any suggsetion on what a "proper commit message" would be?

💬 dergoegge commented on pull request "fuzz: increase `txorphan` harness stability":
(https://github.com/bitcoin/bitcoin/pull/30186#issuecomment-2136805200)
> I am not sure if a three line diff is worth a scripted diff

Just for context, I suggested it to marco as a learning exercise.

💬 fanquake commented on pull request "Fix typos in 36 files | Almost only documentation":
(https://github.com/bitcoin/bitcoin/pull/30188#issuecomment-2136808686)
> Any suggestion on what a "proper commit message" would be?

https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md.

📝 fanquake converted_to_draft a pull request: "Fix typos in 36 files | Almost only documentation"
(https://github.com/bitcoin/bitcoin/pull/30188)
Fix typos in 36 files

💬 maflcko commented on pull request "fuzz: increase `txorphan` harness stability":
(https://github.com/bitcoin/bitcoin/pull/30186#issuecomment-2136811524)
Sure, sounds good either way. Happy to review once CI is green and the UB is removed.