💬 willcl-ark commented on pull request "Update manpage descriptions":
(https://github.com/bitcoin/bitcoin/pull/29686#discussion_r1617205722)
Unfortunately these types of descriptions pretty much break `help2man`'s detection algorithms, see images in initial post.

💬 willcl-ark commented on pull request "Update manpage descriptions":
(https://github.com/bitcoin/bitcoin/pull/29686#discussion_r1617204105)
IMO the former provides more information (that unused params aren't needed)

💬 willcl-ark commented on pull request "Update manpage descriptions":
(https://github.com/bitcoin/bitcoin/pull/29686#discussion_r1617249137)
fixed in 61e73920d8

💬 willcl-ark commented on pull request "Update manpage descriptions":
(https://github.com/bitcoin/bitcoin/pull/29686#discussion_r1617250283)
Taken in 61e73920d8

💬 willcl-ark commented on pull request "Update manpage descriptions":
(https://github.com/bitcoin/bitcoin/pull/29686#discussion_r1617249793)
I think it's helpful to detail the only command.

💬 Sjors commented on issue "Pause IBD during AssumeUTXO snapshot load":
(https://github.com/bitcoin/bitcoin/issues/29993#issuecomment-2135225915)
I loaded a mainnet snapshot today with a pruned node with limited --dbcache=10000 on a 2019 MacBook Pro. This time I had the node sync for about an hour before loading the snapshot.

At some point the log says:

```
2024-05-28T12:38:11Z Cache size (10375257872) exceeds total space (10370521497)
2024-05-28T12:38:11Z FlushSnapshotToDisk: flushing coins cache (10375 MB) started
```

This flush took 50 minutes, while the chain synced from 392,803 to 417,312. It then continues loading coins
...

💬 fanquake commented on pull request "build: LLD based macOS toolchain":
(https://github.com/bitcoin/bitcoin/pull/21778#issuecomment-2135247127)
Did a Guix build form `arm64-apple-darwin` using emulated `riscv64-linux` on `x86_64`, and the results match the `x86_64` and `aarch64` builds:
```bash
6377bf759602fb5dc00d7992b126ddc75cf03d71ce259c76c509299dac51be52 guix-build-e8c25e8a35e3/output/arm64-apple-darwin/SHA256SUMS.part
7191d5a512ac9b7e934e771985eb2743180a00285b3e5275de1ffdc1e504e68e guix-build-e8c25e8a35e3/output/arm64-apple-darwin/bitcoin-e8c25e8a35e3-arm64-apple-darwin-unsigned.tar.gz
73516bfd8acb17f865b53e67e421dccfd0644c65
...

💬 vasild commented on pull request "init: fixes file descriptor accounting":
(https://github.com/bitcoin/bitcoin/pull/30065#discussion_r1617313586)
Ok, no strong opinion whether to include or exclude `MAX_ADDNODE_CONNECTIONS` in `min_required_fds`.

I guess better to update the check. It is funny to have code like

```
min_required = ...;
if (available < 10) error
```
it should really be
```
min_required = ...;
if (available < min_required) error
```

💬 vasild commented on pull request "init: fixes file descriptor accounting":
(https://github.com/bitcoin/bitcoin/pull/30065#discussion_r1617318967)
ACK to rename `nFD` (maybe as part of 2f49fa0e761ee67d6eeb424b157689f479da8b2c `init: improves file descriptors accounting and docs`)

👍 vasild approved a pull request: "init: fixes file descriptor accounting"
(https://github.com/bitcoin/bitcoin/pull/30065#pullrequestreview-2082925812)
ACK fa42bf7ee89999b33d4af0600b0d8da1275e5d5e

This is already an improvement over `master`. Would be nice to resolve https://github.com/bitcoin/bitcoin/pull/30065#discussion_r1613422626 as well.

💬 edilmedeiros commented on pull request "Update manpage descriptions":
(https://github.com/bitcoin/bitcoin/pull/29686#discussion_r1617333033)
What about

```suggestion
"The -named option allows specifying parameters using key=value style, and therefore doesn't require passing unused params.\n"
```

Starting with the verb seem to be an odd style compared to all the other strings this PR touches.

💬 Sjors commented on pull request "net: Replace libnatpmp with built-in PCP+NATPMP implementation":
(https://github.com/bitcoin/bitcoin/pull/30043#issuecomment-2135407342)
No idea. [OPNsense](https://opnsense.org/about/about-opnsense/) is built on FreeBSD and I think the plugins just rely on whatever miniupnpd comes with the OS:

```
# pkg info miniupnpd
miniupnpd-2.3.3_3,1
Name : miniupnpd
Version : 2.3.3_3,1
Installed on : Thu May 2 10:44:17 2024 CEST
Origin : net/miniupnpd
Architecture : FreeBSD:13:amd64
Prefix : /usr/local
Categories : net
Licenses : BSD3CLAUSE
Maintainer : squat@squat.no
WWW
...

💬 luke-jr commented on pull request "doc: Change GiB to GB in release-process.md":
(https://github.com/bitcoin/bitcoin/pull/30171#issuecomment-2135447798)
This is a duplicate of #29678 (without the accompanying code fixes)

👋 Sjors's pull request is ready for review: "validation: assumeutxo params mainnet"
(https://github.com/bitcoin/bitcoin/pull/28553)

💬 stickies-v commented on pull request "Encapsulate warnings in generalized node::Warnings and remove globals":
(https://github.com/bitcoin/bitcoin/pull/30058#issuecomment-2135498664)
Force-pushed to address @TheCharlatan's (cosmetic) feedback: incorporated the clang-format-diff suggestions and removed a couple of unnecessary includes.

📝 fanquake opened a pull request: "[25.x] windeploy: Renew certificate"
(https://github.com/bitcoin/bitcoin/pull/30184)
Github-Pull: #30149
Rebased-From: 9f4ff1e9659597307f62510f1885ad8da3a1d9a3

💬 fanquake commented on pull request "contrib: Renew Windows code signing certificate":
(https://github.com/bitcoin/bitcoin/pull/30149#issuecomment-2135505873)
Backported to 25.x in #30184.

💬 sr-gi commented on pull request "init: fixes file descriptor accounting":
(https://github.com/bitcoin/bitcoin/pull/30065#discussion_r1617508249)
Updated

💬 vasild commented on pull request "net: Replace libnatpmp with built-in PCP+NATPMP implementation":
(https://github.com/bitcoin/bitcoin/pull/30043#discussion_r1617509629)
13.2 is from April 2023: https://www.freebsd.org/releases/13.2R/announce/
On FreeBSD it is easy and smooth to upgrade the OS (at least my experience since FreeBSD 4.x) even across major versions (e.g. 13 -> 14). Seems fine to only support >= 13.2.

💬 sr-gi commented on pull request "init: fixes file descriptor accounting":
(https://github.com/bitcoin/bitcoin/pull/30065#discussion_r1617510788)
I've fixed that, plus increased the `min_required_fds` to also account for automatic outbounds in the last commit. I'm open to discuss about the latter, but I think it's something we should also account for