💬 maflcko commented on issue "make cov fails with lcov-2":
(https://github.com/bitcoin/bitcoin/issues/28468#issuecomment-2129167753)
Ubuntu support for 23.04 ended, so with vanilla Ubuntu, the only way to go back to lcov-1 is to use 22.04 LTS.

Not sure about which devs use Ubuntu and lcov, but it seems plausible that more are using 24.04 LTS, than 22.04 LTS, so it could make sense to switch to lcov-2 going forward?

⚠️ maflcko reopened an issue: "make cov fails with lcov-2"
(https://github.com/bitcoin/bitcoin/issues/28468)
### Is there an existing issue for this?

- [X] I have searched the existing issues

### Current behaviour

```
# make cov
/usr/bin/lcov --gcov-tool /bitcoin-core/cov_tool_wrapper.sh -c -i -d /bitcoin-core/src -o baseline.info
Can't locate lcovutil.pm in @INC (you may need to install the lcovutil module) (@INC contains: /usr/local/lib/lcov /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.36.0 /usr/local/share/perl/5.36.0 /usr/lib/x86_64-linux-gnu/perl5/5.36 /usr/share/perl5 /usr/lib/x86_64-l
...

💬 maflcko commented on pull request "fuzz: More accurate coverage reports":
(https://github.com/bitcoin/bitcoin/pull/30156#issuecomment-2129174452)
> process_messages

* (this pull) https://drahtbot.space/host_reports/DrahtBot/reports/coverage_fuzz/monotree/949abebea0059edd/6caaca83f0255df0/fuzz.coverage/index.html
* (master) ... running ...

💬 maflcko commented on pull request "ci: add markdown link check job":
(https://github.com/bitcoin/bitcoin/pull/30034#discussion_r1613241901)
up to you, because this is just a style nit. I'll re-ACK, if you do.

💬 dergoegge commented on pull request "fuzz: More accurate coverage reports":
(https://github.com/bitcoin/bitcoin/pull/30156#issuecomment-2129180227)
As an example for the minisketch harness, files reported as reached by the fuzzer:

master:

```
src/coins.h
src/common/args.cpp
src/common/system.cpp
src/compat/byteswap.h
src/compat/endian.h
src/crypto/chacha20.cpp
src/crypto/chacha20.h
src/crypto/common.h
src/crypto/sha256.cpp
src/crypto/sha512.cpp
src/crypto/sha512.h
src/crypto/siphash.cpp
src/cuckoocache.h
src/hash.cpp
src/hash.h
src/logging.cpp
src/logging.h
src/minisketch/include/minisketch.h
src/minisketch/src/fiel
...

🚀 glozow merged a pull request: "[26.x] archive 26.1 release notes + backports"
(https://github.com/bitcoin/bitcoin/pull/29899)

💬 pablomartin4btc commented on pull request "Bugfix on TransactionsView - Disable if privacy mode is set during wallet selection":
(https://github.com/bitcoin-core/gui/pull/815#issuecomment-2129195803)
> This one-line change works without anything else:
>
> [#815 (review)](https://github.com/bitcoin-core/gui/pull/815#pullrequestreview-2072577992)

Sorry, I made another mistake, thanks for double checking.

To other reviewers: please hold on till next push, thanks.

💬 stickies-v commented on pull request "Encapsulate warnings in generalized node::Warnings and remove globals":
(https://github.com/bitcoin/bitcoin/pull/30058#issuecomment-2129201031)
Oops, forgot to update bitcoin-chainstate.cpp again. Force pushed to fix that, and also slightly improved function signatures to use `(kernel::Warning id, const bilingual_str& message)` instead of `(kernel::Warning id, const bilingual_str& warning)`.

📝 fjahr opened a pull request: "doc, rpc: Release notes and follow-ups for #29612"
(https://github.com/bitcoin/bitcoin/pull/30167)
This adds release notes for #29612 and addresses post-merge review comments.

💬 fjahr commented on pull request "rpc: Optimize serialization and enhance metadata of dumptxoutset output":
(https://github.com/bitcoin/bitcoin/pull/29612#discussion_r1613276102)
I addressed this in #30167 using the member field. Using params-serialization wouldn't have made much of a difference given how we use this code right now, I think.

💬 fjahr commented on pull request "rpc: Optimize serialization and enhance metadata of dumptxoutset output":
(https://github.com/bitcoin/bitcoin/pull/29612#discussion_r1613276463)
done in #30167

💬 fjahr commented on pull request "rpc: Optimize serialization and enhance metadata of dumptxoutset output":
(https://github.com/bitcoin/bitcoin/pull/29612#discussion_r1613276609)
Added a test for this in #30167

💬 fjahr commented on pull request "rpc: Optimize serialization and enhance metadata of dumptxoutset output":
(https://github.com/bitcoin/bitcoin/pull/29612#issuecomment-2129225055)
Added release notes and dddressed post-merge comments in #30167

💬 pablomartin4btc commented on pull request "Bugfix on TransactionsView - Disable if privacy mode is set during wallet selection":
(https://github.com/bitcoin-core/gui/pull/815#discussion_r1613302049)
Sorry, that was because `setWalletActionsEnabled` was not working properly, and `setWalletActionsEnabled` was not working because I misread your suggestion and I was still calling the function `enableHistoryAction` incorrectly instead of just using directly `historyAction->setEnabled`. It fixed now in 260d6eb. Thanks!

💬 willcl-ark commented on pull request "ci: add markdown link check job":
(https://github.com/bitcoin/bitcoin/pull/30034#discussion_r1613305686)
Removed in 4b7d9842691046b01f0c08d69f924ddb62ccc4c6

💬 pablomartin4btc commented on pull request "Bugfix on TransactionsView - Disable if privacy mode is set during wallet selection":
(https://github.com/bitcoin-core/gui/pull/815#issuecomment-2129275595)
Updates:
- Incorporated @luke-jr's [suggestion](https://github.com/bitcoin-core/gui/pull/815#issuecomment-2127782169), simplifying the fix.

👍 maflcko approved a pull request: "doc, rpc: Release notes and follow-ups for #29612"
(https://github.com/bitcoin/bitcoin/pull/30167#pullrequestreview-2076606115)
lgtm, apart from the assert

💬 maflcko commented on pull request "doc, rpc: Release notes and follow-ups for #29612":
(https://github.com/bitcoin/bitcoin/pull/30167#discussion_r1613303760)
nit: Why not use the prams from chainman? Seems more consistent, because the chainstate is also used from chainman. (Same nit on all other places)

💬 maflcko commented on pull request "doc, rpc: Release notes and follow-ups for #29612":
(https://github.com/bitcoin/bitcoin/pull/30167#discussion_r1613308886)
Not sure about turning an internal logic error in serialization into a node crash. Seems best to remove this line, because `.value()` will already handle the internal logic error correctly by throwing an exception.

💬 maflcko commented on pull request "ci: add markdown link check job":
(https://github.com/bitcoin/bitcoin/pull/30034#issuecomment-2129283769)
re-utACK 4b7d9842691046b01f0c08d69f924ddb62ccc4c6