💬 glozow commented on pull request "policy: bump TX_MAX_STANDARD_VERSION to 3":
(https://github.com/bitcoin/bitcoin/pull/29496#issuecomment-2129072586)
Rebased for #30072

💬 Sjors commented on pull request "net: Replace libnatpmp with built-in PCP+NATPMP implementation":
(https://github.com/bitcoin/bitcoin/pull/30043#discussion_r1613185703)
Oh I think I get it. In `ProcessPCP` (`mapport.cpp`) we call `PCPRequestPortMap` for every IPv6 address we have, as determined by `GetLocalAddresses()`.

Each port map request is made to the default gateway. This is scope-local addresses, see https://github.com/bitcoin/bitcoin/pull/30043#discussion_r1610568498
So unlike with IPv4, where a gateway like 192.168.1.1 is reachable through both network connections, the IPv6 default gateway is only reachable through _one_ connection.

And indeed
...

✅ willcl-ark closed a pull request: "contrib: verify-binaries accept full arch-platform specifier"
(https://github.com/bitcoin/bitcoin/pull/28418)

💬 willcl-ark commented on pull request "contrib: Fixup verify-binaries OS platform parsing":
(https://github.com/bitcoin/bitcoin/pull/30147#issuecomment-2129108419)
Yep I agree this is cleaner and works nicely in my initial manual testing :)

I will do a code review early next week, thanks!

💬 maflcko commented on pull request "ci: add markdown link check job":
(https://github.com/bitcoin/bitcoin/pull/30034#discussion_r1613202166)
nit: Is this needed? The stdlib should pick the correct value, based on your code.

https://doc.rust-lang.org/std/process/struct.Command.html#method.output

🤔 maflcko reviewed a pull request: "ci: add markdown link check job"
(https://github.com/bitcoin/bitcoin/pull/30034#pullrequestreview-2076417748)
re-ACK 838eacec6a5e31c4a7fd6f9c95510e275f27121a

💬 willcl-ark commented on pull request "ci: add markdown link check job":
(https://github.com/bitcoin/bitcoin/pull/30034#discussion_r1613212380)
You're correct. It works fine without. Worth removing now, or should I just do it if I need to retouch again? I'm happy to do either

💬 willcl-ark commented on pull request "Multiprocess bitcoin":
(https://github.com/bitcoin/bitcoin/pull/10102#issuecomment-2129147575)
I noticed some other unexpected behaviour when interacting with `bitcoin-node` from an external process which might be of interest to investigate...

I made a (malformed) call to `MakeWalletLoader`, not including GlobalArgs, which cause the node to shut down whilst it had an open lock on another (default loaded) wallet. This resulted in preventing this wallet from being re-opened again at next startup.

I wonder whether a malformed call to `MakeWalletLoader` should shut down the node at all,
...

💬 maflcko commented on issue "make cov fails with lcov-2":
(https://github.com/bitcoin/bitcoin/issues/28468#issuecomment-2129167753)
Ubuntu support for 23.04 ended, so with vanilla Ubuntu, the only way to go back to lcov-1 is to use 22.04 LTS.

Not sure about which devs use Ubuntu and lcov, but it seems plausible that more are using 24.04 LTS, than 22.04 LTS, so it could make sense to switch to lcov-2 going forward?

⚠️ maflcko reopened an issue: "make cov fails with lcov-2"
(https://github.com/bitcoin/bitcoin/issues/28468)
### Is there an existing issue for this?

- [X] I have searched the existing issues

### Current behaviour

```
# make cov
/usr/bin/lcov --gcov-tool /bitcoin-core/cov_tool_wrapper.sh -c -i -d /bitcoin-core/src -o baseline.info
Can't locate lcovutil.pm in @INC (you may need to install the lcovutil module) (@INC contains: /usr/local/lib/lcov /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.36.0 /usr/local/share/perl/5.36.0 /usr/lib/x86_64-linux-gnu/perl5/5.36 /usr/share/perl5 /usr/lib/x86_64-l
...

💬 maflcko commented on pull request "fuzz: More accurate coverage reports":
(https://github.com/bitcoin/bitcoin/pull/30156#issuecomment-2129174452)
> process_messages

* (this pull) https://drahtbot.space/host_reports/DrahtBot/reports/coverage_fuzz/monotree/949abebea0059edd/6caaca83f0255df0/fuzz.coverage/index.html
* (master) ... running ...

💬 maflcko commented on pull request "ci: add markdown link check job":
(https://github.com/bitcoin/bitcoin/pull/30034#discussion_r1613241901)
up to you, because this is just a style nit. I'll re-ACK, if you do.

💬 dergoegge commented on pull request "fuzz: More accurate coverage reports":
(https://github.com/bitcoin/bitcoin/pull/30156#issuecomment-2129180227)
As an example for the minisketch harness, files reported as reached by the fuzzer:

master:

```
src/coins.h
src/common/args.cpp
src/common/system.cpp
src/compat/byteswap.h
src/compat/endian.h
src/crypto/chacha20.cpp
src/crypto/chacha20.h
src/crypto/common.h
src/crypto/sha256.cpp
src/crypto/sha512.cpp
src/crypto/sha512.h
src/crypto/siphash.cpp
src/cuckoocache.h
src/hash.cpp
src/hash.h
src/logging.cpp
src/logging.h
src/minisketch/include/minisketch.h
src/minisketch/src/fiel
...

🚀 glozow merged a pull request: "[26.x] archive 26.1 release notes + backports"
(https://github.com/bitcoin/bitcoin/pull/29899)

💬 pablomartin4btc commented on pull request "Bugfix on TransactionsView - Disable if privacy mode is set during wallet selection":
(https://github.com/bitcoin-core/gui/pull/815#issuecomment-2129195803)
> This one-line change works without anything else:
>
> [#815 (review)](https://github.com/bitcoin-core/gui/pull/815#pullrequestreview-2072577992)

Sorry, I made another mistake, thanks for double checking.

To other reviewers: please hold on till next push, thanks.

💬 stickies-v commented on pull request "Encapsulate warnings in generalized node::Warnings and remove globals":
(https://github.com/bitcoin/bitcoin/pull/30058#issuecomment-2129201031)
Oops, forgot to update bitcoin-chainstate.cpp again. Force pushed to fix that, and also slightly improved function signatures to use `(kernel::Warning id, const bilingual_str& message)` instead of `(kernel::Warning id, const bilingual_str& warning)`.

📝 fjahr opened a pull request: "doc, rpc: Release notes and follow-ups for #29612"
(https://github.com/bitcoin/bitcoin/pull/30167)
This adds release notes for #29612 and addresses post-merge review comments.

💬 fjahr commented on pull request "rpc: Optimize serialization and enhance metadata of dumptxoutset output":
(https://github.com/bitcoin/bitcoin/pull/29612#discussion_r1613276102)
I addressed this in #30167 using the member field. Using params-serialization wouldn't have made much of a difference given how we use this code right now, I think.

💬 fjahr commented on pull request "rpc: Optimize serialization and enhance metadata of dumptxoutset output":
(https://github.com/bitcoin/bitcoin/pull/29612#discussion_r1613276463)
done in #30167

💬 fjahr commented on pull request "rpc: Optimize serialization and enhance metadata of dumptxoutset output":
(https://github.com/bitcoin/bitcoin/pull/29612#discussion_r1613276609)
Added a test for this in #30167