💬 kristapsk commented on pull request "[PoC] ci: Add FreeBSD GitHub Actions job":
(https://github.com/bitcoin/bitcoin/pull/30164#issuecomment-2128466549)
Concept ACK

💬 jadijadi commented on pull request "Showing Local Addresses in Node Window":
(https://github.com/bitcoin-core/gui/pull/626#issuecomment-2128638490)
> Somehow you introduced a typo in the commit message >_<

Oh.. sorry. fixed and added a spellchecker.

💬 maflcko commented on pull request "[PoC] ci: Add FreeBSD GitHub Actions job":
(https://github.com/bitcoin/bitcoin/pull/30164#issuecomment-2128649877)
> IMPORTANT. The `vmactions/*` needs to be added to the "Actions permissions" section of the repository settings.

Not sure. What was the conclusion when GHA was added to the repo about enabling third party actions? IIRC it was unclear whether malicious or backdoored actions could compromise the repo, so the conclusion was to refrain from enabling them?

No objection to merging this, but I'd say unless it is clear that the repo can not be compromised, the action should not be enabled in thi
...

💬 maflcko commented on issue "LevelDB read failure: Corruption: block checksum mismatch":
(https://github.com/bitcoin/bitcoin/issues/30159#issuecomment-2128657943)
The RPC will take a long time (probably hours), so you'll have to disable the client timeout `-rpcclienttimeout=0`.

```
bitcoin/bin/bitcoin-cli -rpcclienttimeout=0 -rpcwaittimeout=0 -conf=/home/ec2-user/bitcoin.conf gettxoutsetinfo muhash

💬 kcalvinalvin commented on issue "DNS seed "seed.bitcoinstats.com" doesn't support filtering while the comments says it does":
(https://github.com/bitcoin/bitcoin/issues/29911#issuecomment-2128689449)
Just checking in on this. Seemingly nothing's been changed since posting about this back in April

💬 fanquake commented on pull request "build: LLD based macOS toolchain":
(https://github.com/bitcoin/bitcoin/pull/21778#issuecomment-2128712036)
> If it is expected to pass now, I can re-try this.

Quite possible it'll pass now. Given the previous failure was in compiling cctools.

💬 maflcko commented on issue "fuzz: Fix timeouts":
(https://github.com/bitcoin/bitcoin/issues/28812#issuecomment-2128761184)
Looks like there are different flames in `descriptor_parse`. Another one that took two minutes:

[1eab7f1648dd012d8efee262a9898d2a9b044fd2.bin.txt](https://github.com/bitcoin/bitcoin/files/15429349/1eab7f1648dd012d8efee262a9898d2a9b044fd2.bin.txt)

Looks like it is just a long `sh(thresh(1,1,1,1,1,0,1,1,1,1,1,0,1,1,1,1...`.

💬 maflcko commented on pull request "fuzz: More accurate coverage reports":
(https://github.com/bitcoin/bitcoin/pull/30156#discussion_r1612974490)
Can you share the compile error, or which config ran into an issue?

💬 TheCharlatan commented on pull request "indexes: Don't wipe indexes again when continuing a prior reindex":
(https://github.com/bitcoin/bitcoin/pull/30132#issuecomment-2128810392)
Updated dd290b3b58a1f9f9e182803866b8e2b9f72ecb3b -> 891784ce73a1d911d33b125b66f3856fe6cda56b ([preserveIndexOnRestart_2](https://github.com/TheCharlatan/bitcoin/tree/preserveIndexOnRestart_2) -> [preserveIndexOnRestart_3](https://github.com/TheCharlatan/bitcoin/tree/preserveIndexOnRestart_3), [compare](https://github.com/TheCharlatan/bitcoin/compare/preserveIndexOnRestart_2..preserveIndexOnRestart_3))

* Addressed @furszy's [comment](https://github.com/bitcoin/bitcoin/pull/30132#discussion_r16
...

💬 Sjors commented on pull request "net: Replace libnatpmp with built-in PCP+NATPMP implementation":
(https://github.com/bitcoin/bitcoin/pull/30043#discussion_r1613016087)
I'm a bit surprise that when we ask for the default gateway, we get results for both network connections. But I guess we're not asking for the _default_ gateway on macOS, but rather all of them?

💬 maflcko commented on pull request "indexes: Don't wipe indexes again when continuing a prior reindex":
(https://github.com/bitcoin/bitcoin/pull/30132#discussion_r1613029047)
```suggestion

```

nit: Is this needed? IIUC the index will be thrown away in the next line anyway?

💬 maflcko commented on pull request "indexes: Don't wipe indexes again when continuing a prior reindex":
(https://github.com/bitcoin/bitcoin/pull/30132#discussion_r1613028022)
nit: Could force named args for options?
```suggestion
def wait_for_rpc_connection(self, *, wait_for_import=True):
```

👍 willcl-ark approved a pull request: "[26.x] archive 26.1 release notes + backports"
(https://github.com/bitcoin/bitcoin/pull/29899#pullrequestreview-2076143849)
ACK aa7e876953c460e8ff97a719fdb18f4f3ac4896f

Checked that all backports were applied without modifcation where possible

💬 Sjors commented on pull request "net: Replace libnatpmp with built-in PCP+NATPMP implementation":
(https://github.com/bitcoin/bitcoin/pull/30043#issuecomment-2128880081)
Ok, happy with `QueryDefaultGateway(Impl)` as of 9a265c6d75136991125730b8a6a901e95cfeb8f6, except for not compiling on BSD 13.2:

```
util/netif.cpp:84:82: error: use of undeclared identifier 'typeof'; did you mean 'typeid'?
for (nlmsghdr* hdr = (nlmsghdr*)response; NLMSG_OK(hdr, response_len); hdr = NLMSG_NEXT(hdr, response_len)) {
```

It also throws a warning:

```
util/netif.cpp:84:47: warning: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned long')
...

💬 maflcko commented on pull request "fuzz: More accurate coverage reports":
(https://github.com/bitcoin/bitcoin/pull/30156#issuecomment-2128926094)
https://drahtbot.space/host_reports/DrahtBot/reports/coverage_fuzz/monotree/949abebea0059edd/cc5858cb70d9ce14/fuzz.coverage/index.html

💬 dergoegge commented on pull request "fuzz: More accurate coverage reports":
(https://github.com/bitcoin/bitcoin/pull/30156#discussion_r1613100595)
https://cirrus-ci.com/task/6736987506343936:

```
Undefined symbols for architecture x86_64:
"___llvm_profile_reset_counters", referenced from:
initialize() in libtest_fuzz.a(libtest_fuzz_a-fuzz.o)
"___gcov_reset", referenced from:
initialize() in libtest_fuzz.a(libtest_fuzz_a-fuzz.o)
ld: symbol(s) not found for architecture x86_64
```

https://cirrus-ci.com/task/6596250017988608:

```
/usr/bin/ld: libtest_fuzz.a(libtest_fuzz_a-fuzz.o): in function `ResetCoverageCou
...

💬 willcl-ark commented on pull request "Fee Estimation via Fee rate Forecasters":
(https://github.com/bitcoin/bitcoin/pull/30157#issuecomment-2128952313)
> The state of the node's mempool may not accurately reflect the state of others' mempools, and not even its own mempool when the block is found in the future. It isn't a good single source of information.

Correct. The rationale behind this set of changes can be summed up briefly as follows:

- Add a new standalone modular fee estimation manager to which (many) `Forcasters` can be trivially added or removed (vs modifying `BlockPolicyEstimator`).
- Provide two forcaster implementations whic
...

💬 dergoegge commented on pull request "fuzz: More accurate coverage reports":
(https://github.com/bitcoin/bitcoin/pull/30156#issuecomment-2128953200)
> https://drahtbot.space/host_reports/DrahtBot/reports/coverage_fuzz/monotree/949abebea0059edd/cc5858cb70d9ce14/fuzz.coverage/index.html

The difference only really becomes visible for individual coverage reports, e.g. for process_messages.

💬 kosuodhmwa commented on issue "Log: "no wallet support compiled in" when i start bitcoind":
(https://github.com/bitcoin/bitcoin/issues/30158#issuecomment-2128954064)
got it , thank you very much!! :-)

✅ kosuodhmwa closed an issue: "Log: "no wallet support compiled in" when i start bitcoind"
(https://github.com/bitcoin/bitcoin/issues/30158)