💬 hebasto commented on pull request "[PoC] ci: Add FreeBSD GitHub Actions job":
(https://github.com/bitcoin/bitcoin/pull/30164#issuecomment-2128162922)
cc @vasild

💬 luke-jr commented on pull request "Showing Local Addresses in Node Window":
(https://github.com/bitcoin-core/gui/pull/626#issuecomment-2128176766)
Somehow you introduced a typo in the commit message >_<

💬 epiccurious commented on pull request "doc: update mention of generating bitcoin.conf":
(https://github.com/bitcoin/bitcoin/pull/30154#issuecomment-2128181002)
> squash this into a single commit and update the PR description

Squashed into 9013e2b97e8f50d2be63ce740c42d0b0e0b9b7f2 and updated PR description.

💬 apulsifer commented on issue "LevelDB read failure: Corruption: block checksum mismatch":
(https://github.com/bitcoin/bitcoin/issues/30159#issuecomment-2128231134)
Yes, all the checksum errors are in numerically-named NNNNNN.ldb files in /bdata/bitcoin-data/chainstate/

I had no luck with gettxoutsetinfo muhash:

bitcoin/bin/bitcoin-cli -rpcwaittimeout=0 -conf=/home/ec2-user/bitcoin.conf getblockcount
844826

bitcoin/bin/bitcoin-cli -rpcwaittimeout=0 -conf=/home/ec2-user/bitcoin.conf gettxoutsetinfo muhash
error: timeout on transient error: Could not connect to the server 127.0.0.1:8332 (error code 0 - "timeout reached")

💬 ajtowns commented on pull request "contrib/signet/miner: increase miner search space":
(https://github.com/bitcoin/bitcoin/pull/30130#discussion_r1612527980)
I think you also would want to change:

```
if tmpl["mintime"] > mine_time:
logging.info("Updating block time from %d to %d", mine_time, tmpl["mintime"])
mine_time = tmpl["mintime"]
```

to be

```
mintime = tmpl["mintime"] + retries
if mine_time < mintime:
logging.info(...)
mine_time = mintime
```

💬 edilmedeiros commented on pull request "doc: update mention of generating bitcoin.conf":
(https://github.com/bitcoin/bitcoin/pull/30154#issuecomment-2128296962)
ACK 9013e2b97e8f50d2be63ce740c42d0b0e0b9b7f2

⚠️ lcharles123 opened an issue: ""netinfo" doesn't show IPv6 "Local addresses""
(https://github.com/bitcoin/bitcoin/issues/30165)
### Is there an existing issue for this?

- [X] I have searched the existing issues

### Current behaviour

"Local addresses" section of "netinfo" does not show the IPv6 addresses added using "externalip" config option. (Probably there is no announce of this addresses).
(These are not my real addresses).

root@debianpc:~# bitcoin-cli -netinfo
` Bitcoin Core client v27.0.0 - server 70016/Satoshi:27.0.0/

ipv4 onion i2p npr total block
in 0 1
...

💬 jonatack commented on issue ""netinfo" doesn't show IPv6 "Local addresses"":
(https://github.com/bitcoin/bitcoin/issues/30165#issuecomment-2128360266)
Thank you for highlighting this. This is an edge case that I've been meaning to open a fix for since a long time, along with a couple other ones. I'll do that shortly.

💬 jonatack commented on issue ""netinfo" doesn't show IPv6 "Local addresses"":
(https://github.com/bitcoin/bitcoin/issues/30165#issuecomment-2128362673)
Can you post the result of running `./src/bitcoin-cli getnetworkinfo` on your machine (with modified IPs)

💬 lcharles123 commented on issue ""netinfo" doesn't show IPv6 "Local addresses"":
(https://github.com/bitcoin/bitcoin/issues/30165#issuecomment-2128367476)
root@debianpc:~# bcli getnetworkinfo
{
"version": 270000,
"subversion": "/Satoshi:27.0.0/",
"protocolversion": 70016,
"localservices": "0000000000000c09",
"localservicesnames": [
"NETWORK",
"WITNESS",
"NETWORK_LIMITED",
"P2P_V2"
],
"localrelay": true,
"timeoffset": -8,
"networkactive": true,
"connections": 68,
"connections_in": 58,
"connections_out": 10,
"networks": [
{
"name": "ipv4",
"limited": false,
"reacha
...

💬 kristapsk commented on pull request "[PoC] ci: Add FreeBSD GitHub Actions job":
(https://github.com/bitcoin/bitcoin/pull/30164#issuecomment-2128466549)
Concept ACK

💬 jadijadi commented on pull request "Showing Local Addresses in Node Window":
(https://github.com/bitcoin-core/gui/pull/626#issuecomment-2128638490)
> Somehow you introduced a typo in the commit message >_<

Oh.. sorry. fixed and added a spellchecker.

💬 maflcko commented on pull request "[PoC] ci: Add FreeBSD GitHub Actions job":
(https://github.com/bitcoin/bitcoin/pull/30164#issuecomment-2128649877)
> IMPORTANT. The `vmactions/*` needs to be added to the "Actions permissions" section of the repository settings.

Not sure. What was the conclusion when GHA was added to the repo about enabling third party actions? IIRC it was unclear whether malicious or backdoored actions could compromise the repo, so the conclusion was to refrain from enabling them?

No objection to merging this, but I'd say unless it is clear that the repo can not be compromised, the action should not be enabled in thi
...

💬 maflcko commented on issue "LevelDB read failure: Corruption: block checksum mismatch":
(https://github.com/bitcoin/bitcoin/issues/30159#issuecomment-2128657943)
The RPC will take a long time (probably hours), so you'll have to disable the client timeout `-rpcclienttimeout=0`.

```
bitcoin/bin/bitcoin-cli -rpcclienttimeout=0 -rpcwaittimeout=0 -conf=/home/ec2-user/bitcoin.conf gettxoutsetinfo muhash

💬 kcalvinalvin commented on issue "DNS seed "seed.bitcoinstats.com" doesn't support filtering while the comments says it does":
(https://github.com/bitcoin/bitcoin/issues/29911#issuecomment-2128689449)
Just checking in on this. Seemingly nothing's been changed since posting about this back in April

💬 fanquake commented on pull request "build: LLD based macOS toolchain":
(https://github.com/bitcoin/bitcoin/pull/21778#issuecomment-2128712036)
> If it is expected to pass now, I can re-try this.

Quite possible it'll pass now. Given the previous failure was in compiling cctools.

💬 maflcko commented on issue "fuzz: Fix timeouts":
(https://github.com/bitcoin/bitcoin/issues/28812#issuecomment-2128761184)
Looks like there are different flames in `descriptor_parse`. Another one that took two minutes:

[1eab7f1648dd012d8efee262a9898d2a9b044fd2.bin.txt](https://github.com/bitcoin/bitcoin/files/15429349/1eab7f1648dd012d8efee262a9898d2a9b044fd2.bin.txt)

Looks like it is just a long `sh(thresh(1,1,1,1,1,0,1,1,1,1,1,0,1,1,1,1...`.

💬 maflcko commented on pull request "fuzz: More accurate coverage reports":
(https://github.com/bitcoin/bitcoin/pull/30156#discussion_r1612974490)
Can you share the compile error, or which config ran into an issue?

💬 TheCharlatan commented on pull request "indexes: Don't wipe indexes again when continuing a prior reindex":
(https://github.com/bitcoin/bitcoin/pull/30132#issuecomment-2128810392)
Updated dd290b3b58a1f9f9e182803866b8e2b9f72ecb3b -> 891784ce73a1d911d33b125b66f3856fe6cda56b ([preserveIndexOnRestart_2](https://github.com/TheCharlatan/bitcoin/tree/preserveIndexOnRestart_2) -> [preserveIndexOnRestart_3](https://github.com/TheCharlatan/bitcoin/tree/preserveIndexOnRestart_3), [compare](https://github.com/TheCharlatan/bitcoin/compare/preserveIndexOnRestart_2..preserveIndexOnRestart_3))

* Addressed @furszy's [comment](https://github.com/bitcoin/bitcoin/pull/30132#discussion_r16
...

💬 Sjors commented on pull request "net: Replace libnatpmp with built-in PCP+NATPMP implementation":
(https://github.com/bitcoin/bitcoin/pull/30043#discussion_r1613016087)
I'm a bit surprise that when we ask for the default gateway, we get results for both network connections. But I guess we're not asking for the _default_ gateway on macOS, but rather all of them?