💬 fanquake commented on pull request "test: fix intermittent issue in `feature_bip68_sequence`":
(https://github.com/bitcoin/bitcoin/pull/27177#issuecomment-1487030103)
@brunoerg are you following up here?

💬 MarcoFalke commented on issue "index: ThreadSanitizer: data race on vptr ":
(https://github.com/bitcoin/bitcoin/issues/27355#issuecomment-1487049094)
Reproducible? If yes, what are the steps to reproduce?

💬 fanquake commented on issue "index: ThreadSanitizer: data race on vptr ":
(https://github.com/bitcoin/bitcoin/issues/27355#issuecomment-1487053086)
> Reproducible

100%. Running `time FILE_ENV="./ci/test/00_setup_env_native_tsan.sh" ./ci/test_run_all.sh` on a aarch64 machine running Fedora 37.

💬 pinheadmz commented on pull request "system: allow GUI to initialize default data dir":
(https://github.com/bitcoin/bitcoin/pull/27273#issuecomment-1487075138)
Closing for now, `strDataDir` is a bit annoying and we should consider getting rid of it.

✅ pinheadmz closed a pull request: "system: allow GUI to initialize default data dir"
(https://github.com/bitcoin/bitcoin/pull/27273)

⚠️ CQuerini247 opened an issue: "Bitcoin"
(https://github.com/bitcoin/bitcoin/issues/27356)
When I put money into Bitcoin and there's tabs with more money than I get back what do I do?

💬 theStack commented on pull request "test: use address_to_scriptpubkey instead of RPC call":
(https://github.com/bitcoin/bitcoin/pull/27349#discussion_r1150776577)
stylistic nit: we usually keep two blank lines after imports, so should rather add another one than remove one here (see also https://peps.python.org/pep-0008/#blank-lines).

✅ fanquake closed an issue: "Bitcoin"
(https://github.com/bitcoin/bitcoin/issues/27356)

:lock: fanquake locked an issue: "Bitcoin"
(https://github.com/bitcoin/bitcoin/issues/27356)

💬 brunoerg commented on pull request "test: fix intermittent issue in `feature_bip68_sequence`":
(https://github.com/bitcoin/bitcoin/pull/27177#issuecomment-1487160825)
> @brunoerg are you following up here?

Yes.

💬 ismaelsadeeq commented on pull request "test: use address_to_scriptpubkey instead of RPC call":
(https://github.com/bitcoin/bitcoin/pull/27349#discussion_r1150828780)
Thanks :100:

💬 josibake commented on pull request "test: use address_to_scriptpubkey instead of RPC call":
(https://github.com/bitcoin/bitcoin/pull/27349#issuecomment-1487203381)
re-ACK https://github.com/bitcoin/bitcoin/pull/27349/commits/e47ce42f670fc43859c157766b342509ab5916f9

👍 theStack approved a pull request: "test: use address_to_scriptpubkey instead of RPC call"
(https://github.com/bitcoin/bitcoin/pull/27349)
ACK e47ce42f670fc43859c157766b342509ab5916f9 🌱

💬 josibake commented on pull request "test: fix intermittent issue in `feature_bip68_sequence`":
(https://github.com/bitcoin/bitcoin/pull/27177#issuecomment-1487242654)
Concept ACK

Regarding the approach, I think we should always apply the filter or allow the argument but have it default to True and only let you change it to false if you are calling `get_utxo` directly (no argument forwarding).

I'm also a little confused by the `mempool_package_limit.py`, because it looks like the test assumes it is already working with mature UTXOs:

https://github.com/bitcoin/bitcoin/blob/master/test/functional/mempool_package_limits.py#L26-L29

Using immature UTXO
...

💬 furszy commented on pull request "refactor: Remove CAddressBookData::destdata":
(https://github.com/bitcoin/bitcoin/pull/27224#issuecomment-1487314169)
> @furszy, thanks for the thorough review. I will start implementing your suggestions, but do you think you could help me with your comments about encapsulation like [#27224 (comment)](https://github.com/bitcoin/bitcoin/pull/27224#discussion_r1150541159)?
>
> For background, I've been a little detached from the address encapsulation attempt, and personally like m_address_book.find(dest) / m_addressbook[dest] lookups and for loops a little better than calling FindAddress/FindOrInsertAddress/Fo
...

💬 brunoerg commented on pull request "p2p: Allow whitelisting outgoing connections":
(https://github.com/bitcoin/bitcoin/pull/27114#issuecomment-1487331264)
Rebased

💬 pinheadmz commented on pull request "Support JSON-RPC 2.0 when requested by client":
(https://github.com/bitcoin/bitcoin/pull/27101#issuecomment-1487397883)
Added a scripted-diff to completely replace all occurrences of the application-defined `RPC_INVALID_PARAMETER` (-8) with the JSONRPC 2.0 spec-defined `RPC_INVALID_PARAMS` (-32602)

💬 pinheadmz commented on issue "Export a watch wallet only (with descriptors and without private keys) for an air gap setup":
(https://github.com/bitcoin/bitcoin/issues/24829#issuecomment-1487425971)
I was able to do what you want to do with a few bash commands (see below).

I suppose we could add arguments `-file <path/to/file>` to both `listdescriptors` and `importdescriptors` that would make this even easier...?


```sh
$ bccli -regtest createwallet original
{
"name": "original",
"warning": ""
}

$ bccli -regtest listdescriptors | jq .descriptors -c >> ~/Desktop/watchonly.json
$ bccli -regtest -named createwallet wallet_name=watchonly disable_private_keys=true
{
"name
...

💬 willcl-ark commented on pull request "build, qt: Fix handling of `CXX=clang++` when building `qt` package":
(https://github.com/bitcoin/bitcoin/pull/27314#issuecomment-1487431386)
Can confirm this works on clang-16 (now that #27301 is also in) for me:

```
$ make -j16 qt CC=clang CXX=clang++
<snip>
Postprocessing qt...
Caching qt...

$ clang --version
Ubuntu clang version 16.0.0 (++20230315113536+8f3cb98d1fab-1~exp1~20230315113641.56)
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/bin
```

💬 pinheadmz commented on issue "Adding interprocess onion access instead local ip":
(https://github.com/bitcoin/bitcoin/issues/27252#issuecomment-1487455451)
This is at least partially a duplicate of https://github.com/bitcoin/bitcoin/issues/5029 with preliminary work done in https://github.com/bitcoin/bitcoin/pull/9979 and https://github.com/bitcoin/bitcoin/pull/9919

However it sounds like your use case is a bit narrower? This isn't about RPC or tor hidden service or P2P connections, just tor proxy?