🤔 AngusP reviewed a pull request: "contrib/signet/miner: increase miner search space"
(https://github.com/bitcoin/bitcoin/pull/30130#pullrequestreview-2069607288)
LGTM apart from style nit

💬 AngusP commented on pull request "contrib/signet/miner: increase miner search space":
(https://github.com/bitcoin/bitcoin/pull/30130#discussion_r1608941385)
```suggestion
logging.debug("grinder exhausted the nonce search space, retrying with new block header")
```

💬 AngusP commented on pull request "contrib/signet/miner: increase miner search space":
(https://github.com/bitcoin/bitcoin/pull/30130#discussion_r1608941525)
```suggestion
logging.debug("mining aborted by the user")
```

💬 theuni commented on pull request "cli: restrict multiple exclusive argument usage in bitcoin-cli":
(https://github.com/bitcoin/bitcoin/pull/30148#issuecomment-2123435878)
Concept ACK.

This is very close to @Brotcrunsher's original commit. At the very least they should be a co-author.

💬 theuni commented on pull request "kernel: De-globalize validation caches":
(https://github.com/bitcoin/bitcoin/pull/30141#discussion_r1608951984)
Comment is now out of date.

💬 TheCharlatan commented on pull request "kernel: De-globalize validation caches":
(https://github.com/bitcoin/bitcoin/pull/30141#issuecomment-2123462834)
Updated 4a1df97a016935348e50f384ed52a6671990835f -> 5b1576bbc664a07e00b5528e13c1928df9bc9b0c ([noGlobalScriptCache_1](https://github.com/TheCharlatan/bitcoin/tree/noGlobalScriptCache_1) -> [noGlobalScriptCache_2](https://github.com/TheCharlatan/bitcoin/tree/noGlobalScriptCache_2), [compare](https://github.com/TheCharlatan/bitcoin/compare/noGlobalScriptCache_1..noGlobalScriptCache_2))

* Addressed @theuni's [comment](https://github.com/bitcoin/bitcoin/pull/30141#discussion_r1608951984), fixed o
...

💬 TheCharlatan commented on pull request "kernel: De-globalize validation caches":
(https://github.com/bitcoin/bitcoin/pull/30141#discussion_r1608966851)
Thanks, fixed.

💬 brunoerg commented on pull request "net: add ASMap info in `getrawaddrman` RPC":
(https://github.com/bitcoin/bitcoin/pull/30062#discussion_r1608973068)
I agree, will address it.

💬 brunoerg commented on pull request "net: add ASMap info in `getrawaddrman` RPC":
(https://github.com/bitcoin/bitcoin/pull/30062#discussion_r1608973314)
I agree, I will address it.

💬 hernanmarino commented on pull request "Correct tooltip wording for watch-only wallets":
(https://github.com/bitcoin-core/gui/pull/792#issuecomment-2123499470)
> @hernanmarino
>
> Are you still working on this?

I am active, and I'll resume working on this PR and upload a proposal soon.

💬 theStack commented on pull request "rpc: Optimize serialization and enhance metadata of dumptxoutset output":
(https://github.com/bitcoin/bitcoin/pull/29612#discussion_r1608997512)
nit: would still prefer `last_txid` over `last_hash` as it's more expressive (OTOH, in `COutPoint`, it's also called `hash`)

👍 theStack approved a pull request: "rpc: Optimize serialization and enhance metadata of dumptxoutset output"
(https://github.com/bitcoin/bitcoin/pull/29612#pullrequestreview-2069701481)
ACK 542e13b2937356810bda2c41be83c3b1675e2f2f

👋 LarryRuane's pull request is ready for review: "improve MallocUsage() accuracy"
(https://github.com/bitcoin/bitcoin/pull/28531)

💬 kevkevinpal commented on pull request "test: create assert_not_equal util":
(https://github.com/bitcoin/bitcoin/pull/29500#discussion_r1609088929)
not sure why it is doing that I will check the script to see why

💬 kevkevinpal commented on pull request "test: create assert_not_equal util":
(https://github.com/bitcoin/bitcoin/pull/29500#discussion_r1609089600)
that is strange I would think that the 3rd arg would make the tests fail in this case

💬 kevkevinpal commented on pull request "test: create assert_not_equal util":
(https://github.com/bitcoin/bitcoin/pull/29500#issuecomment-2123638147)
> @kevkevinpal Did you use a tool to generate the verification script?

No I did not I just manually used `git grep` and `sed` to create the script

💬 kevkevinpal commented on pull request "test: create assert_not_equal util":
(https://github.com/bitcoin/bitcoin/pull/29500#issuecomment-2123662957)
rebased to [7f7dc43](https://github.com/bitcoin/bitcoin/pull/29500/commits/7f7dc439c7d268e63eddddf3cea21c2931895078)

💬 kevkevinpal commented on pull request "test: create assert_not_equal util":
(https://github.com/bitcoin/bitcoin/pull/29500#discussion_r1609112805)
Yes that would not make sense let me see if I can improve the logging here

💬 kristapsk commented on pull request "cli: restrict multiple exclusive argument usage in bitcoin-cli":
(https://github.com/bitcoin/bitcoin/pull/30148#issuecomment-2123674336)
Concept ACK

💬 edilmedeiros commented on pull request "contrib/signet/miner: increase miner search space":
(https://github.com/bitcoin/bitcoin/pull/30130#issuecomment-2123743474)
Fair enough, committed the style suggestions.