💬 hebasto commented on pull request "build: Enable `thread_local` for MinGW-w64 builds":
(https://github.com/bitcoin/bitcoin/pull/30099#issuecomment-2122373765)
Rebased on top of the merged #30095.

💬 vasild commented on pull request "Broadcast own transactions only via short-lived Tor or I2P connections":
(https://github.com/bitcoin/bitcoin/pull/29415#discussion_r1608129277)
A few considerations:

* Private broadcast connections are not blocked on the `semOutbound` grant. They come to this code right away.

* Even if there is a high demand for private broadcast connections, we would try to open such ones only half of the time in `CConnman::ThreadOpenConnections()` to avoid such starvation of only opening private broadcast and not others for a long time (see how `MaybePickPrivateBroadcastNetwork()` yields to other connection types if we previously opened a privat
...

💬 laanwj commented on pull request "build: Remove `--enable-threadlocal`":
(https://github.com/bitcoin/bitcoin/pull/30137#issuecomment-2122380476)
Code review ACK 17fe948cce2eb75f0f3f4b0db9d0d90648c7d4af
This removes, to my knowledge, all mentions of thread-local in the build system or comments.
Will test the guix binary on windows.

💬 hebasto commented on pull request "build: Enable `thread_local` for MinGW-w64 builds":
(https://github.com/bitcoin/bitcoin/pull/30099#issuecomment-2122388233)
Closing in favour of https://github.com/bitcoin/bitcoin/pull/30137.

✅ hebasto closed a pull request: "build: Enable `thread_local` for MinGW-w64 builds"
(https://github.com/bitcoin/bitcoin/pull/30099)

👋 fanquake's pull request is ready for review: "build: Remove `--enable-threadlocal`"
(https://github.com/bitcoin/bitcoin/pull/30137)

💬 maflcko commented on pull request "util: avoid using thread_local variable that has a destructor":
(https://github.com/bitcoin/bitcoin/pull/30095#discussion_r1608138344)
So when the minimum freeBSD is 15.0, this workaround can be reverted? It would be good to clarify this in the source code.

⚠️ BenWestgate opened an issue: "contrib/verify-binaries/verify.py incorrectly parses version strings with more than 2 dashes"
(https://github.com/bitcoin/bitcoin/issues/30145)
### Is there an existing issue for this?

- [X] I have searched the existing issues

### Current behaviour

When I run:
`./verify.py pub 27.0-x86_64-linux-gnu` instead of downloading the version I told it, it downloads every version in the SHA256SUMS file starting with the first.

The `version_os` and (also `version_rc`) are completely ignored.

When I attempt to work around and give it a 1 dash `version_os` string such as
`./verify.py pub 27.0-x86_64` it will start with bitcoin-27.0-x86_6
...

💬 BenWestgate commented on issue "contrib/verify-binaries/verify.py incorrectly parses version strings with more than 2 dashes":
(https://github.com/bitcoin/bitcoin/issues/30145#issuecomment-2122420660)
I would like to be assigned to this issue and will send a PR in an hour.

💬 vasild commented on pull request "Broadcast own transactions only via short-lived Tor or I2P connections":
(https://github.com/bitcoin/bitcoin/pull/29415#discussion_r1608172001)
Added this sentence: "We try to open a connection of this type only if there are transactions pending, but up to a limit."

💬 cbergqvist commented on pull request "ci: Add mising -Wno-error=maybe-uninitialized to armhf task":
(https://github.com/bitcoin/bitcoin/pull/30144#discussion_r1608172657)
Good to see. Might be worth adding a comment about why the warning is disabled here and in `ci/test/00_setup_env_win64.sh`?

💬 vasild commented on pull request "Broadcast own transactions only via short-lived Tor or I2P connections":
(https://github.com/bitcoin/bitcoin/pull/29415#discussion_r1608174270)
Removed.

💬 vasild commented on pull request "Broadcast own transactions only via short-lived Tor or I2P connections":
(https://github.com/bitcoin/bitcoin/pull/29415#discussion_r1608176500)
Done

💬 sipa commented on pull request "net: Replace libnatpmp with built-in PCP implementation":
(https://github.com/bitcoin/bitcoin/pull/30043#issuecomment-2122446973)
@laanwj This is a router provided by Verizon (a large US ISP) in 2021.

💬 vasild commented on pull request "Broadcast own transactions only via short-lived Tor or I2P connections":
(https://github.com/bitcoin/bitcoin/pull/29415#discussion_r1608179155)
Added "A list of transactions to be broadcast privately."

💬 vasild commented on pull request "Broadcast own transactions only via short-lived Tor or I2P connections":
(https://github.com/bitcoin/bitcoin/pull/29415#discussion_r1608182222)
"due to" = "because of" = "because there is a new transaction for broadcast - txid=...". I am open to suggestions for better wording.

💬 vasild commented on pull request "Broadcast own transactions only via short-lived Tor or I2P connections":
(https://github.com/bitcoin/bitcoin/pull/29415#discussion_r1608191485)
Right! Moved to the corresponding commits.

💬 vasild commented on pull request "Broadcast own transactions only via short-lived Tor or I2P connections":
(https://github.com/bitcoin/bitcoin/pull/29415#discussion_r1608192497)
Some of the code was written in 2023

💬 vasild commented on pull request "Broadcast own transactions only via short-lived Tor or I2P connections":
(https://github.com/bitcoin/bitcoin/pull/29415#discussion_r1608193117)
Same, some of the code was written in 2023

💬 vasild commented on pull request "Broadcast own transactions only via short-lived Tor or I2P connections":
(https://github.com/bitcoin/bitcoin/pull/29415#discussion_r1608200672)
I prefixed everything with `my_` or `your_` because otherwise it is unclear whether it is mine or yours. Deducting that without my/yours prefix requires an extra effort.