💬 brunoerg commented on pull request "p2p: Fill reconciliation sets (Erlay) attempt 2":
(https://github.com/bitcoin/bitcoin/pull/30116#discussion_r1602304001)
In "p2p: Functions to add/remove wtxids to tx reconciliation sets" https://github.com/bitcoin/bitcoin/commit/7c047d30cb0eadc8a424cb01de2fcd0978e22206: Perhaps adding a log when removing from set?

💬 kevkevinpal commented on pull request "test: Added test to ensure log and failure happen when work is less than active chainstate":
(https://github.com/bitcoin/bitcoin/pull/30105#discussion_r1602311815)
Thanks for the review!

I think the timeout should be fine there is even a comment pointing out that we check the work twice because we want to fail fast
https://github.com/bitcoin/bitcoin/blob/master/src/validation.cpp#L5655-L5657

💬 1ma commented on issue "contrib/signet/miner: grind will fail for high difficulty chain":
(https://github.com/bitcoin/bitcoin/issues/30102#issuecomment-2113592794)
Can reproduce. Been running a signet network whose miner stalled a few dozens of blocks after the block 10080 difficulty adjustment.

The miner is ran as a systemd service like this, and the nbits parameter was determined by using the calibrating utility set to 600s. Despite this, before block 10080 the miner used to mine a block every 2.5 min instead of 10. I don't quite understand how it works, honestly.

```shell
miner --cli="bitcoin-cli" generate --address $rewards_addy --grind-cmd="bit
...

✅ fanquake closed an issue: "Compilation failure with `-O0` + `-fsanitize=address` due to inline asm"
(https://github.com/bitcoin/bitcoin/issues/29801)

🚀 fanquake merged a pull request: "crypto: disable asan for sha256_sse4 with clang and -O0"
(https://github.com/bitcoin/bitcoin/pull/30097)

💬 fanquake commented on pull request "crypto: disable asan for sha256_sse4 with clang and -O0":
(https://github.com/bitcoin/bitcoin/pull/30097#issuecomment-2113705333)
Backported to 27.x in #30092.

👍 tdb3 approved a pull request: "Support JSON-RPC 2.0 when requested by client"
(https://github.com/bitcoin/bitcoin/pull/27101#pullrequestreview-2059283785)
re ACK for cbc6c440e3811d342fa570713702900b3e3e75b9

Great work. Performed brief code review. Re-ran the tests described in https://github.com/bitcoin/bitcoin/pull/27101#issuecomment-1922293722 again (actions 1 through 7, with the caveat that v27.0 was used as the baseline for comparison rather v26.0, and regtest was used). Everything worked as expected. Also ran all functional tests (passed).

💬 kristapsk commented on pull request "RPC: Return `permitbaremultisig` and `maxdatacarriersize` in `getmempoolinfo`":
(https://github.com/bitcoin/bitcoin/pull/29954#issuecomment-2113723824)
Rebased.

💬 theuni commented on pull request "serialization: Support for multiple parameters":
(https://github.com/bitcoin/bitcoin/pull/28929#issuecomment-2113764897)
@ryanofsky Sorry for not getting to this before merge. Will give it a look tomorrow.

💬 theuni commented on pull request "rpc: avoid copying into UniValue":
(https://github.com/bitcoin/bitcoin/pull/30115#issuecomment-2113778062)
I didn't check exhaustively, though, since that would be a lot more work and I think we have a clang-tidy check that would catch those cases.

Indeed, I believe c-i should be doing that check. But just in case, from the PR description:

> I ran these changes through clang-tidy with performance-move-const-arg and bugprone-use-after-move and no bugs were detected (though that's obviously not to say it can be trusted 100%).

💬 edilmedeiros commented on issue "contrib/signet/miner: grind will fail for high difficulty chain":
(https://github.com/bitcoin/bitcoin/issues/30102#issuecomment-2113923344)
Thanks for reporting.

About the 2m30s interval, see #30091.

📝 fanquake opened a pull request: "Update libsecp256k1 subtree to current master"
(https://github.com/bitcoin/bitcoin/pull/30120)
This includes changes from the 0.5.0 release: https://github.com/bitcoin-core/secp256k1/releases/tag/v0.5.0

> New function secp256k1_ec_pubkey_sort that sorts public keys using lexicographic (of compressed serialization) order.

> The implementation of the point multiplication algorithm used for signing and public key generation was changed, resulting in improved performance for those operations.
> The related configure option --ecmult-gen-precision was replaced with --ecmult-gen-kb (EC
...

💬 fanquake commented on pull request "Update libsecp256k1 subtree to current master":
(https://github.com/bitcoin/bitcoin/pull/30120#issuecomment-2113932737)
cc @real-or-random @jonasnick

🚀 fanquake merged a pull request: "p2p: detect addnode cjdns peers in GetAddedNodeInfo()"
(https://github.com/bitcoin/bitcoin/pull/30085)

🤔 edilmedeiros reviewed a pull request: "signet: fixing mining for OP_TRUE challenge"
(https://github.com/bitcoin/bitcoin/pull/29032#pullrequestreview-2059510296)
Concept ACK

Code looks good, I'm still to test it.

🤔 edilmedeiros reviewed a pull request: "Feature: Use different datadirs for different signets"
(https://github.com/bitcoin/bitcoin/pull/29838#pullrequestreview-2059519045)
Concept ACK.

Code looks good, but not tested yet.

Any way to add a functional test for this?

💬 fanquake commented on pull request "guix: Pointer Authentication and Branch Target Identification for aarch64 Linux (Guix)":
(https://github.com/bitcoin/bitcoin/pull/24123#issuecomment-2114000048)
Rebased on #29987.

💬 Waseem650 commented on pull request "p2p: peer connection bug fixes":
(https://github.com/bitcoin/bitcoin/pull/28248#issuecomment-2114002580)
1884778242

Id

💬 dominicusadinfinitum commented on issue "Testsuite for Bitcoin Core 27.0.0 - FAIL: qt/test/test_bitcoin-qt":
(https://github.com/bitcoin/bitcoin/issues/30020#issuecomment-2114076620)
@maflcko @willcl-ark

**Steps for reproduction**

git command to create a local copy (“clone”) of the source code:
$ git clone https://github.com/bitcoin/bitcoin.git

$ cd bitcoin

Selecting a Bitcoin Core Release:
$ git tag

To synchronize the local code with this version, use the git checkout command:
$ git checkout v27.0.0

Configuring the Bitcoin Core Build (I installed everything I found in the mentioned files) :
The source code includes documentation, which can be found i
...

💬 laanwj commented on pull request "net: Replace libnatpmp with built-in PCP implementation":
(https://github.com/bitcoin/bitcoin/pull/30043#issuecomment-2114203144)
> Maybe you can split src/util/netif.h off into a separate PR, along with https://github.com/bitcoin/bitcoin/commit/b06edec229d5cfc8d0d1a19bd723852e6bcfd9d9.

Sure, could do that.

> So maybe we should just pick one at random rather than announce all three. This also seems orthogonal to PCP.

Thanks, that's interesting.

One problem is that routers might fail to pinhole some of the addresses. For example, Fritz!Box refuses to open ports on temporary privacy ones, which aren't a distingui
...