📝 theStack opened a pull request: "refactor: simplify `FormatSubVersion` using strprintf/Join"
(https://github.com/bitcoin/bitcoin/pull/30098)
Rather than using std::ostringstream and manually joining the comments, use strprintf and our own `Join` helper.

👍 AngusP approved a pull request: "p2p: index TxOrphanage by wtxid, allow entries with same txid"
(https://github.com/bitcoin/bitcoin/pull/30000#pullrequestreview-2053871488)
tACK 16483fee7c6d93722bfb79fce9efbe841ec13d6a with some nits

💬 AngusP commented on pull request "p2p: index TxOrphanage by wtxid, allow entries with same txid":
(https://github.com/bitcoin/bitcoin/pull/30000#discussion_r1599118360)
Nit: given the discussion in the PR, you could extend this with a note on why we might still want to keep multiple same-txid-diff-witness transactions in the orphanage

```suggestion
// It is possible that the transaction in the orphanage has the same txid but a different
// witness (e.g. malleated by an attacker) and we don't want to return false positives,
// nor can we tell which of the same-txid-different-witness transactions in the orphanage
// could be evicted without
...

💬 AngusP commented on pull request "p2p: index TxOrphanage by wtxid, allow entries with same txid":
(https://github.com/bitcoin/bitcoin/pull/30000#discussion_r1599138412)
```suggestion
# 3. Honest peer relays the grandchild, which is missing a parent. The parent by txid already
```

💬 mzumsande commented on pull request "p2p: index TxOrphanage by wtxid, allow entries with same txid":
(https://github.com/bitcoin/bitcoin/pull/30000#discussion_r1599064530)
i don't think that's a problem, just mentioning that whether we disconnect the bad peer for misbehavior depends on the order in which the `ProcessOrphanTx` is called, so it could be random:
If the valid pair of txns is processed first, the invalid tx is removed with "txn-same-nonwitness-data-in-mempool" and no punishment. If the invalid pair is processed first, the bad peer is disconnected.

🤔 mzumsande reviewed a pull request: "p2p: index TxOrphanage by wtxid, allow entries with same txid"
(https://github.com/bitcoin/bitcoin/pull/30000#pullrequestreview-2053800837)
Tested ACK 16483fee7c6d93722bfb79fce9efbe841ec13d6a

I was at first skeptical at first about the first commit for similar reasons as stickies-v above, but after thinking about it more and reading the discussion it makes sense to me to cast a `Txid` to a `Wtxid` here.
I also played with the functional tests a bit (e.g. giving the parent in `test_orphan_txid_inv` a low fee and testing that everything still works if 1p1c package validation is used).

💬 mzumsande commented on pull request "p2p: index TxOrphanage by wtxid, allow entries with same txid":
(https://github.com/bitcoin/bitcoin/pull/30000#discussion_r1599193199)
nit: could use `send_and_ping` here too (as in the other subtests).

💬 fjahr commented on pull request "Testnet4 including PoW difficulty adjustment fix":
(https://github.com/bitcoin/bitcoin/pull/29775#discussion_r1599218267)
> Wouldn't it be better to defer the creation of the genesis block until a much farther date, so commit to changing during the rc phase, until the final release. We'd then include a similar mainnet block height hash or w/e as well.

We could still reset it before the release if reviewers really think it's necessary (I said so early in the discussion here as well) but we couldn't have tested that the PR works without a Genesis block. And think it's good we discussed what's to be included in the
...

💬 fanquake commented on pull request "rpc: move UniValue in blockToJSON":
(https://github.com/bitcoin/bitcoin/pull/30094#issuecomment-2109040044)
Backported to 27.x in #30092.

💬 fanquake commented on pull request "crypto: disable asan for sha256_sse4 with clang and -O0":
(https://github.com/bitcoin/bitcoin/pull/30097#issuecomment-2109145934)
Concept ACK - Think I prefer fixing this inline, than in global flags / build. I guess we didn't end up making an issue upstream (https://github.com/llvm/llvm-project/issues)? If there is something to link to, would be good to add it here.

💬 fanquake commented on issue "windows: Newer libevent causes `http_request` fuzz target failure":
(https://github.com/bitcoin/bitcoin/issues/30096#issuecomment-2109147753)
Is there something for this repo to do here? If that patch should be applied, then this should be a PR? If not, I guess close this?

💬 andrewtoth commented on pull request "Don't empty dbcache on prune flushes: >30% faster IBD":
(https://github.com/bitcoin/bitcoin/pull/28280#issuecomment-2109161840)
@achow101 I see what you mean, clear the flags and delete spent entries in the loop in `BatchWrite`. That would reduce each `Sync` from 2 full scans of the `coinsCache` to 1. It still scans the entire `coinsCache`, while the current change here only loops through flagged entries. Will experiment with how that performs, and possibly combining both ideas to do a single loop of only the flagged entries.

💬 fanquake commented on pull request "util: avoid using thread_local variable that has a destructor":
(https://github.com/bitcoin/bitcoin/pull/30095#issuecomment-2109179605)
https://github.com/bitcoin/bitcoin/pull/30095/checks?check_run_id=24909710597
```bash
'./'util/threadnames.cpp
In file included from /usr/include/string.h:535,
from /usr/include/c++/11/cstring:42,
from util/threadnames.cpp:7:
In function ‘void* memcpy(void*, const void*, size_t)’,
inlined from ‘void SetInternalName(std::string)’ at util/threadnames.cpp:50:16,
inlined from ‘void util::ThreadSetInternalName(std::string&&)’ at util/threadnames.cpp:6
...

💬 tdb3 commented on pull request "cli: Detect port errors in rpcconnect and rpcport":
(https://github.com/bitcoin/bitcoin/pull/29521#discussion_r1599319918)
No luck again with the arm CI. Will try playing with the specific stage locally more (https://github.com/bitcoin/bitcoin/tree/master/ci).

💬 achow101 commented on pull request "wallet: Implement independent BDB parser":
(https://github.com/bitcoin/bitcoin/pull/26606#discussion_r1599322082)
I don't think that's really necessary? I would expect that users would complain if a wallet suddenly was not able to be opened.

💬 achow101 commented on pull request "wallet: Implement independent BDB parser":
(https://github.com/bitcoin/bitcoin/pull/26606#discussion_r1599322196)
Done

💬 achow101 commented on pull request "wallet: Implement independent BDB parser":
(https://github.com/bitcoin/bitcoin/pull/26606#discussion_r1599322232)
Done

💬 achow101 commented on pull request "wallet: Implement independent BDB parser":
(https://github.com/bitcoin/bitcoin/pull/26606#discussion_r1599322343)
Added a comment.

💬 achow101 commented on pull request "wallet: Implement independent BDB parser":
(https://github.com/bitcoin/bitcoin/pull/26606#discussion_r1599322437)
Expanded the comment.

💬 fanquake commented on pull request "depends: set AR & RANLIB for CMake":
(https://github.com/bitcoin/bitcoin/pull/30078#issuecomment-2109215713)
Guix build (aarch64):
```bash
bdbb759d06e9766c5aa29a9ee1cea6f021d50618e1abe4732ae0120c4b444829 guix-build-019ad7327c39/output/aarch64-linux-gnu/SHA256SUMS.part
82aa7b4af365dde09b7fe435bd20432aa59168cb448f7a8cb898a8acb6178453 guix-build-019ad7327c39/output/aarch64-linux-gnu/bitcoin-019ad7327c39-aarch64-linux-gnu-debug.tar.gz
93c539e8c42ff767e46fc3f501cf9d543b954202372c930c177ff22eea6037f5 guix-build-019ad7327c39/output/aarch64-linux-gnu/bitcoin-019ad7327c39-aarch64-linux-gnu.tar.gz
caf904
...