💬 pinheadmz commented on issue "Where are the Developers keys to Install Bitcoin Core ?":
(https://github.com/bitcoin/bitcoin/issues/27346#issuecomment-1485272621)
correction: they were moved to https://github.com/bitcoin-core/guix.sigs/tree/main/builder-keys and the original locaiton was deleted in https://github.com/bitcoin/bitcoin/pull/26598

💬 pinheadmz commented on issue "Where are the Developers keys to Install Bitcoin Core ?":
(https://github.com/bitcoin/bitcoin/issues/27346#issuecomment-1485280130)
Closing this as duplicate of https://github.com/bitcoin-core/bitcoincore.org/issues/945. Discussion should move to the bitcoincore.org repo

✅ pinheadmz closed an issue: "Where are the Developers keys to Install Bitcoin Core ?"
(https://github.com/bitcoin/bitcoin/issues/27346)

💬 hernanmarino commented on pull request "build, qt: Fix handling of `CXX=clang++` when building `qt` package":
(https://github.com/bitcoin/bitcoin/pull/27314#issuecomment-1485282916)
I can confirm with clang-15.
```
Ubuntu clang version 15.0.7
Target: x86_64-pc-linux-gnu
Thread model: posix
```

💬 hebasto commented on pull request "depends: fontconfig 2.14.2":
(https://github.com/bitcoin/bitcoin/pull/27301#discussion_r1149392363)
Is `-Wno-int-conversion` really required to compile with clang-16?

💬 hebasto commented on pull request "depends: fontconfig 2.14.2":
(https://github.com/bitcoin/bitcoin/pull/27301#issuecomment-1485289625)
> depends: fontconfig 2.14.2

Update the title?

💬 1440000bytes commented on pull request "rpc, wallet: add ability to retrieve all address book entries":
(https://github.com/bitcoin/bitcoin/pull/26174#issuecomment-1485309914)
Concept ACK

💬 hebasto commented on pull request "Warn when sending to already-used Bitcoin addresses":
(https://github.com/bitcoin-core/gui/pull/562#issuecomment-1485310320)
Closing this due to lack of activity. Feel free to reopen.

✅ hebasto closed a pull request: "Warn when sending to already-used Bitcoin addresses"
(https://github.com/bitcoin-core/gui/pull/562)

💬 hebasto commented on pull request "Make error message layout consistent":
(https://github.com/bitcoin-core/gui/pull/560#issuecomment-1485313776)
Closing this due to lack of activity. Feel free to reopen.

✅ hebasto closed a pull request: "Make error message layout consistent"
(https://github.com/bitcoin-core/gui/pull/560)

💬 hebasto commented on pull request "Network graph improvements":
(https://github.com/bitcoin-core/gui/pull/559#issuecomment-1485316876)
Closing this due to lack of activity. Feel free to reopen.

💬 hebasto commented on pull request "Network graph improvements":
(https://github.com/bitcoin-core/gui/pull/559#issuecomment-1485316876)
Closing this due to lack of activity. Feel free to reopen.

✅ hebasto closed a pull request: "Network graph improvements"
(https://github.com/bitcoin-core/gui/pull/559)

💬 hebasto commented on pull request "network graph - show/hide panels based on window width/height":
(https://github.com/bitcoin-core/gui/pull/540#issuecomment-1485322497)
Closing this due to lack of activity. Feel free to reopen.

✅ hebasto closed a pull request: "network graph - show/hide panels based on window width/height"
(https://github.com/bitcoin-core/gui/pull/540)

💬 1440000bytes commented on pull request "init: Error if ignored bitcoin.conf file is found":
(https://github.com/bitcoin/bitcoin/pull/27302#issuecomment-1485326965)
> Show an error on startup if a bitcoin datadir that is being used contains a bitcoin.conf file that is ignored

1. Why is it ignored?
2. Any downsides for using bitcoin.conf from datadir if conf argument isn't used?

💬 furszy commented on pull request "wallet: finish addressbook encapsulation":
(https://github.com/bitcoin/bitcoin/pull/26836#discussion_r1149415708)
I prefer the current code, it's more readable.
The curly braces initializer is primarily useful to prevent narrowing (which is the implicit conversion of arithmetic values). Here, there is no loss of accuracy, we are simply initializing a boolean from a logical statement.

💬 ryanofsky commented on pull request "system: cache config file path before potentially updating datadir":
(https://github.com/bitcoin/bitcoin/pull/27303#issuecomment-1485330420)
Code review ACK 8d6114aeaa7cfc747eae068116da04af86ed8e92. I think this is the probably the simplest possible bugfix for the incorrect log print, but it also adds unnecessary code complexity and fragile code without meaningful test coverage, so I do not think it is the best approach.

Here are the specific problems with 8d6114aeaa7cfc747eae068116da04af86ed8e92:

- The new python test doesn't actually check for the bug being fixed, and passes on existing code. The bug can't be tested unless bi
...

💬 josibake commented on pull request "MiniTapscript: port Miniscript to Tapscript":
(https://github.com/bitcoin/bitcoin/pull/27255#issuecomment-1485343142)
Concept ACK