🚀 fanquake merged a pull request: "refactor: Remove unused code from `subprocess.h` header"
(https://github.com/bitcoin/bitcoin/pull/30081)
(https://github.com/bitcoin/bitcoin/pull/30081)
💬 hebasto commented on pull request "Reintroduce external signer support for Windows":
(https://github.com/bitcoin/bitcoin/pull/29868#issuecomment-2105674960)
Rebased due to the conflict with merged bitcoin/bitcoin#30081.
(https://github.com/bitcoin/bitcoin/pull/29868#issuecomment-2105674960)
Rebased due to the conflict with merged bitcoin/bitcoin#30081.
⚠️ qqxiaoteng opened an issue: "About Artificial Intelligence and digital currencies"
(https://github.com/bitcoin/bitcoin/issues/30086)
### Please describe the feature you'd like to see added.
It is believed that digital currencies such as Bitcoin and Litecoin are unnecessary, and the mining and earning of these currencies consume a large amount of human actual energy, resources, and computing power, resulting in only strings with no actual value or meaning. Using such strings as currency to measure value is not as good as using a certain indicator in the current development of artificial intelligence to act as a digital curren
...
(https://github.com/bitcoin/bitcoin/issues/30086)
### Please describe the feature you'd like to see added.
It is believed that digital currencies such as Bitcoin and Litecoin are unnecessary, and the mining and earning of these currencies consume a large amount of human actual energy, resources, and computing power, resulting in only strings with no actual value or meaning. Using such strings as currency to measure value is not as good as using a certain indicator in the current development of artificial intelligence to act as a digital curren
...
⚠️ qqxiaoteng opened an issue: "About Artificial Intelligence and digital currencies"
(https://github.com/bitcoin/bitcoin/issues/30087)
### Please describe the feature you'd like to see added.
It is believed that digital currencies such as Bitcoin and Litecoin are unnecessary, and the mining and earning of these currencies consume a large amount of human actual energy, resources, and computing power, resulting in only strings with no actual value or meaning. Using such strings as currency to measure value is not as good as using a certain indicator in the current development of artificial intelligence to act as a digital curren
...
(https://github.com/bitcoin/bitcoin/issues/30087)
### Please describe the feature you'd like to see added.
It is believed that digital currencies such as Bitcoin and Litecoin are unnecessary, and the mining and earning of these currencies consume a large amount of human actual energy, resources, and computing power, resulting in only strings with no actual value or meaning. Using such strings as currency to measure value is not as good as using a certain indicator in the current development of artificial intelligence to act as a digital curren
...
💬 qqxiaoteng commented on issue "About Artificial Intelligence and digital currencies":
(https://github.com/bitcoin/bitcoin/issues/30087#issuecomment-2105740834)
Keep up with the era of artificial intelligence to avoid being eliminated
(https://github.com/bitcoin/bitcoin/issues/30087#issuecomment-2105740834)
Keep up with the era of artificial intelligence to avoid being eliminated
✅ fanquake closed an issue: "About Artificial Intelligence and digital currencies"
(https://github.com/bitcoin/bitcoin/issues/30086)
(https://github.com/bitcoin/bitcoin/issues/30086)
:lock: fanquake locked an issue: "About Artificial Intelligence and digital currencies"
(https://github.com/bitcoin/bitcoin/issues/30086)
(https://github.com/bitcoin/bitcoin/issues/30086)
✅ fanquake closed an issue: "About Artificial Intelligence and digital currencies"
(https://github.com/bitcoin/bitcoin/issues/30087)
(https://github.com/bitcoin/bitcoin/issues/30087)
:lock: fanquake locked an issue: "About Artificial Intelligence and digital currencies"
(https://github.com/bitcoin/bitcoin/issues/30087)
(https://github.com/bitcoin/bitcoin/issues/30087)
🤔 TheCharlatan reviewed a pull request: "rpc: Optimize serialization and enhance metadata of dumptxoutset output"
(https://github.com/bitcoin/bitcoin/pull/29612#pullrequestreview-2051206848)
Nice, just some small comments, will review again quickly once they are addressed.
(https://github.com/bitcoin/bitcoin/pull/29612#pullrequestreview-2051206848)
Nice, just some small comments, will review again quickly once they are addressed.
💬 TheCharlatan commented on pull request "rpc: Optimize serialization and enhance metadata of dumptxoutset output":
(https://github.com/bitcoin/bitcoin/pull/29612#discussion_r1597449496)
In commit b2cf3f77b14bccf11ad5bc211db7f746ae5073fb:
Nit: Could just do `const auto regtest_msg = CChainParams::RegTest({})->MessageStart();` here and for the `signet_msg`.
(https://github.com/bitcoin/bitcoin/pull/29612#discussion_r1597449496)
In commit b2cf3f77b14bccf11ad5bc211db7f746ae5073fb:
Nit: Could just do `const auto regtest_msg = CChainParams::RegTest({})->MessageStart();` here and for the `signet_msg`.
💬 TheCharlatan commented on pull request "rpc: Optimize serialization and enhance metadata of dumptxoutset output":
(https://github.com/bitcoin/bitcoin/pull/29612#discussion_r1597450105)
In commit b2cf3f77b14bccf11ad5bc211db7f746ae5073fb:
Is this include from a prior iteration? It seems unused (also in the header file).
(https://github.com/bitcoin/bitcoin/pull/29612#discussion_r1597450105)
In commit b2cf3f77b14bccf11ad5bc211db7f746ae5073fb:
Is this include from a prior iteration? It seems unused (also in the header file).
💬 TheCharlatan commented on pull request "rpc: Optimize serialization and enhance metadata of dumptxoutset output":
(https://github.com/bitcoin/bitcoin/pull/29612#discussion_r1597453382)
In commit b2cf3f77b14bccf11ad5bc211db7f746ae5073fb:
Nit: I think this should be moved to the first commit.
(https://github.com/bitcoin/bitcoin/pull/29612#discussion_r1597453382)
In commit b2cf3f77b14bccf11ad5bc211db7f746ae5073fb:
Nit: I think this should be moved to the first commit.
💬 TheCharlatan commented on pull request "rpc: Optimize serialization and enhance metadata of dumptxoutset output":
(https://github.com/bitcoin/bitcoin/pull/29612#discussion_r1597455340)
In commit b2cf3f77b14bccf11ad5bc211db7f746ae5073fb
Nit (clang-format-diff): Open braces on new line (here and the other new functions and methods below).
(https://github.com/bitcoin/bitcoin/pull/29612#discussion_r1597455340)
In commit b2cf3f77b14bccf11ad5bc211db7f746ae5073fb
Nit (clang-format-diff): Open braces on new line (here and the other new functions and methods below).
📝 luke-jr opened a pull request: "Bugfix: RPC/Mining: getblocktemplate: Delay updating nTransactionsUpdatedLast and time_start until after the new template is cached"
(https://github.com/bitcoin/bitcoin/pull/30088)
This is needed to avoid parallel calls from incorrectly using the stale cached template or (after an OOM) dereferencing a nullptr pblocktemplate
Considering memory overcommit, the worst case scenario likely never occurs, but that possibility is the clear bugfix here.
Aside from that, I wonder if using the stale cache in this race scenario (which is what could happen if this isn't fixed) is better than having N threads all making a new block (with this fix).
A middle ground (and perhaps
...
(https://github.com/bitcoin/bitcoin/pull/30088)
This is needed to avoid parallel calls from incorrectly using the stale cached template or (after an OOM) dereferencing a nullptr pblocktemplate
Considering memory overcommit, the worst case scenario likely never occurs, but that possibility is the clear bugfix here.
Aside from that, I wonder if using the stale cache in this race scenario (which is what could happen if this isn't fixed) is better than having N threads all making a new block (with this fix).
A middle ground (and perhaps
...
💬 Ridvan8899 commented on issue "Release Schedule for 28.0":
(https://github.com/bitcoin/bitcoin/issues/29891#issuecomment-2105927410)
[]()ننثخق
(https://github.com/bitcoin/bitcoin/issues/29891#issuecomment-2105927410)
[]()ننثخق
💬 Ridvan8899 commented on issue "upstream: GUIX closure contains too much unnecessary stuff":
(https://github.com/bitcoin/bitcoin/issues/30042#issuecomment-2105927573)
او وة
(https://github.com/bitcoin/bitcoin/issues/30042#issuecomment-2105927573)
او وة
💬 Ridvan8899 commented on issue "upstream: GUIX closure contains too much unnecessary stuff":
(https://github.com/bitcoin/bitcoin/issues/30042#issuecomment-2105927703)
تااا
(https://github.com/bitcoin/bitcoin/issues/30042#issuecomment-2105927703)
تااا
💬 Ridvan8899 commented on issue "~/.bitcoin (which is a softlink to a separate vmware virtual drive) dir is now almost 1tb":
(https://github.com/bitcoin/bitcoin/issues/29909#issuecomment-2105927747)
اةا
(https://github.com/bitcoin/bitcoin/issues/29909#issuecomment-2105927747)
اةا
💬 Ridvan8899 commented on issue "utils: wallet_dump can create a `database` directory, cross-pollinating records":
(https://github.com/bitcoin/bitcoin/issues/29883#issuecomment-2105927772)
تالل
(https://github.com/bitcoin/bitcoin/issues/29883#issuecomment-2105927772)
تالل