✅ hebasto closed a pull request: "[WIP] GUI: exception safe drop-in replacement for QTimer::singleShot"
(https://github.com/bitcoin-core/gui/pull/666)

🚀 fanquake merged a pull request: "guix: import/sync python-lief (0.12.3) package definition from upstream"
(https://github.com/bitcoin/bitcoin/pull/27296)

⚠️ fanquake opened an issue: "-Wmaybe-uninitialized warnings under LTO"
(https://github.com/bitcoin/bitcoin/issues/27343)
Building under GCC `13.0.1` with `-flto` (Fedora Rawhide) currently results in a number of `-Wmaybe-uninitialized` warnings. Some of these are things we might not want to "fix", i.e in test code. Some come from leveldb etc. Open this issue to document them, as some exist with current versions of GCC, and GCC 13.0 will be released soon:

```bash
In member function 'operator=',
inlined from 'Seed.constprop' at test/util/setup_common.cpp:91:33:
random.cpp:687:19: warning: 'D.19516.bitbuf'
...

💬 fanquake commented on pull request "fix initialization in FastRandomContext: removes undefined behavior & uninitialized read":
(https://github.com/bitcoin/bitcoin/pull/23169#issuecomment-1485121825)
> is not relevant any more / was fixed (as far as I can say)

There are still some `-Wmaybe-uninitialized` warnings produced with GCC 13.0.1 and `-flto`, some in random.cpp. Opened #27343 to document them + others.

💬 rajarshimaitra commented on pull request "rpc, wallet: add ability to retrieve all address book entries":
(https://github.com/bitcoin/bitcoin/pull/26174#issuecomment-1485139620)
Concept ACK. This is useful for various situations where a bunch of imported spks needs to be retrieved from the wallet. Maybe to compare with an external source and check if any new spks need to be imported into the watchlist. Previously it could be done by making redundant labels just for this call, but having this option to dump everything seems useful.

I will go through the code changes in more detail. Adding one simple, functional test to check the behavior will be helpful.

🚀 fanquake merged a pull request: "guix: combine and document `enable_werror`"
(https://github.com/bitcoin/bitcoin/pull/27326)

💬 fanquake commented on pull request "build, qt: Fix handling of `CXX=clang++` when building `qt` package":
(https://github.com/bitcoin/bitcoin/pull/27314#issuecomment-1485161647)
Can someone confirm that this works with clang-15 & earlier, clang-16 & later?

💬 pablomartin4btc commented on pull request "Wallet : Allow user to navigate options while encrypting at creation":
(https://github.com/bitcoin-core/gui/pull/722#discussion_r1149294086)
I do agree with just "Back".

💬 dergoegge commented on pull request "net: #27257 follow-ups":
(https://github.com/bitcoin/bitcoin/pull/27324#discussion_r1149295249)
Done! happy to amend the comment if you had something different in mind.

💬 hebasto commented on pull request "[WIP/Draft] Add Address tab":
(https://github.com/bitcoin-core/gui/pull/634#issuecomment-1485169429)
Closing this due to lack of activity. Feel free to reopen.

✅ hebasto closed a pull request: "[WIP/Draft] Add Address tab"
(https://github.com/bitcoin-core/gui/pull/634)

📝 MarcoFalke opened a pull request: "fuzz: Remove legacy int parse fuzz tests"
(https://github.com/bitcoin/bitcoin/pull/27344)
The fuzz tests checked that the result of the new function was equal to the legacy function. (Side note: The checks were incomplete, as evident by the follow-up fix in commit b5c9bb5cb9f4a8db57b33ef7399310c7d6de5822).

Given that they haven't found any issues in years (beside missing the above issue, that they couldn't catch), it seems time to remove them.

They may come in handy in the rare case that someone would want to modify `LocaleIndependentAtoi()` or `Parse*Int*()`, however that seem
...

💬 hebasto commented on pull request "Fix shortcut ambiguities":
(https://github.com/bitcoin-core/gui/pull/633#issuecomment-1485172473)
@shaavan Still working on this PR?

💬 MarcoFalke commented on issue "-Wmaybe-uninitialized warnings under LTO":
(https://github.com/bitcoin/bitcoin/issues/27343#issuecomment-1485175948)
Fuzz ones removed in https://github.com/bitcoin/bitcoin/pull/27344

💬 TheCharlatan commented on pull request "build, qt: Fix handling of `CXX=clang++` when building `qt` package":
(https://github.com/bitcoin/bitcoin/pull/27314#issuecomment-1485177511)
> Can someone confirm that this works with clang-15 & earlier, clang-16 & later?

Can confirm for clang 14 and 15. I should start testing these PRs against clang-16 now too.

💬 hebasto commented on pull request "Showing Local Addresses in Node Window":
(https://github.com/bitcoin-core/gui/pull/626#issuecomment-1485199088)
Please rebase due to the conflict with the current master branch (b968424c25826cc7b4aa2ec1a5afdb59b41d3377).

✅ hebasto closed a pull request: "test, refactor: Use the same shutdown path as in bitcoin-qt binary"
(https://github.com/bitcoin-core/gui/pull/611)

💬 fanquake commented on pull request "build, qt: Fix handling of `CXX=clang++` when building `qt` package":
(https://github.com/bitcoin/bitcoin/pull/27314#issuecomment-1485203210)
> Can confirm for clang 14 and 15.

Thanks.

> clang-16 & later?

Actually, this isn't straightforward before #27301. All good.

✅ fanquake closed a pull request: "depends: fontconfig 2.14.2"
(https://github.com/bitcoin/bitcoin/pull/27301)

📝 fanquake reopened a pull request: "depends: fontconfig 2.14.2"
(https://github.com/bitcoin/bitcoin/pull/27301)
We need to bump this as the current version doesn't compile under `clang-16`, which is blocking upgrading sanitizer/fuzzing infrastructure (see #27298).

Untested. Need to double-check the gperf/patch dropping.