💬 maflcko commented on pull request "ci: add markdown link check job":
(https://github.com/bitcoin/bitcoin/pull/30034#discussion_r1593737106)
nit: Could remove this, as the URL is below as well.

💬 maflcko commented on pull request "ci: add markdown link check job":
(https://github.com/bitcoin/bitcoin/pull/30034#discussion_r1593736433)
check_output is a helper that assumes the command exists, so I don't think it will work here, no?

Ref:

```
thread 'main' panicked at src/main.rs:23:28:
command error: Os { code: 2, kind: NotFound, message: "No such file or directory" }
stack backtrace:
0: rust_begin_unwind
...
```

I think in a previous version you had a check for `NotFound` directly, so you could restore that?

💬 laanwj commented on pull request "guix: build with glibc 2.31":
(https://github.com/bitcoin/bitcoin/pull/29987#issuecomment-2100177952)
New used symbols since 2.28:

81: 0000000000000000 0 FUNC GLOBAL DEFAULT UND fcntl64@GLIBC_2.28 (15)

`fcntl` function that can handle large file offsets on 32 bit platforms. Used in `unixFileLock`. `unixShmLock` and other posix/unix file functions.

195: 0000000000000000 0 FUNC GLOBAL DEFAULT UND statx@GLIBC_2.28 (15)

Extended file stat. Used in `QFileSystemEngine::fillMetaData`.

533: 0000000000000000 0 FUNC GLOBAL DEFAULT UND r
...

💬 willcl-ark commented on pull request "ci: add markdown link check job":
(https://github.com/bitcoin/bitcoin/pull/30034#discussion_r1593777495)
Reverted in 9d2a8a8b1d67af14e4a5fc8276a1069b6ef9fe4a

💬 willcl-ark commented on pull request "ci: add markdown link check job":
(https://github.com/bitcoin/bitcoin/pull/30034#discussion_r1593777653)
Removed in 9d2a8a8b1d67af14e4a5fc8276a1069b6ef9fe4a

💬 josibake commented on pull request "crypto, refactor: add method for applying the taptweak":
(https://github.com/bitcoin/bitcoin/pull/30051#issuecomment-2100225575)
Updated to use a utility function (instead of a method on `CKey`) per the @theuni 's feedback

💬 maflcko commented on issue "Memory leak with `rest/block` REST endpoint and `getblock` RPC when verbosity >=2":
(https://github.com/bitcoin/bitcoin/issues/30052#issuecomment-2100234965)
Did the same check with

```
valgrind --tool=massif ./src/bitcoind &
while sleep 3; do ./src/bitcoin-cli getblock 00000000000000000002a7c4c1e48d76c5a37902165a270156b7a8d72728a054 2 ; done

...

massif-visualizer ./massif.out.1234
```


✅ maflcko closed an issue: "Memory leak with `rest/block` REST endpoint and `getblock` RPC when verbosity >=2"
(https://github.com/bitcoin/bitcoin/issues/30052)

💬 maflcko commented on issue "Memory leak with `rest/block` REST endpoint and `getblock` RPC when verbosity >=2":
(https://github.com/bitcoin/bitcoin/issues/30052#issuecomment-2100235479)
Closing for now, as duplicate

💬 maflcko commented on issue "Slow memory leak in v22.0?":
(https://github.com/bitcoin/bitcoin/issues/24542#issuecomment-2100240679)
Not sure what can be done here. It would be good to use a tool to debug this, e.g. https://github.com/bitcoin/bitcoin/issues/24542#issuecomment-1067744040, if it still happens.

👍 fanquake approved a pull request: "ci: Roll clang in test-each-commit task"
(https://github.com/bitcoin/bitcoin/pull/30060#pullrequestreview-2045257886)
ACK 2094da680fe580ba1bc62e9bab1e196f5e1c5341

👍 maflcko approved a pull request: "ci: add markdown link check job"
(https://github.com/bitcoin/bitcoin/pull/30034#pullrequestreview-2045256787)
utACK

💬 maflcko commented on pull request "ci: add markdown link check job":
(https://github.com/bitcoin/bitcoin/pull/30034#discussion_r1593795459)
nit: Any reason to modify the default here, or specify the default value?

💬 maflcko commented on pull request "ci: add markdown link check job":
(https://github.com/bitcoin/bitcoin/pull/30034#discussion_r1593798620)
nit: forgot to put this in args?

💬 willcl-ark commented on pull request "ci: add markdown link check job":
(https://github.com/bitcoin/bitcoin/pull/30034#discussion_r1593798691)
Just making it clear(er) that we are piping stdout to null vs printing stderr. But not really.

👋 willcl-ark's pull request is ready for review: "ci: add markdown link check job"
(https://github.com/bitcoin/bitcoin/pull/30034)

💬 maflcko commented on pull request "ci: Roll clang in test-each-commit task":
(https://github.com/bitcoin/bitcoin/pull/30060#issuecomment-2100256768)
This fails, because the image does not exist yet.

💬 maflcko commented on pull request "ci: add markdown link check job":
(https://github.com/bitcoin/bitcoin/pull/30034#discussion_r1593801135)
I'd say to keep stdout, unless there is a reason to suppress it?

💬 fanquake commented on pull request "ci: Roll clang in test-each-commit task":
(https://github.com/bitcoin/bitcoin/pull/30060#issuecomment-2100260070)
Yea, don't have to merge, but can do as soon as we have green CI. The image should be available very shortly?

💬 fanquake commented on pull request "build: swap cctools otool for llvm-objdump":
(https://github.com/bitcoin/bitcoin/pull/29739#issuecomment-2100263642)
Dropped the last commit just to make this simpler to review. The swap to objdump is the most complex of the cctools -> llvm swaps, because of the associated Python changes, all the of the rest are easier, and can be done in 1 go in a followup.