💬 theStack commented on pull request "test: add MiniWallet tagging support to avoid UTXO mixing, use in `fill_mempool`":
(https://github.com/bitcoin/bitcoin/pull/29939#discussion_r1590272281)
Good point. I'm planning a follow-up where these prerequisites (-datacarriersize=100000 and -maxmempool=5) are checked at run-time in `fill_mempool`, in order to give explicit error messages if `fill_mempool` users forget to set these parameters. Will include a commit with your suggestion to add comments in functional tests where this is missing (seems to be both in `rpc_packages.py` and `p2p_tx_download.py`).
(https://github.com/bitcoin/bitcoin/pull/29939#discussion_r1590272281)
Good point. I'm planning a follow-up where these prerequisites (-datacarriersize=100000 and -maxmempool=5) are checked at run-time in `fill_mempool`, in order to give explicit error messages if `fill_mempool` users forget to set these parameters. Will include a commit with your suggestion to add comments in functional tests where this is missing (seems to be both in `rpc_packages.py` and `p2p_tx_download.py`).
💬 theStack commented on pull request "test: add MiniWallet tagging support to avoid UTXO mixing, use in `fill_mempool`":
(https://github.com/bitcoin/bitcoin/pull/29939#issuecomment-2094748534)
Rebased on master (necessary since #28970 introduced new tests with `fill_mempool` call-sites) and addressed review comment https://github.com/bitcoin/bitcoin/pull/29939#discussion_r1584441713.
(https://github.com/bitcoin/bitcoin/pull/29939#issuecomment-2094748534)
Rebased on master (necessary since #28970 introduced new tests with `fill_mempool` call-sites) and addressed review comment https://github.com/bitcoin/bitcoin/pull/29939#discussion_r1584441713.
💬 0xB10C commented on pull request "tracing: explicitly cast block_connected duration to nanoseconds":
(https://github.com/bitcoin/bitcoin/pull/29877#issuecomment-2094762513)
> > Any reason not to just stick to nanoseconds and harden it against future accidents?
>
> I think updating the documentation and using `Ticks<std::chrono::nanoseconds>` would work just as well, yes..
Done. For me, not breaking the (already broken) API again is easier. Especially when running current and future releases in parallel. Sorry to invalidate your ACK @maflcko @laanwj.
(https://github.com/bitcoin/bitcoin/pull/29877#issuecomment-2094762513)
> > Any reason not to just stick to nanoseconds and harden it against future accidents?
>
> I think updating the documentation and using `Ticks<std::chrono::nanoseconds>` would work just as well, yes..
Done. For me, not breaking the (already broken) API again is easier. Especially when running current and future releases in parallel. Sorry to invalidate your ACK @maflcko @laanwj.
💬 jlopp commented on pull request "Testnet4 including PoW difficulty adjustment fix":
(https://github.com/bitcoin/bitcoin/pull/29775#issuecomment-2094796800)
The genesis block message is just for fun, since almost nobody will ever see it. There were half a dozen articles written about testnet recently, however the CCN article was the only one with a relevant title that mentioned resetting testnet. I don't think the "strength" of the message to prevent pre-mining really matters if we agree that the primary goal is for testnet tokens to not have value.
The goal of my griefing was to bring attention to this issue, and I dare say that it worked. We're
...
(https://github.com/bitcoin/bitcoin/pull/29775#issuecomment-2094796800)
The genesis block message is just for fun, since almost nobody will ever see it. There were half a dozen articles written about testnet recently, however the CCN article was the only one with a relevant title that mentioned resetting testnet. I don't think the "strength" of the message to prevent pre-mining really matters if we agree that the primary goal is for testnet tokens to not have value.
The goal of my griefing was to bring attention to this issue, and I dare say that it worked. We're
...
💬 vostrnad commented on issue "Possible to Ban Clients by Name?":
(https://github.com/bitcoin/bitcoin/issues/30036#issuecomment-2094814430)
Are you sure it's "Satoshi-BTC" and not "Satoshi-BTF"? bitnodes.io reports 12 nodes with the user agent [/Satoshi-BTF(BitcoinFinance):0.15.1/](https://bitnodes.io/nodes/?q=Satoshi-BTF%28BitcoinFinance%29%3A0.15.1), most of them in China.
(https://github.com/bitcoin/bitcoin/issues/30036#issuecomment-2094814430)
Are you sure it's "Satoshi-BTC" and not "Satoshi-BTF"? bitnodes.io reports 12 nodes with the user agent [/Satoshi-BTF(BitcoinFinance):0.15.1/](https://bitnodes.io/nodes/?q=Satoshi-BTF%28BitcoinFinance%29%3A0.15.1), most of them in China.
👋 theStack's pull request is ready for review: "contrib: add tool to convert compact-serialized UTXO set to SQLite database"
(https://github.com/bitcoin/bitcoin/pull/27432)
(https://github.com/bitcoin/bitcoin/pull/27432)
🤔 furszy reviewed a pull request: "rpc, wallet: fix incorrect segwit redeem script size limit"
(https://github.com/bitcoin/bitcoin/pull/28307#pullrequestreview-2039716714)
> I wrote a test for RPC signrawtransactionwithkey that covers legacy P2SH with 15 and 16 public keys. Both calls succeed even though the latter produces a scriptSig that exceeds MAX_STANDARD_SCRIPTSIG_SIZE and if it ever made it into a block, would exceed MAX_SCRIPT_ELEMENT_SIZE
The second call, the one with 16 pubkeys, doesn't entirely succeed. The test isn't checking the error field in the `signrawtransactionwithkey` response, which returns an `'error': 'Push value size limit exceeded'`.
...
(https://github.com/bitcoin/bitcoin/pull/28307#pullrequestreview-2039716714)
> I wrote a test for RPC signrawtransactionwithkey that covers legacy P2SH with 15 and 16 public keys. Both calls succeed even though the latter produces a scriptSig that exceeds MAX_STANDARD_SCRIPTSIG_SIZE and if it ever made it into a block, would exceed MAX_SCRIPT_ELEMENT_SIZE
The second call, the one with 16 pubkeys, doesn't entirely succeed. The test isn't checking the error field in the `signrawtransactionwithkey` response, which returns an `'error': 'Push value size limit exceeded'`.
...
💬 tdb3 commented on pull request "test: adds outbound eviction functional tests, updates comment in ConsiderEviction":
(https://github.com/bitcoin/bitcoin/pull/29122#issuecomment-2094859146)
Re ACK for d53d84834747c37f4060a9ef379e0a6b50155246
Pulled, built, ran all unit/functional tests (all passed).
(https://github.com/bitcoin/bitcoin/pull/29122#issuecomment-2094859146)
Re ACK for d53d84834747c37f4060a9ef379e0a6b50155246
Pulled, built, ran all unit/functional tests (all passed).
💬 Ferrydh commented on pull request "test: adds outbound eviction functional tests, updates comment in ConsiderEviction":
(https://github.com/bitcoin/bitcoin/pull/29122#issuecomment-2094860396)
这是来自QQ邮箱的假期自动回复邮件。
您好，我最近正在休假中，无法亲自回复您的邮件。我将在假期结束后，尽快给您回复。
(https://github.com/bitcoin/bitcoin/pull/29122#issuecomment-2094860396)
这是来自QQ邮箱的假期自动回复邮件。
您好，我最近正在休假中，无法亲自回复您的邮件。我将在假期结束后，尽快给您回复。
💬 vasild commented on pull request "Logging cleanup":
(https://github.com/bitcoin/bitcoin/pull/29798#issuecomment-2094886890)
`d98ca056a8...bee22409ea`: rebase and address suggestions
(https://github.com/bitcoin/bitcoin/pull/29798#issuecomment-2094886890)
`d98ca056a8...bee22409ea`: rebase and address suggestions
💬 vasild commented on pull request "Logging cleanup":
(https://github.com/bitcoin/bitcoin/pull/29798#discussion_r1590369829)
Dropped the commit entirely as suggested.
(https://github.com/bitcoin/bitcoin/pull/29798#discussion_r1590369829)
Dropped the commit entirely as suggested.
💬 vasild commented on pull request "Logging cleanup":
(https://github.com/bitcoin/bitcoin/pull/29798#discussion_r1590369909)
Done as suggested.
(https://github.com/bitcoin/bitcoin/pull/29798#discussion_r1590369909)
Done as suggested.
💬 vasild commented on pull request "Logging cleanup":
(https://github.com/bitcoin/bitcoin/pull/29798#discussion_r1590370012)
Done.
(https://github.com/bitcoin/bitcoin/pull/29798#discussion_r1590370012)
Done.
💬 achow101 commented on pull request "chainparams: Add achow101 DNS seeder":
(https://github.com/bitcoin/bitcoin/pull/30007#issuecomment-2094889653)
> i think it's still missing some part, resolving through Google's DNS (which has more verbose error messages than my ISP) gives:
Should be fixed now
(https://github.com/bitcoin/bitcoin/pull/30007#issuecomment-2094889653)
> i think it's still missing some part, resolving through Google's DNS (which has more verbose error messages than my ISP) gives:
Should be fixed now
💬 vasild commented on pull request "Logging cleanup":
(https://github.com/bitcoin/bitcoin/pull/29798#discussion_r1590371367)
Reworded the commit message as suggested, but I didn't get this:
> Right now this returns NONE/true when the empty string "" is passed.
Hmm, no? It returns ALL/true when "" is passed, in `master` and in this PR - there is an `if (str.empty() ...` a few lines above.
> Should return false in that case too
You mean to return false when empty string is passed? That would be some further change that maybe makes sense, but is not included in this PR.
> and never return NONE?
It never
...
(https://github.com/bitcoin/bitcoin/pull/29798#discussion_r1590371367)
Reworded the commit message as suggested, but I didn't get this:
> Right now this returns NONE/true when the empty string "" is passed.
Hmm, no? It returns ALL/true when "" is passed, in `master` and in this PR - there is an `if (str.empty() ...` a few lines above.
> Should return false in that case too
You mean to return false when empty string is passed? That would be some further change that maybe makes sense, but is not included in this PR.
> and never return NONE?
It never
...
💬 vasild commented on pull request "Logging cleanup":
(https://github.com/bitcoin/bitcoin/pull/29798#discussion_r1590371992)
Yeah, good observation! I tried to reorder the commits but then if the rpc commit is the first one I would have to remove `"0"` from `LOG_CATEGORIES_BY_STR` which is used outside of `GetLogCategory()` and then it becomes difficult to asses the change. So I left it as it is.
(https://github.com/bitcoin/bitcoin/pull/29798#discussion_r1590371992)
Yeah, good observation! I tried to reorder the commits but then if the rpc commit is the first one I would have to remove `"0"` from `LOG_CATEGORIES_BY_STR` which is used outside of `GetLogCategory()` and then it becomes difficult to asses the change. So I left it as it is.
💬 emsit commented on pull request "Testnet4 including PoW difficulty adjustment fix":
(https://github.com/bitcoin/bitcoin/pull/29775#issuecomment-2094892382)
With the tool you're using, it's possible to generate an empty block (with a gap), and after removing the condition in the code, even with null (I haven't studied further issues if psz was empty, the block was successfully generated.)
Or would it be possible to write only the testnet4 release date in Psz?
```
./generate-genesis -timestamp $(date +%s) -pubkey 000000000000000000000000000000000000000000000000000000000000000000 -psz " "
Ctrl Hash: 0x00000000320b39907d50bfd4e60d1b767ffbf403ec
...
(https://github.com/bitcoin/bitcoin/pull/29775#issuecomment-2094892382)
With the tool you're using, it's possible to generate an empty block (with a gap), and after removing the condition in the code, even with null (I haven't studied further issues if psz was empty, the block was successfully generated.)
Or would it be possible to write only the testnet4 release date in Psz?
```
./generate-genesis -timestamp $(date +%s) -pubkey 000000000000000000000000000000000000000000000000000000000000000000 -psz " "
Ctrl Hash: 0x00000000320b39907d50bfd4e60d1b767ffbf403ec
...
🤔 tdb3 reviewed a pull request: "test: Add a few more corner cases to the base58 test suite"
(https://github.com/bitcoin/bitcoin/pull/30035#pullrequestreview-2039756843)
ACK for 9431bc94a19837a0b053fbbde9f5367543a7264e
Built and ran unit tests (all passed).
Left one nit, but the nit is outside the scope of this PR, so is probably better left to a separate PR.
(https://github.com/bitcoin/bitcoin/pull/30035#pullrequestreview-2039756843)
ACK for 9431bc94a19837a0b053fbbde9f5367543a7264e
Built and ran unit tests (all passed).
Left one nit, but the nit is outside the scope of this PR, so is probably better left to a separate PR.
💬 tdb3 commented on pull request "test: Add a few more corner cases to the base58 test suite":
(https://github.com/bitcoin/bitcoin/pull/30035#discussion_r1590372865)
nit: Probably outside the scope of this PR (this PR is adding tests, so business logic changes are extraneous), but at first glance, seems like these statements could be simplified, since `InsecureRandRange()` can return 0, the `std::string` constructor can handle 0 count, and string operator+ can handle empty string addition. Maybe I'm missing something?
For example:
```diff
diff --git a/src/test/base58_tests.cpp b/src/test/base58_tests.cpp
index 49ef9ff5b5..beb5ef3335 100644
--- a/s
...
(https://github.com/bitcoin/bitcoin/pull/30035#discussion_r1590372865)
nit: Probably outside the scope of this PR (this PR is adding tests, so business logic changes are extraneous), but at first glance, seems like these statements could be simplified, since `InsecureRandRange()` can return 0, the `std::string` constructor can handle 0 count, and string operator+ can handle empty string addition. Maybe I'm missing something?
For example:
```diff
diff --git a/src/test/base58_tests.cpp b/src/test/base58_tests.cpp
index 49ef9ff5b5..beb5ef3335 100644
--- a/s
...
💬 vasild commented on pull request "Logging cleanup":
(https://github.com/bitcoin/bitcoin/pull/29798#issuecomment-2094893646)
`bee22409ea...df2422c5f9`: fix CI
this compiles locally but not on the CI:
```cpp
ret.emplace_back(category, WillLogCategory(flag));
```
so instead use:
```cpp
ret.push_back(LogCategory{.category = category, .active = WillLogCategory(flag)});
```
(https://github.com/bitcoin/bitcoin/pull/29798#issuecomment-2094893646)
`bee22409ea...df2422c5f9`: fix CI
this compiles locally but not on the CI:
```cpp
ret.emplace_back(category, WillLogCategory(flag));
```
so instead use:
```cpp
ret.push_back(LogCategory{.category = category, .active = WillLogCategory(flag)});
```