💬 hebasto commented on pull request "refactor, test: Always initialize pointer":
(https://github.com/bitcoin/bitcoin/pull/30026#issuecomment-2092445651)
cc @sipsorcery
(https://github.com/bitcoin/bitcoin/pull/30026#issuecomment-2092445651)
cc @sipsorcery
💬 willcl-ark commented on pull request "doc: fix broken relative md links":
(https://github.com/bitcoin/bitcoin/pull/30025#discussion_r1588835918)
I wanted to but those links a few lines [above](https://github.com/bitcoin/bitcoin/pull/30025/files/8b3e86285f55d484e71a821a2c4538b2f010be59#diff-b5e0af5339b28c1c6c155d36f0157c62232fd994410334fb09bd7511fef12074R85) were relative so I just thought I'd leave these matching 😢
Will do it now with the other suggestion.
(https://github.com/bitcoin/bitcoin/pull/30025#discussion_r1588835918)
I wanted to but those links a few lines [above](https://github.com/bitcoin/bitcoin/pull/30025/files/8b3e86285f55d484e71a821a2c4538b2f010be59#diff-b5e0af5339b28c1c6c155d36f0157c62232fd994410334fb09bd7511fef12074R85) were relative so I just thought I'd leave these matching 😢
Will do it now with the other suggestion.
🚀 fanquake merged a pull request: "opportunistic 1p1c followups"
(https://github.com/bitcoin/bitcoin/pull/30012)
(https://github.com/bitcoin/bitcoin/pull/30012)
💬 willcl-ark commented on pull request "doc: fix broken relative md links":
(https://github.com/bitcoin/bitcoin/pull/30025#discussion_r1588841012)
Done in 8e394d1d3b6ead130515222f5b34d509fff200a8
(https://github.com/bitcoin/bitcoin/pull/30025#discussion_r1588841012)
Done in 8e394d1d3b6ead130515222f5b34d509fff200a8
💬 willcl-ark commented on pull request "doc: fix broken relative md links":
(https://github.com/bitcoin/bitcoin/pull/30025#discussion_r1588841131)
Done in 8e394d1d3b6ead130515222f5b34d509fff200a8
(https://github.com/bitcoin/bitcoin/pull/30025#discussion_r1588841131)
Done in 8e394d1d3b6ead130515222f5b34d509fff200a8
💬 virtu commented on issue "DNS seed "seed.bitcoinstats.com" doesn't support filtering while the comments says it does":
(https://github.com/bitcoin/bitcoin/issues/29911#issuecomment-2092467040)
> I have stopped using these DNS seeds. I found only 2 useful when I last tested:
>
> seed.bitcoin.sipa.be seed.bitcoin.wiz.biz
I'm not sure the overall situation is that bad. [It looks like](https://21.ninja/dns-seeds/reachable-share/) at all times, at least two thirds of DNS seeds are returning ~70-99% reachable nodes.
[Individual seeders have issues on occasion](https://21.ninja/dns-seeds/stale-share/), but that's not really a problem if they're fixed eventually.
Since I'm monitor
...
(https://github.com/bitcoin/bitcoin/issues/29911#issuecomment-2092467040)
> I have stopped using these DNS seeds. I found only 2 useful when I last tested:
>
> seed.bitcoin.sipa.be seed.bitcoin.wiz.biz
I'm not sure the overall situation is that bad. [It looks like](https://21.ninja/dns-seeds/reachable-share/) at all times, at least two thirds of DNS seeds are returning ~70-99% reachable nodes.
[Individual seeders have issues on occasion](https://21.ninja/dns-seeds/stale-share/), but that's not really a problem if they're fixed eventually.
Since I'm monitor
...
💬 willcl-ark commented on pull request "Fix misleading signmessage error with segwit":
(https://github.com/bitcoin-core/gui/pull/819#discussion_r1588846482)
Thanks hebasto, I hadn't seen that in progress. Went for the latter suggestion in fb9f150759b22772dd48983a2be1ea397245e289 as it seems to be preferred by marco in the other PR.
(https://github.com/bitcoin-core/gui/pull/819#discussion_r1588846482)
Thanks hebasto, I hadn't seen that in progress. Went for the latter suggestion in fb9f150759b22772dd48983a2be1ea397245e289 as it seems to be preferred by marco in the other PR.
💬 fanquake commented on pull request "build: add `-Wundef`":
(https://github.com/bitcoin/bitcoin/pull/29876#issuecomment-2092476469)
Rebased on #25972. Please review that first.
> I suggest to consider updating a help string in
I don't touch that here, and it's not clear why we need to change a single instsance out of many help strings that could be similarly updated, so going to leave things as they are.
(https://github.com/bitcoin/bitcoin/pull/29876#issuecomment-2092476469)
Rebased on #25972. Please review that first.
> I suggest to consider updating a help string in
I don't touch that here, and it's not clear why we need to change a single instsance out of many help strings that could be similarly updated, so going to leave things as they are.
📝 fanquake converted_to_draft a pull request: "build: add `-Wundef`"
(https://github.com/bitcoin/bitcoin/pull/29876)
Turn on `-Wundef`.
[> Warn if an undefined identifier is evaluated in an #if directive. Such identifiers are replaced with zero.](https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wundef).
Note that this is still beneficial with CMake, and may even be nice to have enabled prior, to catch any change in behaviour.
If we end up with this enabled, it should probably be enough to fix #16419.
Based on #25972.
(https://github.com/bitcoin/bitcoin/pull/29876)
Turn on `-Wundef`.
[> Warn if an undefined identifier is evaluated in an #if directive. Such identifiers are replaced with zero.](https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wundef).
Note that this is still beneficial with CMake, and may even be nice to have enabled prior, to catch any change in behaviour.
If we end up with this enabled, it should probably be enough to fix #16419.
Based on #25972.
💬 Sjors commented on pull request "Testnet4 including PoW difficulty adjustment fix":
(https://github.com/bitcoin/bitcoin/pull/29775#issuecomment-2092479201)
The genesis block title by @jlopp is great. It refers to a failure of the previous thing. If people start to value testnet4 coins to the extend where its genesis block coinbase message is considered precious advertising space, then we need to reset it again.
Where does the public key come from?
> require min difficulty blocks to record the real difficulty in the nVersion field, and use that to calculate the expected difficulty for the next retarget period directly without having to search
...
(https://github.com/bitcoin/bitcoin/pull/29775#issuecomment-2092479201)
The genesis block title by @jlopp is great. It refers to a failure of the previous thing. If people start to value testnet4 coins to the extend where its genesis block coinbase message is considered precious advertising space, then we need to reset it again.
Where does the public key come from?
> require min difficulty blocks to record the real difficulty in the nVersion field, and use that to calculate the expected difficulty for the next retarget period directly without having to search
...
💬 willcl-ark commented on issue "qa: Support git worktrees when running the linters locally via Docker":
(https://github.com/bitcoin/bitcoin/issues/29972#issuecomment-2092489093)
Update:
To avoid creating root-owned mypy files you can run the container with your user:group specified:
```bash
DOCKER_BUILDKIT=1 docker build -t bitcoin-linter --file "./ci/lint_imagefile" ./ && GIT_DIR=$(git rev-parse --path-format=absolute --git-common-dir) docker run --rm -v $(pwd):/bitcoin -v "$GIT_DIR":"$GIT_DIR" -u $(id -u):$(id -g) -it bitcoin-linter
```
This allows `git worktree remove` to succeed.
(https://github.com/bitcoin/bitcoin/issues/29972#issuecomment-2092489093)
Update:
To avoid creating root-owned mypy files you can run the container with your user:group specified:
```bash
DOCKER_BUILDKIT=1 docker build -t bitcoin-linter --file "./ci/lint_imagefile" ./ && GIT_DIR=$(git rev-parse --path-format=absolute --git-common-dir) docker run --rm -v $(pwd):/bitcoin -v "$GIT_DIR":"$GIT_DIR" -u $(id -u):$(id -g) -it bitcoin-linter
```
This allows `git worktree remove` to succeed.
💬 Sjors commented on pull request "Stratum v2 Template Provider (take 3)":
(https://github.com/bitcoin/bitcoin/pull/29432#issuecomment-2092515772)
(ignoring CI failure, as I mentioned above I plan on making the tests more robust after #26812)
(https://github.com/bitcoin/bitcoin/pull/29432#issuecomment-2092515772)
(ignoring CI failure, as I mentioned above I plan on making the tests more robust after #26812)
💬 sipsorcery commented on pull request "refactor, test: Always initialize pointer":
(https://github.com/bitcoin/bitcoin/pull/30026#issuecomment-2092525878)
utACK bd2de7ac591d7704b79304089ad1fb57e085da8b.
(https://github.com/bitcoin/bitcoin/pull/30026#issuecomment-2092525878)
utACK bd2de7ac591d7704b79304089ad1fb57e085da8b.
💬 Sjors commented on pull request "Testnet4 including PoW difficulty adjustment fix":
(https://github.com/bitcoin/bitcoin/pull/29775#discussion_r1588924764)
By the way, even if we do implement a higher minimum difficult, imo this should be done in `chainparams.cpp` by setting `consensus.powLimit`. If that makes it harder to grind a genesis block, perhaps that's a good reason not change it.
(https://github.com/bitcoin/bitcoin/pull/29775#discussion_r1588924764)
By the way, even if we do implement a higher minimum difficult, imo this should be done in `chainparams.cpp` by setting `consensus.powLimit`. If that makes it harder to grind a genesis block, perhaps that's a good reason not change it.
💬 Sjors commented on pull request "Testnet4 including PoW difficulty adjustment fix":
(https://github.com/bitcoin/bitcoin/pull/29775#discussion_r1588881978)
4e8b29ae234a05181ff9fd64ab3a74ba997e2eac: you can add `seed.testnet4.bitcoin.sprovoost.nl` here. I'll update it if the magic bytes change.
(https://github.com/bitcoin/bitcoin/pull/29775#discussion_r1588881978)
4e8b29ae234a05181ff9fd64ab3a74ba997e2eac: you can add `seed.testnet4.bitcoin.sprovoost.nl` here. I'll update it if the magic bytes change.
⚠️ maflcko opened an issue: "ci: Support running from a worktree"
(https://github.com/bitcoin/bitcoin/issues/30028)
Currently, when running the CI from a worktree, it will fail with:
```
++ git config --global ci.base-install-done
fatal: not a git repository: .git/worktrees/test2
```
`git config --global` is used here, because it allows to write a flag to storage on macOS and Linux. If someone knows of a different way to persist a flag on macOS and Linux, it should be used instead.
(https://github.com/bitcoin/bitcoin/issues/30028)
Currently, when running the CI from a worktree, it will fail with:
```
++ git config --global ci.base-install-done
fatal: not a git repository: .git/worktrees/test2
```
`git config --global` is used here, because it allows to write a flag to storage on macOS and Linux. If someone knows of a different way to persist a flag on macOS and Linux, it should be used instead.
💬 maflcko commented on pull request "doc: fix broken relative md links":
(https://github.com/bitcoin/bitcoin/pull/30025#issuecomment-2092630176)
ACK 8e394d1d3b6ead130515222f5b34d509fff200a8
(https://github.com/bitcoin/bitcoin/pull/30025#issuecomment-2092630176)
ACK 8e394d1d3b6ead130515222f5b34d509fff200a8
💬 maflcko commented on pull request "doc: fix broken relative md links":
(https://github.com/bitcoin/bitcoin/pull/30025#issuecomment-2092630583)
Is there an easy way to find those?
(https://github.com/bitcoin/bitcoin/pull/30025#issuecomment-2092630583)
Is there an easy way to find those?
🤔 ismaelsadeeq reviewed a pull request: "doc: fix broken relative md links"
(https://github.com/bitcoin/bitcoin/pull/30025#pullrequestreview-2037752097)
utACK 8e394d1d3b6ead130515222f5b34d509fff200a8
(https://github.com/bitcoin/bitcoin/pull/30025#pullrequestreview-2037752097)
utACK 8e394d1d3b6ead130515222f5b34d509fff200a8
💬 maflcko commented on issue "qa: Support git worktrees when running the linters locally via Docker":
(https://github.com/bitcoin/bitcoin/issues/29972#issuecomment-2092643562)
> To avoid creating root-owned mypy files
Probably unrelated, but ideally, I'd say that the container should not modify anything on the host. The "real" CI script use a `readonly` `--mount`.
If something needs to be cached, it can be done in a persisted volume?
(https://github.com/bitcoin/bitcoin/issues/29972#issuecomment-2092643562)
> To avoid creating root-owned mypy files
Probably unrelated, but ideally, I'd say that the container should not modify anything on the host. The "real" CI script use a `readonly` `--mount`.
If something needs to be cached, it can be done in a persisted volume?