🤔 theStack reviewed a pull request: "rpc: Optimize serialization and enhance metadata of dumptxoutset output"
(https://github.com/bitcoin/bitcoin/pull/29612#pullrequestreview-2034745114)
Concept ACK on the enhanced metadata, I think this includes now everything we need. Will update #27432 in a bit to the new format and test.

💬 theStack commented on pull request "rpc: Optimize serialization and enhance metadata of dumptxoutset output":
(https://github.com/bitcoin/bitcoin/pull/29612#discussion_r1587015761)
nit: could use `std::array`, and use its methods (`.begin()`, `.end()`, `.size()`) in `Unserialize` below to avoid magic numbers
```suggestion
static constexpr std::array<uint8_t, 5> SNAPSHOT_MAGIC_BYTES = {'u', 't', 'x', 'o', 0xff};
```

💬 theStack commented on pull request "rpc: Optimize serialization and enhance metadata of dumptxoutset output":
(https://github.com/bitcoin/bitcoin/pull/29612#discussion_r1587030435)
nit: for variables that are (de)serialized, it's imho preferred if the data type size is explicit
```suggestion
uint32_t m_base_blockheight;
```

💬 fanquake commented on pull request "opportunistic 1p1c followups":
(https://github.com/bitcoin/bitcoin/pull/30012#issuecomment-2089494872)
Can this also address:
```bash
txorphanage.cpp:281:21: error: loop variable 'child_iter' creates a copy from type '__gnu_debug::_Safe_iterator<std::_Rb_tree_iterator<std::pair<const transaction_identifier<false>, TxOrphanage::OrphanTx>>, std::map<transaction_identifier<false>, TxOrphanage::OrphanTx>> const' [-Werror,-Wrange-loop-construct]
281 | for (const auto child_iter : iters) {
| ^
txorphanage.cpp:281:10: note: use reference type '__gnu_debug::_Safe_iter
...

⚠️ dominicusadinfinitum opened an issue: "Testsuite for Bitcoin Core 27.0.0 - FAIL: qt/test/test_bitcoin-qt"
(https://github.com/bitcoin/bitcoin/issues/30020)
### Is there an existing issue for this?

- [X] I have searched the existing issues

### Current behaviour

FAIL: qt/test/test_bitcoin-qt
============================================================================
Testsuite summary for Bitcoin Core 27.0.0
============================================================================
# TOTAL: 4
# PASS: 3
# SKIP: 0
# XFAIL: 0
# FAIL: 1
# XPASS: 0
# ERROR: 0
============================================================================

...

💬 laanwj commented on issue "Objdump can't parse our Linux debug information":
(https://github.com/bitcoin/bitcoin/issues/30016#issuecomment-2089648774)
Reopening with more accurate title (phew).

Filed upstream issue: https://sourceware.org/bugzilla/show_bug.cgi?id=31692

⚠️ laanwj reopened an issue: "Objdump can't parse our Linux debug information"
(https://github.com/bitcoin/bitcoin/issues/30016)
The debug information in the shipped `.dbg` artifacts seems to be unusable. The `.debug_info` section is corrupt:
```sh
$ tar -zxvf bitcoin-27.0-x86_64-linux-gnu-debug.tar.gz
$ objdump -Wi bitcoin-27.0/bin/bitcoin-cli.dbg

Section '.debug_info' has an invalid size: 0.

bitcoin-27.0/bin/bitcoin-cli.dbg: file format elf64-x86-64

Section '.debug_info' has an invalid size: 0.
```
i've checked various Linux architectures (at least x86_64, ARM, RISC-V) and the same issue exists there.
...

🔓 laanwj unlocked an issue: "ops: Enable DNSSEC on all Bitcoin DNS Seed domain names"
(https://github.com/bitcoin/bitcoin/issues/19714)

💬 laanwj commented on pull request "chainparams: Add achow101 DNS seeder":
(https://github.com/bitcoin/bitcoin/pull/30007#issuecomment-2089734623)
> By the way, it would be great if mainnet DNS seeders are considering to sign by default the peers records. This could be amply checked in ThreadDNSAddressSeed()

There are some that do (#19714), but as far as i know, there is no cross-platform API for checking DNSSEC status from user code. i've unlocked that issue for discussion.

🚀 fanquake merged a pull request: "doc: add LLVM instruction for macOS < 13"
(https://github.com/bitcoin/bitcoin/pull/29934)

💬 fanquake commented on pull request "doc: add LLVM instruction for macOS < 13":
(https://github.com/bitcoin/bitcoin/pull/29934#issuecomment-2089797203)
Backported in #29888.

💬 fanquake commented on issue "Objdump can't parse our Linux debug information":
(https://github.com/bitcoin/bitcoin/issues/30016#issuecomment-2089817055)
> Interestingly, the Windows build is unaffected. Maybe because of a different gcc/binutils?

This is probably because the Windows Binutils is configured without support for compressed debug sections, as it was, iirc, causing other windows build issues.

💬 laanwj commented on issue "Objdump can't parse our Linux debug information":
(https://github.com/bitcoin/bitcoin/issues/30016#issuecomment-2089825825)
> This is probably because the Windows Binutils is configured without support for compressed debug sections, as it was, iirc, causing other windows build issues.

Right, that makes sense. DWARF in PE binaires is a quite peculiar concept in the first place--heck, GNU even has its own way to encode the long section names needed: lief-project/LIEF#1043. i'm not surprised it's not set up to handle compressed sections.

💬 maflcko commented on issue "Testsuite for Bitcoin Core 27.0.0 - FAIL: qt/test/test_bitcoin-qt":
(https://github.com/bitcoin/bitcoin/issues/30020#issuecomment-2089875159)
> [test-suite.log](https://github.com/bitcoin/bitcoin/files/15184292/test-suite.log)

The file is empty. If it is less than 100 lines, you can put it in a comment here.

💬 maflcko commented on pull request "refactor, fuzz: Make 64-bit shift explicit":
(https://github.com/bitcoin/bitcoin/pull/30017#issuecomment-2089890554)
utACK b50d127a7710d790c2ba4a08f01b832c2a0b1203

💬 Ayush170-Future commented on pull request "fuzz: wallet, add target for `Crypter`":
(https://github.com/bitcoin/bitcoin/pull/28074#issuecomment-2089900313)
Fixed the `lint` issue

💬 maflcko commented on issue "Manually Banning Peers Results in Crash":
(https://github.com/bitcoin/bitcoin/issues/29916#issuecomment-2089900690)
That screenshot looks like a CPU-eating bug in the gui code. I think "not responding" is different from "crash".

In any case, if this really is a crash, you can get the traceback with something like:

```
gdb --args .../bitcoin-qt

...

> run
```

Then recreate the crash and check the output in the terminal.

💬 Sjors commented on pull request "Silent Payments: Implement BIP352":
(https://github.com/bitcoin/bitcoin/pull/28122#issuecomment-2089904408)
@josibake can you add a link to https://github.com/bitcoin-core/secp256k1/pull/1519 in the PR description? It currently takes a few "load more" clicks and searching to see what this PR depends on.

💬 hebasto commented on pull request "refactor, fuzz: Make 64-bit shift explicit":
(https://github.com/bitcoin/bitcoin/pull/30017#issuecomment-2089929473)
cc @sipsorcery

💬 Sjors commented on pull request "[PoC, nomerge] IPv6 PCP pinhole test":
(https://github.com/bitcoin/bitcoin/pull/30005#issuecomment-2089935185)
Ah, that's confusing. The OPNsense is indeed just [MiniUPnPd](https://miniupnp.tuxfamily.org/) and described as "Universal Plug and Play (UPnP IGD & PCP/NAT-PMP) Service", in other words: all the things :-)

It lets you choose what to enable, in this case I selected "PCP/NAT-PMP Port Mapping".

Now your utility is happy.

On Ubuntu I additionally had to do `sudo ufw allow 1234` though for the nc connection to succeed.