💬 hebasto commented on pull request "build: Enable fuzz binary in MSVC":
(https://github.com/bitcoin/bitcoin/pull/29774#issuecomment-2088542186)
Ported to the CMake-based build system in https://github.com/hebasto/bitcoin/pull/182.

💬 hebasto commented on pull request "msvc: Compile `test\fuzz\bitdeque.cpp`":
(https://github.com/bitcoin/bitcoin/pull/29983#issuecomment-2088542608)
Ported to the CMake-based build system in https://github.com/hebasto/bitcoin/pull/182.

👍 theuni approved a pull request: "depends: build miniupnpc with CMake"
(https://github.com/bitcoin/bitcoin/pull/29707#pullrequestreview-2033750290)
ACK 5195baa60087ee366290887ad982fc491e14c111.

Compile-tested for Linux, output looks good for debug and release builds.

💬 sr-gi commented on pull request "fuzz: txorphan tests fixups":
(https://github.com/bitcoin/bitcoin/pull/29974#issuecomment-2088609051)
Updated the approach to get rid of `duplicate_input` altogether, simplifying the test and reducing the boilerplate when dealing with duplicate outpoints

💬 sr-gi commented on pull request "fuzz: txorphan tests fixups":
(https://github.com/bitcoin/bitcoin/pull/29974#discussion_r1586409508)
I updated the approach to get rid of `duplicate_inputs` altogether. Let me know if this make more sense to you now

👍 alfonsoromanz approved a pull request: "assumeutxo: Add dumptxoutset height param, remove shell scripts"
(https://github.com/bitcoin/bitcoin/pull/29553#pullrequestreview-2033825476)
Code Review and Tested ACK c83d7a5dec3595abe4cc6c8dcb29a016c6905a98. My impression is that this PR is good enough as is, unless there is a specific issue with `invalidate`/`reconsider` block that I am not aware of.

This will not only prevent errors (by internalizing and testing code previously ran in scripts) but will also offer an easy way for users to create a snapshot from a specific height via RPC. If the rollback functionality gets implemented after this PR is merged, it seems straightf
...

💬 pinheadmz commented on pull request "Support JSON-RPC 2.0 when requested by client":
(https://github.com/bitcoin/bitcoin/pull/27101#discussion_r1586429889)
Added the explicit arguments to the calls in bitcoin-cli.cpp, so far that's the only change i made to your branch

💬 achow101 commented on pull request "chainparams: Add achow101 DNS seeder":
(https://github.com/bitcoin/bitcoin/pull/30007#issuecomment-2088674586)
> A TTL of 30 seconds is low compared to the others. FWIW, in [dnsseed-policy.md](https://github.com/bitcoin/bitcoin/blob/master/doc/dnsseed-policy.md) a minimum of 60 seconds is mentioned.

I've changed it to 60 seconds.

💬 vasild commented on pull request "Broadcast own transactions only via short-lived Tor or I2P connections":
(https://github.com/bitcoin/bitcoin/pull/29415#discussion_r1586454646)
This was triggered in the fuzz tests. I could complicate the fuzz tests to avoid sending unwanted messages if the random node happens to be a private broadcast, but `CConnman::PushMessage()` is called from a lot of places including from the RPC and that may change in the future as well. It is somewhat hard to judge that nobody will call `PushMessage()` with an unwanted message. Thus I think it is better to assume that this is the real check here in `CConnman::PushMessage()` and that the one in `
...

👍 TheCharlatan approved a pull request: "depends: build miniupnpc with CMake"
(https://github.com/bitcoin/bitcoin/pull/29707#pullrequestreview-2033882346)
utACK 5195baa60087ee366290887ad982fc491e14c111

Guix builds (aarch64)
```
fb77af7f4d684e28e9eecc7680af6aec9f6789921d87c49673c51c917b1fe2ed guix-build-5195baa60087/output/aarch64-linux-gnu/SHA256SUMS.part
8962d6eb216e19c95e9f90ec1e879e309d3bbed62a1cb91b67b2155956580a50 guix-build-5195baa60087/output/aarch64-linux-gnu/bitcoin-5195baa60087-aarch64-linux-gnu-debug.tar.gz
f2dd00f3502e32dd50f232178aa77e63f09359ac303f2309491cb8c08d2b4f15 guix-build-5195baa60087/output/aarch64-linux-gnu/bitcoin
...

👋 glozow's pull request is ready for review: "policy: restrict all TRUC (v3) transactions to 25KvB"
(https://github.com/bitcoin/bitcoin/pull/29873)

💬 dupontcy commented on issue "Change estimate_mode default to "ECONOMICAL" in these RPC calls":
(https://github.com/bitcoin/bitcoin/issues/30009#issuecomment-2088717254)
> Unfortunately even "economic" mode still overestimate so changing default mode to "economic" does not fix this issue.

Maybe it does not fix it all together, but it makes it overestimate less.

The difference between ECONOMICAL and CONSERVATIVE for a confirmation target of 2 to 12 blocks is HUGE (by a factor of 7)
Here is recent data from our node with a confirmation target of 2 blocks
ECONOMICAL: 0.00020106
CONSERVATIVE: 0.00141359

The CONSERVATIVE mode uses the long stats for
...

💬 mzumsande commented on pull request "chainparams: Add achow101 DNS seeder":
(https://github.com/bitcoin/bitcoin/pull/30007#issuecomment-2088726919)
@virtu FYI, would it be easily possible to run some of the metrics of https://21.ninja/dns-seeds/ for this new seeder?

💬 mzumsande commented on pull request "net: Make AddrFetch connections to fixed seeds":
(https://github.com/bitcoin/bitcoin/pull/26114#issuecomment-2088732123)
[d8df9f9 ](https://github.com/bitcoin/bitcoin/commit/d8df9f94f933c9d5fd19a58a4b1473ea9becd362)to [c07bfae](https://github.com/bitcoin/bitcoin/commit/c07bfae27718da97322d22bc05db6af1176f738a): Rebased

🤔 instagibbs reviewed a pull request: "p2p: index TxOrphanage by wtxid, allow entries with same txid"
(https://github.com/bitcoin/bitcoin/pull/30000#pullrequestreview-2033911780)
code changes are quite mechanical, thankfully

concept ACK

💬 instagibbs commented on pull request "p2p: index TxOrphanage by wtxid, allow entries with same txid":
(https://github.com/bitcoin/bitcoin/pull/30000#discussion_r1586473749)
```Suggestion
if (m_orphanage.HaveTx(Wtxid::FromUint256(hash))) return true;
```

💬 BullishNode commented on issue "Change estimate_mode default to "ECONOMICAL" in these RPC calls":
(https://github.com/bitcoin/bitcoin/issues/30009#issuecomment-2088788922)
Agreed that switching to economical is not a long-term fix for fee estimation, but it's still a notable improvement. Implementing this change would likely lead to a very noticeable reduction in fees paid by Bitcoin Core users, and users of Bitcoin Core fee estimation, and Bitcoin users as a whole.

To give an idea of how much this affects a business which does a lot of Bitcoin transaction, we actually created software that will pull the recomended fees from the mempool api and we feed that to
...

💬 laanwj commented on pull request "doc: Remove outdated description for --port argument":
(https://github.com/bitcoin/bitcoin/pull/30014#issuecomment-2088796987)
Does anyone have concrete statistics on this? Or even anecdotes?
i would imagine nodes on non-standard ports still get significantly less connections, if not the least because the DNS seeds don't support them.

💬 laanwj commented on pull request "lint: [doc] Clarify Windows line endings (CR LF) not to be used":
(https://github.com/bitcoin/bitcoin/pull/30010#issuecomment-2088798660)
Yes, this makes sense, having a mix of linux and windows line endings in the respository would be a mess.

📝 Shaxrux1811 opened a pull request: "Initial commit"
(https://github.com/bitcoin/bitcoin/pull/30015)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...