📝 shinghim converted_to_draft a pull request: "doc: Remove outdated description for --port argument"
(https://github.com/bitcoin/bitcoin/pull/30014)
Removing an outdated sentence in the argument description for the --port argument. The note says to wait until changes in #23542 have become widespread, which I think has happened since those changes were merged over two years ago on March 2, 2022

💬 vasild commented on pull request "Broadcast own transactions only via short-lived Tor or I2P connections":
(https://github.com/bitcoin/bitcoin/pull/29415#discussion_r1586318759)
Added `Assume(false)` and a comment.

💬 vasild commented on pull request "Broadcast own transactions only via short-lived Tor or I2P connections":
(https://github.com/bitcoin/bitcoin/pull/29415#discussion_r1586319178)
Yes, I was thinking the same. Moved away.

💬 vasild commented on pull request "Broadcast own transactions only via short-lived Tor or I2P connections":
(https://github.com/bitcoin/bitcoin/pull/29415#discussion_r1586319383)
Removed.

💬 vasild commented on pull request "Broadcast own transactions only via short-lived Tor or I2P connections":
(https://github.com/bitcoin/bitcoin/pull/29415#discussion_r1586319507)
Updated.

💬 vasild commented on pull request "Broadcast own transactions only via short-lived Tor or I2P connections":
(https://github.com/bitcoin/bitcoin/pull/29415#discussion_r1586320176)
To avoid negative values. I added a comment in the source code to explain.

👋 shinghim's pull request is ready for review: "doc: Remove outdated description for --port argument"
(https://github.com/bitcoin/bitcoin/pull/30014)

💬 furszy commented on pull request "net: introduce block tracker to retry to download blocks after failure":
(https://github.com/bitcoin/bitcoin/pull/27837#discussion_r1586351758)
fixed

💬 glozow commented on pull request "p2p: opportunistically accept 1-parent-1-child packages":
(https://github.com/bitcoin/bitcoin/pull/28970#discussion_r1586354156)
^I added this to #30012

💬 pinheadmz commented on pull request "Support JSON-RPC 2.0 when requested by client":
(https://github.com/bitcoin/bitcoin/pull/27101#discussion_r1586354746)
ok thanks, originally I wanted to use a default value to ensure that bitcoin-cli continued to work without any changes

💬 hebasto commented on pull request "build: Enable fuzz binary in MSVC":
(https://github.com/bitcoin/bitcoin/pull/29774#issuecomment-2088542186)
Ported to the CMake-based build system in https://github.com/hebasto/bitcoin/pull/182.

💬 hebasto commented on pull request "msvc: Compile `test\fuzz\bitdeque.cpp`":
(https://github.com/bitcoin/bitcoin/pull/29983#issuecomment-2088542608)
Ported to the CMake-based build system in https://github.com/hebasto/bitcoin/pull/182.

👍 theuni approved a pull request: "depends: build miniupnpc with CMake"
(https://github.com/bitcoin/bitcoin/pull/29707#pullrequestreview-2033750290)
ACK 5195baa60087ee366290887ad982fc491e14c111.

Compile-tested for Linux, output looks good for debug and release builds.

💬 sr-gi commented on pull request "fuzz: txorphan tests fixups":
(https://github.com/bitcoin/bitcoin/pull/29974#issuecomment-2088609051)
Updated the approach to get rid of `duplicate_input` altogether, simplifying the test and reducing the boilerplate when dealing with duplicate outpoints

💬 sr-gi commented on pull request "fuzz: txorphan tests fixups":
(https://github.com/bitcoin/bitcoin/pull/29974#discussion_r1586409508)
I updated the approach to get rid of `duplicate_inputs` altogether. Let me know if this make more sense to you now

👍 alfonsoromanz approved a pull request: "assumeutxo: Add dumptxoutset height param, remove shell scripts"
(https://github.com/bitcoin/bitcoin/pull/29553#pullrequestreview-2033825476)
Code Review and Tested ACK c83d7a5dec3595abe4cc6c8dcb29a016c6905a98. My impression is that this PR is good enough as is, unless there is a specific issue with `invalidate`/`reconsider` block that I am not aware of.

This will not only prevent errors (by internalizing and testing code previously ran in scripts) but will also offer an easy way for users to create a snapshot from a specific height via RPC. If the rollback functionality gets implemented after this PR is merged, it seems straightf
...

💬 pinheadmz commented on pull request "Support JSON-RPC 2.0 when requested by client":
(https://github.com/bitcoin/bitcoin/pull/27101#discussion_r1586429889)
Added the explicit arguments to the calls in bitcoin-cli.cpp, so far that's the only change i made to your branch

💬 achow101 commented on pull request "chainparams: Add achow101 DNS seeder":
(https://github.com/bitcoin/bitcoin/pull/30007#issuecomment-2088674586)
> A TTL of 30 seconds is low compared to the others. FWIW, in [dnsseed-policy.md](https://github.com/bitcoin/bitcoin/blob/master/doc/dnsseed-policy.md) a minimum of 60 seconds is mentioned.

I've changed it to 60 seconds.

💬 vasild commented on pull request "Broadcast own transactions only via short-lived Tor or I2P connections":
(https://github.com/bitcoin/bitcoin/pull/29415#discussion_r1586454646)
This was triggered in the fuzz tests. I could complicate the fuzz tests to avoid sending unwanted messages if the random node happens to be a private broadcast, but `CConnman::PushMessage()` is called from a lot of places including from the RPC and that may change in the future as well. It is somewhat hard to judge that nobody will call `PushMessage()` with an unwanted message. Thus I think it is better to assume that this is the real check here in `CConnman::PushMessage()` and that the one in `
...

👍 TheCharlatan approved a pull request: "depends: build miniupnpc with CMake"
(https://github.com/bitcoin/bitcoin/pull/29707#pullrequestreview-2033882346)
utACK 5195baa60087ee366290887ad982fc491e14c111

Guix builds (aarch64)
```
fb77af7f4d684e28e9eecc7680af6aec9f6789921d87c49673c51c917b1fe2ed guix-build-5195baa60087/output/aarch64-linux-gnu/SHA256SUMS.part
8962d6eb216e19c95e9f90ec1e879e309d3bbed62a1cb91b67b2155956580a50 guix-build-5195baa60087/output/aarch64-linux-gnu/bitcoin-5195baa60087-aarch64-linux-gnu-debug.tar.gz
f2dd00f3502e32dd50f232178aa77e63f09359ac303f2309491cb8c08d2b4f15 guix-build-5195baa60087/output/aarch64-linux-gnu/bitcoin
...