💬 hebasto commented on pull request "refactor: Use our own implementation of urlDecode":
(https://github.com/bitcoin/bitcoin/pull/29904#issuecomment-2088465111)
Ported to the CMake-based build system in https://github.com/hebasto/bitcoin/pull/181.

💬 vasild commented on pull request "Broadcast own transactions only via short-lived Tor or I2P connections":
(https://github.com/bitcoin/bitcoin/pull/29415#issuecomment-2088480026)
`fd603b8f5c...42cb080600`: rebase and address suggestions

📝 shinghim opened a pull request: "doc: Remove outdated description for --port argument"
(https://github.com/bitcoin/bitcoin/pull/30014)
Removing an outdated sentence in the argument description for the --port argument. The note says to wait until #23542 have become widespread, which I think has happened since those changes were merged over two years ago on March 2, 2022

💬 vasild commented on pull request "Broadcast own transactions only via short-lived Tor or I2P connections":
(https://github.com/bitcoin/bitcoin/pull/29415#discussion_r1586316212)
Yes, but I did not like the behavior of the wallet "unexpectedly" stopping to broadcast its own transactions because `-privatebroadcast` is enabled.

> It's not the most user-friendly thing to introduce a new command arg that would only work if another arg was also changed from its default.

Yes, I agree. I do not like that either but somewhat prefer it over automatically switching off wallet broadcast. I can imagine GUI users who enable `-privatebroadcast` and still try to send transactions
...

💬 vasild commented on pull request "Broadcast own transactions only via short-lived Tor or I2P connections":
(https://github.com/bitcoin/bitcoin/pull/29415#discussion_r1586317728)
Updated.

💬 vasild commented on pull request "Broadcast own transactions only via short-lived Tor or I2P connections":
(https://github.com/bitcoin/bitcoin/pull/29415#discussion_r1586317921)
Yes, fixed!

📝 shinghim converted_to_draft a pull request: "doc: Remove outdated description for --port argument"
(https://github.com/bitcoin/bitcoin/pull/30014)
Removing an outdated sentence in the argument description for the --port argument. The note says to wait until changes in #23542 have become widespread, which I think has happened since those changes were merged over two years ago on March 2, 2022

💬 vasild commented on pull request "Broadcast own transactions only via short-lived Tor or I2P connections":
(https://github.com/bitcoin/bitcoin/pull/29415#discussion_r1586318759)
Added `Assume(false)` and a comment.

💬 vasild commented on pull request "Broadcast own transactions only via short-lived Tor or I2P connections":
(https://github.com/bitcoin/bitcoin/pull/29415#discussion_r1586319178)
Yes, I was thinking the same. Moved away.

💬 vasild commented on pull request "Broadcast own transactions only via short-lived Tor or I2P connections":
(https://github.com/bitcoin/bitcoin/pull/29415#discussion_r1586319383)
Removed.

💬 vasild commented on pull request "Broadcast own transactions only via short-lived Tor or I2P connections":
(https://github.com/bitcoin/bitcoin/pull/29415#discussion_r1586319507)
Updated.

💬 vasild commented on pull request "Broadcast own transactions only via short-lived Tor or I2P connections":
(https://github.com/bitcoin/bitcoin/pull/29415#discussion_r1586320176)
To avoid negative values. I added a comment in the source code to explain.

👋 shinghim's pull request is ready for review: "doc: Remove outdated description for --port argument"
(https://github.com/bitcoin/bitcoin/pull/30014)

💬 furszy commented on pull request "net: introduce block tracker to retry to download blocks after failure":
(https://github.com/bitcoin/bitcoin/pull/27837#discussion_r1586351758)
fixed

💬 glozow commented on pull request "p2p: opportunistically accept 1-parent-1-child packages":
(https://github.com/bitcoin/bitcoin/pull/28970#discussion_r1586354156)
^I added this to #30012

💬 pinheadmz commented on pull request "Support JSON-RPC 2.0 when requested by client":
(https://github.com/bitcoin/bitcoin/pull/27101#discussion_r1586354746)
ok thanks, originally I wanted to use a default value to ensure that bitcoin-cli continued to work without any changes

💬 hebasto commented on pull request "build: Enable fuzz binary in MSVC":
(https://github.com/bitcoin/bitcoin/pull/29774#issuecomment-2088542186)
Ported to the CMake-based build system in https://github.com/hebasto/bitcoin/pull/182.

💬 hebasto commented on pull request "msvc: Compile `test\fuzz\bitdeque.cpp`":
(https://github.com/bitcoin/bitcoin/pull/29983#issuecomment-2088542608)
Ported to the CMake-based build system in https://github.com/hebasto/bitcoin/pull/182.

👍 theuni approved a pull request: "depends: build miniupnpc with CMake"
(https://github.com/bitcoin/bitcoin/pull/29707#pullrequestreview-2033750290)
ACK 5195baa60087ee366290887ad982fc491e14c111.

Compile-tested for Linux, output looks good for debug and release builds.

💬 sr-gi commented on pull request "fuzz: txorphan tests fixups":
(https://github.com/bitcoin/bitcoin/pull/29974#issuecomment-2088609051)
Updated the approach to get rid of `duplicate_input` altogether, simplifying the test and reducing the boilerplate when dealing with duplicate outpoints