💬 Ayms commented on pull request "Ignore datacarrier limits for dataless OP_RETURN outputs":
(https://github.com/bitcoin/bitcoin/pull/27261#issuecomment-1483171462)
Well, reading this 10 times, I am not sur to see what it has to do with https://github.com/bitcoin/bitcoin/issues/27043

💬 LarryRuane commented on pull request "Add pool based memory resource":
(https://github.com/bitcoin/bitcoin/pull/25325#issuecomment-1483180518)
ACK 9f947fc3d4b779f017332135323b34e8f216f613

💬 hebasto commented on pull request "guix: combine and document `enable_werror`":
(https://github.com/bitcoin/bitcoin/pull/27326#issuecomment-1483200464)
> Document why we don't use `--disable-werror` directly.

Concept ACK on that.

> Combine into `hardened-glibc`.

Not against it, just clarifying. What are benefits of doing that?

📝 SValentyn opened a pull request: "I want more bitcoins! Haven't had time to buy at $0.2 😒"
(https://github.com/bitcoin/bitcoin/pull/27327)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

✅ pinheadmz closed a pull request: "I want more bitcoins! Haven't had time to buy at $0.2 😒"
(https://github.com/bitcoin/bitcoin/pull/27327)

📝 fanquake locked a pull request: "I want more bitcoins! Haven't had time to buy at $0.2 😒"
(https://github.com/bitcoin/bitcoin/pull/27327)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

💬 jnewbery commented on pull request "net: #27257 follow-ups":
(https://github.com/bitcoin/bitcoin/pull/27324#discussion_r1147917681)
Perhaps add a comment on why we don't want to copy `CNetMessage` objects.

💬 fanquake commented on pull request "guix: combine and document `enable_werror`":
(https://github.com/bitcoin/bitcoin/pull/27326#issuecomment-1483233917)
I don't see a reason to keep them separated, need multiple funcs etc. I doubt we'll ever turn -Werror back on here, so `hardened-glibc` is really just how we build glibc.

📝 pinheadmz opened a pull request: "Flag addresses as "active" (or not)"
(https://github.com/bitcoin-core/gui/pull/723)
Closes https://github.com/bitcoin/bitcoin/issues/3314
Requires https://github.com/bitcoin/bitcoin/pull/27216

description WIP

<img width="1322" alt="Screen Shot 2023-03-24 at 2 31 16 PM" src="https://user-images.githubusercontent.com/2084648/227613293-3ad976ba-3b90-4ab5-8cd8-441455e2c6a5.png">

💬 1440000bytes commented on pull request "Ignore datacarrier limits for dataless OP_RETURN outputs":
(https://github.com/bitcoin/bitcoin/pull/27261#issuecomment-1483310633)
> Well, reading this 10 times, I am not sur to see what it has to do with #27043

I assume this was a test run for real pull pull request which will be controversial for sure, dont get mad else some people from this repo might write things about you. Getting mad is only reserved for a few people here.

💬 hebasto commented on pull request "guix: combine and document `enable_werror`":
(https://github.com/bitcoin/bitcoin/pull/27326#issuecomment-1483359577)
> I don't see a reason to keep them separated, need multiple funcs etc.

In the future, if we will have multiple glibc versions again, as it was when you [introduced](https://github.com/bitcoin/bitcoin/pull/25076/commits/c9c5b3060d2edb47ebfa7974fdde3154036717c2) those "multiple funcs", they will be useful again.

I mean, while this change improves code readability, it hurts maintainability a bit, doesn't it?

📝 theuni opened a pull request: "depends: fix osx build with clang 16"
(https://github.com/bitcoin/bitcoin/pull/27328)
Current build (using forced system clang as a test) results in:

> error: unknown argument: '-internal-externc-isystem/opt/clang+llvm-16.0.0-x86_64-linux-gnu-ubuntu-18.04/lib/clang/16/include'

For some reason the previous syntax worked with clang 15 and below, but clang 16 requires that the option and value are properly separated.

See [here for an example of upstream using this syntax](https://github.com/llvm/llvm-project/blob/main/clang/test/Driver/crash-report-with-asserts.c#L9).

Th
...

💬 hebasto commented on pull request "depends: fix osx build with clang 16":
(https://github.com/bitcoin/bitcoin/pull/27328#issuecomment-1483390448)
#27314?

💬 hebasto commented on pull request "build, qt: Fix handling of `CXX=clang++` when building `qt` package":
(https://github.com/bitcoin/bitcoin/pull/27314#issuecomment-1483392086)
The PR descriptions has been updated with Guix build hashes.

👍 TheCharlatan approved a pull request: "depends: qrencode 4.1.1"
(https://github.com/bitcoin/bitcoin/pull/27312)
Code review ACK eb1c3adf38cb71c3e6f298a61871738c4919b4a1

I checked that the additional cflags indeed suppress errors when building with `clang-15`. Also went though the changed configure flags and did a quick sanity check in the gui.

📝 mxaddict opened a pull request: "Added clangd .cache and compile_commands.json to .gitignore"
(https://github.com/bitcoin/bitcoin/pull/27329)
Added cause these were always getting created whenever I was using clangd in the project

💬 willcl-ark commented on pull request "Added clangd .cache and compile_commands.json to .gitignore":
(https://github.com/bitcoin/bitcoin/pull/27329#issuecomment-1483411858)
Concept NACK.

See https://github.com/bitcoin/bitcoin/pull/27275 for how this should be done.

💬 mzumsande commented on issue "test_bitcoin: ./chain.h:261: uint256 CBlockIndex::GetBlockHash() const: Assertion `phashBlock != nullptr' failed.":
(https://github.com/bitcoin/bitcoin/issues/27320#issuecomment-1483430905)
maybe not a cosmic ray after all (#26613)

💬 mxaddict commented on pull request "Added clangd .cache and compile_commands.json to .gitignore":
(https://github.com/bitcoin/bitcoin/pull/27329#issuecomment-1483467694)
>

Makes sense

✅ mxaddict closed a pull request: "Added clangd .cache and compile_commands.json to .gitignore"
(https://github.com/bitcoin/bitcoin/pull/27329)