🤔 tdb3 reviewed a pull request: "test: Fix intermittent issue in wallet_backwards_compatibility.py"
(https://github.com/bitcoin/bitcoin/pull/29982#pullrequestreview-2030034185)
Concept ACK. I would still like to review the logic a bit more. Leaving some test activities as notes:

Tested by performing the following:

Fetched previous releases with `test/get_previous_releases.py -b`, ran all (non-extended) functional tests (with `--previous-releases` to prevent skipping). All passed.

As a very quick/basic santity check for intermittency, executed
```$ test/functional/test_runner.py --cachedir=/mnt/tmp/cache --tmpdir=/mnt/tmp --filter=wallet_backwards_compatib
...

🤔 tdb3 reviewed a pull request: "doc: removed help text saying that peers may not connect automatically"
(https://github.com/bitcoin/bitcoin/pull/29994#pullrequestreview-2030045832)
ACK for 95897ff181c0757e445f0e066a2a590a0a0120d2.

Thank you for circling back to this. Makes sense to me given 23.0+ adoption. Also like how default port values were kept in the message for clarity.

```
$ src/bitcoind -help | grep -A3 " -port="
-port=<port>
Listen for connections on <port> (default: 8333, testnet: 18333, signet:
38333, regtest: 18444). Not relevant for I2P (see doc/i2p.md).
```

💬 maflcko commented on issue "Bitcoin Core 27 crash at sync - Ubuntu - No error in logs":
(https://github.com/bitcoin/bitcoin/issues/30001#issuecomment-2084400902)
> 2Tb HDD for blockchain storage

What filesystem is the storage? Is it attached via USB? Is the datadir on the storage, or only the blocksdir? What is the full bitcoin config file?

Can you run it in gdb again for a traceback?

Does `dmesg` say anything?

💬 maflcko commented on issue "Error when launching Bitcoin Core":
(https://github.com/bitcoin/bitcoin/issues/29995#issuecomment-2084402738)
> is it supposed to do this? i already had 590gb of the blockchain downloaded.

If you told it to reindex, it will reindex.

👍 fanquake approved a pull request: "depends: Fix build of Qt for 32-bit platforms with recent glibc"
(https://github.com/bitcoin/bitcoin/pull/29985#pullrequestreview-2030292710)
ACK 2e266f33b5d2be5c233c2c692481f75785714fa1 - at some point qt's open source 5.15.x branch will catch up to where they bumped the internal zlib to >= 1.3 (which contains this change), and we'll be able to drop this patch. Checked that it fixes the build issue in the interim.

✅ fanquake closed an issue: "depends: Cross-compiling `qt` for `arm-linux-gnueabihf` fails"
(https://github.com/bitcoin/bitcoin/issues/29980)

🚀 fanquake merged a pull request: "depends: Fix build of Qt for 32-bit platforms with recent glibc"
(https://github.com/bitcoin/bitcoin/pull/29985)

💬 fanquake commented on pull request "depends: Fix build of Qt for 32-bit platforms with recent glibc":
(https://github.com/bitcoin/bitcoin/pull/29985#issuecomment-2084467479)
Backported to 27.x in #29888.

📝 Shutch147 opened a pull request: "Update ci.yml"
(https://github.com/bitcoin/bitcoin/pull/30002)
@Shutch147

<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tes
...

💬 Shutch147 commented on pull request "Update ci.yml":
(https://github.com/bitcoin/bitcoin/pull/30002#issuecomment-2084511110)
@Shutch147

💬 Shutch147 commented on pull request "Update ci.yml":
(https://github.com/bitcoin/bitcoin/pull/30002#issuecomment-2084511598)
@dependabot

💬 vasild commented on issue "Rethink thread_local (take 2)":
(https://github.com/bitcoin/bitcoin/issues/29952#issuecomment-2084511638)
It just occurred to me on Friday evening and I forgot about this during the weekend - we may have a bug in our code and FreeBSD may just be the messenger - we return a reference to the `thread_local`, store it in `CLockLocation`, from there in the global `lockdata` / `lock_stack`. It looks like the reference in `lockdata` may still be existent after the thread has exited.

@maflcko, thanks for the `string_view` hint!

✅ fanquake closed a pull request: "Update ci.yml"
(https://github.com/bitcoin/bitcoin/pull/30002)

📝 fanquake locked a pull request: "Update ci.yml"
(https://github.com/bitcoin/bitcoin/pull/30002)
@Shutch147

<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tes
...

💬 willcl-ark commented on pull request "gui: fix misleading signmessage error with segwit":
(https://github.com/bitcoin-core/gui/pull/819#discussion_r1584338116)
Taken all suggestions, thanks.

👍 willcl-ark approved a pull request: "net: Replace ifname check with IFF_LOOPBACK in Discover"
(https://github.com/bitcoin/bitcoin/pull/29984#pullrequestreview-2030591724)
utACK a68fed111be393ddbbcd7451f78bc63601253ee0

Agree this will be less brittle than name-checking. I don't think it's possible that IFF_LOOPBACK would ever be unset for a loopback device unless someone had modified their kernel.

👍 theStack approved a pull request: "p2p: opportunistically accept 1-parent-1-child packages"
(https://github.com/bitcoin/bitcoin/pull/28970#pullrequestreview-2030612104)
Code-review ACK e518a8bf8abf3d7b83c9013f56d0dca18ae04d6f :package:

👍 dergoegge approved a pull request: "fuzz: don't allow adding duplicate transactions to the mempool"
(https://github.com/bitcoin/bitcoin/pull/29990#pullrequestreview-2030618505)
utACK cc15c5bfd1eb3903de246c124702a7c66c687008

🚀 glozow merged a pull request: "fuzz: don't allow adding duplicate transactions to the mempool"
(https://github.com/bitcoin/bitcoin/pull/29990)

💬 glozow commented on pull request "p2p: opportunistically accept 1-parent-1-child packages":
(https://github.com/bitcoin/bitcoin/pull/28970#issuecomment-2084765381)
Since there are a few ACKs now, listing followups. I plan to open a PR for the first two immediately:
- redundant comment + pass `PackageToValidate` directly https://github.com/bitcoin/bitcoin/pull/28970#pullrequestreview-2025023787
- make `MempoolAcceptResult::m_replaced_transactions` non-optional https://github.com/bitcoin/bitcoin/pull/28970#discussion_r1568781077
- (already in #29974) fix quirks in fuzz/txorphan.cpp https://github.com/bitcoin/bitcoin/pull/28970#discussion_r1576401327
- co
...