📝 kevkevinpal opened a pull request: "doc: removed help text saying that peers may not connect automatically"
(https://github.com/bitcoin/bitcoin/pull/29994)
Introduced in https://github.com/bitcoin/bitcoin/pull/23542 and released in version 23.0 there has been significant time since this change (2 years).

This should be removed as it is no longer relevant

💬 glozow commented on pull request "test: Don't rely on incentive incompatible replacement in mempool_accept_v3.py":
(https://github.com/bitcoin/bitcoin/pull/29986#discussion_r1583168472)
makes sense to me. Use `fee_per_output=fee_to_beat_child2*2` ?

💬 laanwj commented on issue "guix: SOURCE_DATE_EPOCH is already set in some environments":
(https://github.com/bitcoin/bitcoin/issues/29935#issuecomment-2082892926)
Or could cover `SOURCE_DATE_EPOCH` being set under `FORCE_DIRTY_WORKTREE`, it's not strictly the same, but it's also an intentionally introduced mismatch, and would avoid adding another build option.

💬 maflcko commented on pull request "build: Assume HAVE_CONFIG_H, Add IWYU pragma keep to bitcoin-config.h includes":
(https://github.com/bitcoin/bitcoin/pull/29494#issuecomment-2082902935)
> How is it supposed to automatically catch cases when code changes make `#include <config/bitcoin-config.h>` unneeded in a header or source file?

Yes, it is supposed to catch those. This is already the case and unrelated to this pull request. You can try it yourself. The output will be:

```
^^^
None of the files use a symbol declared in the bitcoin-config.h header. However, they are including
the header. Consider removing the unused include.

^---- ⚠️ Failure generated fr
...

💬 maflcko commented on pull request "build: Assume HAVE_CONFIG_H, Add IWYU pragma keep to bitcoin-config.h includes":
(https://github.com/bitcoin/bitcoin/pull/29494#issuecomment-2082903772)
Rebased (should be trivial to re-ACK)

👍 ryanofsky approved a pull request: "RPC: access RPC arguments by name"
(https://github.com/bitcoin/bitcoin/pull/29277#pullrequestreview-2028697430)
Code review ACK 30a6c999351041d6a1e8712a9659be1296a1b46a. Nice change! Implementation is surprisingly simple and additional unit test coverage is welcome, too.

> > Does it work with `OBJ_NAMED_PARAMS`?
>
> Nope. I think we should just address the general use case of getting `OBJ`/`ARR` args with the `Arg` helpers, and then that should help with `OBJ_NAMED_PARAMS` too?

It would be nice to support this for consistency, but benefit is probably more minor since these arguments are already a
...

⚠️ zPapaBear opened an issue: "Error when launching Bitcoin Core"
(https://github.com/bitcoin/bitcoin/issues/29995)
### Is there an existing issue for this?

- [X] I have searched the existing issues

### Current behaviour

Basically im getting this error while launching, and im fairly new to this so trying to understand what i can do to fix after the 600 gb download. i'm not able to download it all again.

### Expected behaviour

the application to run normally

### Steps to reproduce

its just on launch. noth
...

💬 maflcko commented on issue "Error when launching Bitcoin Core":
(https://github.com/bitcoin/bitcoin/issues/29995#issuecomment-2082921899)
Bitcoin Core makes heavy use of CPU, RAM and disk IO. Hardware defects might only become visible when running Bitcoin Core. You might want to check your hardware for defects.

* memtest86 to check your RAM
* to check the CPU behaviour under load, use linpack or Prime95
* to test your storage device use smartctl or CrystalDiskInfo

Source: https://bitcoin.stackexchange.com/a/12206

🚀 ryanofsky merged a pull request: "RPC: access RPC arguments by name"
(https://github.com/bitcoin/bitcoin/pull/29277)

💬 zPapaBear commented on issue "Error when launching Bitcoin Core":
(https://github.com/bitcoin/bitcoin/issues/29995#issuecomment-2082926097)
ram and cpu are fine, and i believe the drive also is working fine. i took the files and moved them to another HDD. still same issue on launch.

💬 maflcko commented on pull request "miniscript: make operator""_mst consteval":
(https://github.com/bitcoin/bitcoin/pull/28657#issuecomment-2082926872)
Could rebase, as CI on master should now be passing with clang-15 in.

💬 maflcko commented on issue "Error when launching Bitcoin Core":
(https://github.com/bitcoin/bitcoin/issues/29995#issuecomment-2082934478)
> i took the files and moved them to another HDD. still same issue on launch.

Yes, file corruption can not be fixed by moving the corrupt files from one storage to another.

👍 hebasto approved a pull request: "system: use %LOCALAPPDATA% as default datadir on windows"
(https://github.com/bitcoin/bitcoin/pull/27064#pullrequestreview-2028718273)
ACK c59b1e45db7b62ba0e0c833e6517045d3dfeacd0, tested on Windows 11 Pro 23H2.

💬 hebasto commented on pull request "system: use %LOCALAPPDATA% as default datadir on windows":
(https://github.com/bitcoin/bitcoin/pull/27064#discussion_r1583207647)
typo:
```suggestion
compatibility if it is present.
```

💬 hebasto commented on pull request "system: use %LOCALAPPDATA% as default datadir on windows":
(https://github.com/bitcoin/bitcoin/pull/27064#discussion_r1583206963)
```suggestion
Windows | `%LOCALAPPDATA%\Bitcoin\` | `C:\Users\username\AppData\Local\Bitcoin\bitcoin.conf`
```

💬 hebasto commented on pull request "system: use %LOCALAPPDATA% as default datadir on windows":
(https://github.com/bitcoin/bitcoin/pull/27064#discussion_r1583208624)
nit: Could add curly braces or put in a single line?

💬 zPapaBear commented on issue "Error when launching Bitcoin Core":
(https://github.com/bitcoin/bitcoin/issues/29995#issuecomment-2082937212)
alright, how can i know which file is corrupt and fix it?

💬 hebasto commented on issue "Error when launching Bitcoin Core":
(https://github.com/bitcoin/bitcoin/issues/29995#issuecomment-2082941948)
> ### How did you obtain Bitcoin Core
>
> Package manager

What package manager exactly?

Does the error happen with the recent official Windows binary from https://bitcoincore.org/bin/bitcoin-core-27.0/ ?

💬 zPapaBear commented on issue "Error when launching Bitcoin Core":
(https://github.com/bitcoin/bitcoin/issues/29995#issuecomment-2082953057)
Direct download from https://bitcoin.org/en/download.
I hope its called a package manager, or its my mistake for filing it as such.

💬 maflcko commented on issue "Error when launching Bitcoin Core":
(https://github.com/bitcoin/bitcoin/issues/29995#issuecomment-2082956240)
> alright, how can i know which file is corrupt and fix it?

I think a `-reindex-chainstate` should be good enough.